You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/04 20:36:41 UTC

[GitHub] [arrow] aucahuasi commented on a change in pull request #10880: ARROW-13509: [C++] Take kernel with empty inputs

aucahuasi commented on a change in pull request #10880:
URL: https://github.com/apache/arrow/pull/10880#discussion_r682941143



##########
File path: cpp/src/arrow/compute/kernels/vector_selection.cc
##########
@@ -2035,7 +2035,7 @@ Result<std::shared_ptr<ChunkedArray>> TakeCC(const ChunkedArray& values,
     ARROW_ASSIGN_OR_RAISE(new_chunks[i],
                           Concatenate(current_chunk->chunks(), ctx->memory_pool()));
   }
-  return std::make_shared<ChunkedArray>(std::move(new_chunks));
+  return std::make_shared<ChunkedArray>(std::move(new_chunks), values.type());

Review comment:
       Thanks for the review @lidavidm I'll address your comments cc @westonpace 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org