You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "stevenzwu (via GitHub)" <gi...@apache.org> on 2023/07/28 03:42:16 UTC
[GitHub] [iceberg] stevenzwu opened a new pull request, #8170: Doc: update Flink get started instruction for 1.16+ due to regression of loading external jar
stevenzwu opened a new pull request, #8170:
URL: https://github.com/apache/iceberg/pull/8170
I ran into this issue when testing Iceberg 1.1 release (with Flink 1.16) back in Nov 2022. But I forgot to update the doc. Dipankar Mazumdar asked me about the same jar loading issue. this can help other new users for just trying out Iceberg with Flink SQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ConeyLiu commented on a diff in pull request #8170: Doc: update Flink get started instruction for 1.16+ due to regression of loading external jar
Posted by "ConeyLiu (via GitHub)" <gi...@apache.org>.
ConeyLiu commented on code in PR #8170:
URL: https://github.com/apache/iceberg/pull/8170#discussion_r1278211496
##########
docs/flink-getting-started.md:
##########
@@ -83,7 +83,12 @@ Start the Flink SQL client. There is a separate `flink-runtime` module in the Ic
# HADOOP_HOME is your hadoop root directory after unpack the binary package.
export HADOOP_CLASSPATH=`$HADOOP_HOME/bin/hadoop classpath`
+# Below works for 1.15 or less
./bin/sql-client.sh embedded -j <flink-runtime-directory>/iceberg-flink-runtime-1.16-{{% icebergVersion %}}.jar shell
Review Comment:
Since it works for 1.15 or less, should change it to `iceberg-flink-runtime-1.15-`? Or use a version variable instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #8170: Doc: update Flink get started instruction for 1.16+ due to regression of loading external jar
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on PR #8170:
URL: https://github.com/apache/iceberg/pull/8170#issuecomment-1660461586
cc @ dipankarmazumdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #8170: Doc: update Flink get started instruction for 1.16+ due to regression of loading external jar
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on code in PR #8170:
URL: https://github.com/apache/iceberg/pull/8170#discussion_r1280744086
##########
docs/flink-getting-started.md:
##########
@@ -83,7 +83,12 @@ Start the Flink SQL client. There is a separate `flink-runtime` module in the Ic
# HADOOP_HOME is your hadoop root directory after unpack the binary package.
export HADOOP_CLASSPATH=`$HADOOP_HOME/bin/hadoop classpath`
+# Below works for 1.15 or less
./bin/sql-client.sh embedded -j <flink-runtime-directory>/iceberg-flink-runtime-1.16-{{% icebergVersion %}}.jar shell
Review Comment:
good catch. fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #8170: Doc: update Flink get started instruction for 1.16+ due to regression of loading external jar
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on PR #8170:
URL: https://github.com/apache/iceberg/pull/8170#issuecomment-1660462553
cc @dipankarmazumdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #8170: Doc: update Flink get started instruction for 1.16+ due to regression of loading external jar
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on PR #8170:
URL: https://github.com/apache/iceberg/pull/8170#issuecomment-1666036513
thx @ConeyLiu for reviewing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu merged pull request #8170: Doc: update Flink get started instruction for 1.16+ due to regression of loading external jar
Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu merged PR #8170:
URL: https://github.com/apache/iceberg/pull/8170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dipankarmazumdar commented on pull request #8170: Doc: update Flink get started instruction for 1.16+ due to regression of loading external jar
Posted by "dipankarmazumdar (via GitHub)" <gi...@apache.org>.
dipankarmazumdar commented on PR #8170:
URL: https://github.com/apache/iceberg/pull/8170#issuecomment-1670437332
Thanks @stevenzwu !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org