You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Micah Kornfield (JIRA)" <ji...@apache.org> on 2019/06/28 12:55:00 UTC
[jira] [Commented] (ARROW-5778) [Java] Extract the logic for vector
data copying to the super classes
[ https://issues.apache.org/jira/browse/ARROW-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874907#comment-16874907 ]
Micah Kornfield commented on ARROW-5778:
----------------------------------------
lets make sure to benchmark/check assembly to ensure no performance regression
> [Java] Extract the logic for vector data copying to the super classes
> ---------------------------------------------------------------------
>
> Key: ARROW-5778
> URL: https://issues.apache.org/jira/browse/ARROW-5778
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java
> Reporter: Liya Fan
> Assignee: Liya Fan
> Priority: Major
>
> Currently, each vector has its own {{copyFrom}} method. The implementations for fixed-width vectors are similar, whereas the implementations for the variable-width vectors are similar.
> This issue extract such implementations to the base classes, with the following benefits:
> 1. Less code makes it easier to maintain
> 2. Move the method to the base class makes the method more convenient to use.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)