You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/23 01:54:05 UTC

[GitHub] [beam] youngoli commented on pull request #12059: Adding a helper function for making custom coders.

youngoli commented on pull request #12059:
URL: https://github.com/apache/beam/pull/12059#issuecomment-647858941


   R: @lostluck 
   
   As an aside, and not in this PR, what do you think about refactoring the locations of all the coder code in the SDK right now. I noticed while trying to figure out how to make some coders that its very unintuitive trying to figure out how to make coders for certain types (for example ints). Right now it seems like built-in coders are all in graph/coder and custom coders for Go types are in runtime/coderx. I was thinking of moving those into the same directory and splitting them into a file for builtin coders, a file for custom coders (for code generation I'm guessing), and a file for helpers for users to create custom coders for various types.
   
   None of that is urgent at all, it's all just stuff that I think makes the SDK a bit more intuitively organized.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org