You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/17 06:57:57 UTC
[GitHub] [skywalking] dmsolr opened a new pull request #4374:
Plugin/removeimage
dmsolr opened a new pull request #4374: Plugin/removeimage
URL: https://github.com/apache/skywalking/pull/4374
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related issues
Enable remove the image on docker exit by configure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4374: [test/plugin]
remove the image on docker exit
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4374: [test/plugin] remove the image on docker exit
URL: https://github.com/apache/skywalking/pull/4374#issuecomment-586856227
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=h1) Report
> Merging [#4374](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/334239388ab57c7884060644716c647073c4876f?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4374 +/- ##
==========================================
+ Coverage 26.09% 26.09% +<.01%
==========================================
Files 1182 1182
Lines 27007 27007
Branches 3723 3723
==========================================
+ Hits 7047 7048 +1
+ Misses 19324 19323 -1
Partials 636 636
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4374/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `69.23% <0%> (+1.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=footer). Last update [3342393...f939fa1](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4374:
[test/plugin] remove the image on docker exit
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4374: [test/plugin] remove the image on docker exit
URL: https://github.com/apache/skywalking/pull/4374#issuecomment-586856227
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=h1) Report
> Merging [#4374](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/334239388ab57c7884060644716c647073c4876f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4374 +/- ##
=======================================
Coverage 26.09% 26.09%
=======================================
Files 1182 1182
Lines 27007 27007
Branches 3723 3723
=======================================
Hits 7047 7047
Misses 19324 19324
Partials 636 636
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=footer). Last update [3342393...f939fa1](https://codecov.io/gh/apache/skywalking/pull/4374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4374: [test/plugin]
remove the image on docker exit
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4374: [test/plugin] remove the image on docker exit
URL: https://github.com/apache/skywalking/pull/4374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services