You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "Hudson (Commented) (JIRA)" <ji...@apache.org> on 2012/02/27 08:00:50 UTC

[jira] [Commented] (AXIOM-29) Inefficient string concatenation in OMElementImpl#getText

    [ https://issues.apache.org/jira/browse/AXIOM-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217082#comment-13217082 ] 

Hudson commented on AXIOM-29:
-----------------------------

Integrated in ws-axiom-trunk #801 (See [https://builds.apache.org/job/ws-axiom-trunk/801/])
    Fixed a regression in OMElement#getTextAsQName caused by the change in getTrimmedText introduced in AXIOM-29. (Revision 1293949)

     Result = SUCCESS
veithen : 
Files : 
* /webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMElement.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMElementImpl.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/OMTestSuiteBuilder.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/element/TestGetTextAsQNameEmpty.java

                
> Inefficient string concatenation in OMElementImpl#getText
> ---------------------------------------------------------
>
>                 Key: AXIOM-29
>                 URL: https://issues.apache.org/jira/browse/AXIOM-29
>             Project: Axiom
>          Issue Type: Bug
>            Reporter: Andreas Veithen
>            Assignee: Rich Scheuerle
>         Attachments: Test.java, wscommons-294.patch.txt
>
>
> The getText method in org.apache.axiom.om.impl.llom.OMElementImpl uses the plus operator to do repetitive string concatenations. This leads to rapid performance degradation when the element contains a large number of text nodes. This may happen in particular when the XMLStreamReader is not coalescing. I believe that this is the root cause of the problem described in the following thread:
> http://www.nabble.com/Process-SOAP-message-containg-XHTML-to14804315.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org