You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/02 23:40:42 UTC

[GitHub] [tvm] insop opened a new pull request #7189: Remove seemingly invalid SoftPlus

insop opened a new pull request #7189:
URL: https://github.com/apache/tvm/pull/7189


   Issue discussed in https://github.com/apache/tvm/issues/7176
   
   - `Softplus` is added in 12/10/2020 from this https://github.com/apache/tvm/pull/7089
   - However, I see that there were `SoftPlus` (not the P is in capital) was already in.
   According to [Onnx spec](https://github.com/onnx/onnx/blob/master/docs/Operators.md), it is `Softplus` not `SoftPlus`.
   
   @jwfromm, @junrushao1994 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #7189: [FRONTEND][ONNX] Remove seemingly invalid SoftPlus

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7189:
URL: https://github.com/apache/tvm/pull/7189


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #7189: Remove seemingly invalid SoftPlus

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #7189:
URL: https://github.com/apache/tvm/pull/7189#issuecomment-753548548


   I didn’t notice that either. Thank you for the PR!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org