[GitHub] [yunikorn-core] manirajv06 commented on a diff in pull request #458: [YUNIKORN-1434] Mark allocation as being preempted

[GitBox <gi...@apache.org>]

manirajv06 commented on code in PR #458:
URL: https://github.com/apache/yunikorn-core/pull/458#discussion_r1036872645


##########
pkg/scheduler/objects/application.go:
##########
@@ -1093,6 +1097,9 @@ func (sa *Application) tryReservedAllocate(headRoom *resources.Resource, nodeIte
 
 		// Do we need a specific node?
 		if ask.GetRequiredNode() != "" {
+			if ask.HasTriggeredPreemption() || time.Since(ask.GetLastPreemptionAttempt()) < sa.preemptionAttemptInterval {

Review Comment:
   Yes, ensuring above three steps is good enough. If we anticipate any failures after marking victim as preempted (third step), we could break this into 1. victim_marked_for_preemption 2. victim_preempted (after core receive the terminated/killed confirmation from shim). This breakage would help us to retry only the victim staying in "victim_marked_for_preemption" state for so long.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org