You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/01/19 12:41:09 UTC
[GitHub] [accumulo] dlmarion opened a new pull request #2420: Remove MiniAccumuloClusterImpl.verifyup
dlmarion opened a new pull request #2420:
URL: https://github.com/apache/accumulo/pull/2420
Reverts the commits associated with this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2420: Remove MiniAccumuloClusterImpl.verifyup
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2420:
URL: https://github.com/apache/accumulo/pull/2420#issuecomment-1016752499
> I would be fine with that. I am still a little concerned if the additional time for every test is worth it, if this really only helps a fraction of the ITs.
Understood. Let's see if it's actually a significant problem first.
> It may be a better use of time to go the other direction, aka streamline the ITs by removing less useful code from the framework (i.e. standalone overhead, support for one-off features, etc.) to try and simplify it.
That's a good idea, too. I wouldn't consider them mutually exclusive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2420: Remove MiniAccumuloClusterImpl.verifyup
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2420:
URL: https://github.com/apache/accumulo/pull/2420#issuecomment-1016717738
I'm not sure this is necessary. I think we can get #2414 to the point where the verifyUp is still helpful, but doesn't cause test problems. Let's try to get #2414 polished, and then merged. And, then if we're still having trouble after a few rounds of testing, and the fix isn't obvious, then we can revisit this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion closed pull request #2420: Remove MiniAccumuloClusterImpl.verifyup
Posted by GitBox <gi...@apache.org>.
dlmarion closed pull request #2420:
URL: https://github.com/apache/accumulo/pull/2420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2420: Remove MiniAccumuloClusterImpl.verifyup
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2420:
URL: https://github.com/apache/accumulo/pull/2420#issuecomment-1016745092
> I'm not sure this is necessary. I think we can get #2414 to the point where the verifyUp is still helpful, but doesn't cause test problems. Let's try to get #2414 polished, and then merged. And, then if we're still having trouble after a few rounds of testing, and the fix isn't obvious, then we can revisit this.
I would be fine with that. I am still a little concerned if the additional time for every test is worth it, if this really only helps a fraction of the ITs.
It may be a better use of time to go the other direction, aka streamline the ITs by removing less useful code from the framework (i.e. standalone overhead, support for one-off features, etc.) to try and simplify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #2420: Remove MiniAccumuloClusterImpl.verifyup
Posted by GitBox <gi...@apache.org>.
dlmarion commented on pull request #2420:
URL: https://github.com/apache/accumulo/pull/2420#issuecomment-1022154225
#2414 was merged. Only one test ( LateLastContactIT.test() ) failed in an IT run on `main` after that merge. I'm going to close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org