[kudu-CR] [sentry] Integrate AuthzProvider into CatalogManager

["Hao Hao (Code Review)" <ge...@cloudera.org>]

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11797 )

Change subject: [sentry] Integrate AuthzProvider into CatalogManager
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11797/3/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/11797/3/src/kudu/master/catalog_manager.cc@753
PS3, Line 753: hms::HmsCatalog::IsEnabled() 
> Isn't this already guaranteed by L726?
Done


http://gerrit.cloudera.org:8080/#/c/11797/3/src/kudu/sentry/sentry_policy_service.thrift
File src/kudu/sentry/sentry_policy_service.thrift:

http://gerrit.cloudera.org:8080/#/c/11797/3/src/kudu/sentry/sentry_policy_service.thrift@26
PS3, Line 26: #   - Rename enum TSentryGrantOption.TRUE and TSentryGrantOption.FALSE to avoid
            : #     conflict with the macro definition in the system header.
> This rename is safe because only the value of the enum is sent on the wire,
Yes, that's my understanding.



-- 
To view, visit http://gerrit.cloudera.org:8080/11797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab4aa027ae6eb4520db48ce348db552c9feec2a8
Gerrit-Change-Number: 11797
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 25 Jan 2019 02:23:03 +0000
Gerrit-HasComments: Yes