[jira] [Commented] (YARN-9270) Minor cleanup in TestFpgaDiscoverer

["Devaraj K (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795675#comment-16795675 ] 

Devaraj K commented on YARN-9270:
---------------------------------

Thanks [~pbacsko] for the patch, latest patch is not getting applied, please update it.

> Minor cleanup in TestFpgaDiscoverer
> -----------------------------------
>
>                 Key: YARN-9270
>                 URL: https://issues.apache.org/jira/browse/YARN-9270
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-9270-001.patch, YARN-9270-002.patch, YARN-9270-003.patch
>
>
> Let's do some cleanup in this class.
> * {{testLinuxFpgaResourceDiscoverPluginConfig}} - this test should be split up to 5 different tests, because it tests 5 different scenarios.
> * remove {{setNewEnvironmentHack()}} - too complicated. We can introduce a {{Function}} in the plugin class like {{Function<String, String> envProvider = System::getenv()}} plus a setter method which allows the test to modify {{envProvider}}. Much simpler and straightfoward.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org