You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/12/06 01:47:04 UTC

[GitHub] john-bodley opened a new pull request #4016: [cache] Using the query as the basis of the cache key

john-bodley opened a new pull request #4016: [cache] Using the query as the basis of the cache key
URL: https://github.com/apache/incubator-superset/pull/4016
 
 
   This PR resolves issue https://github.com/apache/incubator-superset/issues/3840 where previously the visualization data query key was a hashed form of the `form_data`. 
   
   Per the description in the issue the `form_data` stored in the DB which is what the `/warm_up_cache/` endpoint leverages is not the same form data in the explorer view (which is augmented by both the front- and back-ends). Given the cached data is the query response it makes more sense to simply use the hashed query string as the cache key. In addition to resolving this issue the cache is based purely on the relevant portions of the `form_data` which are used to generate the query, thus UI changes to the color palette etc. will not violate the cache. 
   
   to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services