You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/28 08:29:39 UTC
[GitHub] [beam] alive2020 opened a new pull request, #22930: Docs/beam start
alive2020 opened a new pull request, #22930:
URL: https://github.com/apache/beam/pull/22930
**Please** add a meaningful description for your change here
- According to ticket [Beam-2888](https://issues.apache.org/jira/browse/BEAM-2888): Created a completely new Capability Matrix that is based on the ValidatesRunner tests:
- Currently, the implementation includes: getting parsed JSON data from gcloud(manually uploaded) and rendering a small and big Capability Matrix table
In progress: Copy the file from the local directory into Google Cloud Storage.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1271513433
Reminder, please take a look at this pr: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
URL: https://github.com/apache/beam/pull/22930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1279733296
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #22930:
URL: https://github.com/apache/beam/pull/22930#discussion_r980198815
##########
website/www/site/data/capability_matrix.yaml:
##########
@@ -36,1463 +36,1463 @@ capability-matrix:
categories:
- description: What is being computed?
anchor: what
- color-y: "fff"
- color-yb: "f6f6f6"
- color-p: "f9f9f9"
- color-pb: "d8d8d8"
- color-n: "e1e0e0"
- color-nb: "bcbcbc"
+ color-y: 'fff'
Review Comment:
Is there a reason changing " -> '? They look redundant
##########
.gitignore:
##########
@@ -115,8 +115,11 @@ website/www/site/code_samples
website/www/site/_config_branch_repo.toml
website/www/yarn-error.log
!website/www/site/content
+.test-infra/validate-runner/src/main/js/apache-beam-testing-keys.json
# Node
+sdks/typescript/node_modules
+node_modules/**
Review Comment:
There are still multiple website dependency files in the repo root directory e.g. `package-locks.json`, `package.json`, `yarn.lock`. Should organize it in somewhere under `website` folder.
There is already a project root in "website/www/" , there is an `yarn.lock` and `package.json` file there for the website dependency. (and `website/www/node_modules` is already in .gitignore)
Or If it is necessary to create a different project to generete the capability matrix, could move them into `website/generate_capability_matrix` project or so.
May ask @pabloem which one of the choice is preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1242170022
@alive2020 Please DO NOT put service account key into this public repo. They have been disabled once leaked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22930: Docs/beam start
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1229471591
Thanks for the contribution. Could you please set `.gitignore` in your local "nodes_modules"? Those are JavaScript libraries and should not be contained in the Beam repository. Could consider providing a script to setup environment (not familiar with npm here but other people could help).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1256272367
Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22930: Docs/beam start
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1236928221
Reminder, please take a look at this pr: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #22930:
URL: https://github.com/apache/beam/pull/22930#discussion_r967096957
##########
.gitignore:
##########
@@ -115,6 +115,7 @@ website/www/yarn-error.log
# Node
sdks/typescript/node_modules
+node_modules
Review Comment:
```suggestion
node_modules/**
```
##########
.gitignore:
##########
@@ -115,6 +115,7 @@ website/www/yarn-error.log
# Node
sdks/typescript/node_modules
+node_modules
Review Comment:
Add this then run `git rm --cached -r node_modules` and commit the change. This will remove node_modules files from the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alive2020 commented on a diff in pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
alive2020 commented on code in PR #22930:
URL: https://github.com/apache/beam/pull/22930#discussion_r991741842
##########
website/www/site/data/capability_matrix.yaml:
##########
@@ -36,1463 +36,1463 @@ capability-matrix:
categories:
- description: What is being computed?
anchor: what
- color-y: "fff"
- color-yb: "f6f6f6"
- color-p: "f9f9f9"
- color-pb: "d8d8d8"
- color-n: "e1e0e0"
- color-nb: "bcbcbc"
+ color-y: 'fff'
Review Comment:
I think, it's due to my vscode setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alive2020 commented on a diff in pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
alive2020 commented on code in PR #22930:
URL: https://github.com/apache/beam/pull/22930#discussion_r967245088
##########
.gitignore:
##########
@@ -115,6 +115,7 @@ website/www/yarn-error.log
# Node
sdks/typescript/node_modules
+node_modules
Review Comment:
Thank you. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22930: Docs/beam start
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1229411712
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1367900447
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alive2020 commented on pull request #22930: Docs/beam start
Posted by GitBox <gi...@apache.org>.
alive2020 commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1229407586
@pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1373578199
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22930: GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1256159944
Reminder, please take a look at this pr: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22930: Docs/beam start
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22930:
URL: https://github.com/apache/beam/pull/22930#issuecomment-1238433456
ah I can review this btw. @alive2020 please do address @Abacn comment to remove nodes_modlues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org