You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Stephen Fritz (JIRA)" <ji...@apache.org> on 2012/10/26 22:21:12 UTC
[jira] [Created] (HDFS-4117)
FSImage.needsResaveBasedOnStaleCheckpoint multiplies
dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
Stephen Fritz created HDFS-4117:
-----------------------------------
Summary: FSImage.needsResaveBasedOnStaleCheckpoint multiplies dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
Key: HDFS-4117
URL: https://issues.apache.org/jira/browse/HDFS-4117
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Stephen Fritz
Assignee: Stephen Fritz
This is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4117)
FSImage.needsResaveBasedOnStaleCheckpoint multiplies
dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-4117:
---------------------------------
Resolution: Not A Problem
Status: Resolved (was: Patch Available)
I agree - the code is indeed correct as-is.
> FSImage.needsResaveBasedOnStaleCheckpoint multiplies dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4117
> URL: https://issues.apache.org/jira/browse/HDFS-4117
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Stephen Fritz
> Assignee: Stephen Fritz
> Priority: Minor
> Labels: noob
> Attachments: HDFS-4117.patch
>
>
> This is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4117)
FSImage.needsResaveBasedOnStaleCheckpoint multiplies
dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
Posted by "Stephen Fritz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Fritz updated HDFS-4117:
--------------------------------
Labels: noob (was: )
> FSImage.needsResaveBasedOnStaleCheckpoint multiplies dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4117
> URL: https://issues.apache.org/jira/browse/HDFS-4117
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Stephen Fritz
> Assignee: Stephen Fritz
> Priority: Minor
> Labels: noob
>
> This is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4117)
FSImage.needsResaveBasedOnStaleCheckpoint multiplies
dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
Posted by "Stephen Fritz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Fritz updated HDFS-4117:
--------------------------------
Status: Patch Available (was: Open)
changed "(checkpointAge > checkpointPeriod * 1000) to "(checkpointAge > checkpointPeriod)
> FSImage.needsResaveBasedOnStaleCheckpoint multiplies dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4117
> URL: https://issues.apache.org/jira/browse/HDFS-4117
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Stephen Fritz
> Assignee: Stephen Fritz
> Priority: Minor
> Labels: noob
> Attachments: HDFS-4117.patch
>
>
> This is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4117)
FSImage.needsResaveBasedOnStaleCheckpoint multiplies
dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485191#comment-13485191 ]
Todd Lipcon commented on HDFS-4117:
-----------------------------------
Not sure this is right -- checkpointPeriod is in seconds, so we have to multiply by 1000 to compare against the checkpointAge which is in milliseconds, right?
> FSImage.needsResaveBasedOnStaleCheckpoint multiplies dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4117
> URL: https://issues.apache.org/jira/browse/HDFS-4117
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Stephen Fritz
> Assignee: Stephen Fritz
> Priority: Minor
> Labels: noob
> Attachments: HDFS-4117.patch
>
>
> This is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4117)
FSImage.needsResaveBasedOnStaleCheckpoint multiplies
dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
Posted by "Stephen Fritz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Fritz updated HDFS-4117:
--------------------------------
Priority: Minor (was: Major)
> FSImage.needsResaveBasedOnStaleCheckpoint multiplies dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4117
> URL: https://issues.apache.org/jira/browse/HDFS-4117
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Stephen Fritz
> Assignee: Stephen Fritz
> Priority: Minor
> Labels: noob
>
> This is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4117)
FSImage.needsResaveBasedOnStaleCheckpoint multiplies
dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485236#comment-13485236 ]
Hadoop QA commented on HDFS-4117:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551017/HDFS-4117.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3405//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3405//console
This message is automatically generated.
> FSImage.needsResaveBasedOnStaleCheckpoint multiplies dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4117
> URL: https://issues.apache.org/jira/browse/HDFS-4117
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Stephen Fritz
> Assignee: Stephen Fritz
> Priority: Minor
> Labels: noob
> Attachments: HDFS-4117.patch
>
>
> This is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4117)
FSImage.needsResaveBasedOnStaleCheckpoint multiplies
dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486328#comment-13486328 ]
Colin Patrick McCabe commented on HDFS-4117:
--------------------------------------------
The code treats checkpointAge "as if it were in milliseconds" because it *is* in milliseconds.
Check the documentaton for {{Time.now()}} and {{File#lastModified}}, used to calculate checkpointAge.
{code}
/**
* Current system time. Do not use this to calculate a duration or interval
* to sleep, because it will be broken by settimeofday. Instead, use
* monotonicNow.
* @return current time in msec.
*/
public static long now() {
return System.currentTimeMillis();
}
{code}
So basically the code does not need to be changed.
To avoid this kind of confusion in the future, it would be a good idea to add a comment specifying that {{dfs.namenode.checkpoint.period}} is in seconds.
> FSImage.needsResaveBasedOnStaleCheckpoint multiplies dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4117
> URL: https://issues.apache.org/jira/browse/HDFS-4117
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Stephen Fritz
> Assignee: Stephen Fritz
> Priority: Minor
> Labels: noob
> Attachments: HDFS-4117.patch
>
>
> This is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4117)
FSImage.needsResaveBasedOnStaleCheckpoint multiplies
dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
Posted by "Stephen Fritz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Fritz updated HDFS-4117:
--------------------------------
Attachment: HDFS-4117.patch
> FSImage.needsResaveBasedOnStaleCheckpoint multiplies dfs.namenode.checkpoint.period by 1000 as if it were in milliseconds.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-4117
> URL: https://issues.apache.org/jira/browse/HDFS-4117
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Stephen Fritz
> Assignee: Stephen Fritz
> Priority: Minor
> Labels: noob
> Attachments: HDFS-4117.patch
>
>
> This is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira