You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/06/10 10:17:24 UTC
[GitHub] zeppelin pull request #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completi...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/988
ZEPPELIN-985 ] Fixed bug in the Pyspark completion
### What is this PR for?
Currently, does not work 'pyspark completion'.
### What type of PR is it?
Bug Fix
### Todos
- [x] - change standard output for completion to interpreter outer.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-985
### How should this be tested?
Try keyword completion for pyspark interpreter.
### Screenshots (if appropriate)
#### Before

#### After

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin hotfix/nwPyspark
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/988.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #988
----
commit 7c09a7a1b2f5913b7f7ea654cf3c8e8d54e22dc1
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-10T09:57:16Z
fixed pyspark completion.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completion
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/988
Merge if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completion
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/988
retry ci
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completi...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/988
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completi...
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/988
ZEPPELIN-985 ] Fixed bug in the Pyspark completion
### What is this PR for?
Currently, does not work 'pyspark completion'.
### What type of PR is it?
Bug Fix
### Todos
- [x] - change standard output for completion to interpreter outer.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-985
### How should this be tested?
Try keyword completion for pyspark interpreter.
### Screenshots (if appropriate)
#### Before

#### After

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin hotfix/nwPyspark
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/988.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #988
----
commit 7c09a7a1b2f5913b7f7ea654cf3c8e8d54e22dc1
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-10T09:57:16Z
fixed pyspark completion.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completion
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/988
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completi...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/988
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completion
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/988
@cloverhearts Thank you for quick fixing ! I closed my issue [ZEPPELIN-984](https://issues.apache.org/jira/browse/ZEPPELIN-984) since they are duplicated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completion
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/988
@cloverhearts I tested and it works well \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completion
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/988
Tested and it works well.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/988
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #988: ZEPPELIN-985 ] Fixed bug in the Pyspark completi...
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/988
ZEPPELIN-985 ] Fixed bug in the Pyspark completion
### What is this PR for?
Currently, does not work 'pyspark completion'.
### What type of PR is it?
Bug Fix
### Todos
- [x] - change standard output for completion to interpreter outer.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-985
### How should this be tested?
Try keyword completion for pyspark interpreter.
### Screenshots (if appropriate)
#### Before

#### After

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin hotfix/nwPyspark
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/988.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #988
----
commit 7c09a7a1b2f5913b7f7ea654cf3c8e8d54e22dc1
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-10T09:57:16Z
fixed pyspark completion.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---