You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/22 10:49:20 UTC

[GitHub] [arrow-rs] alamb opened a new pull request #483: Cherry pick remove unnecessary wraps in sort to active_release

alamb opened a new pull request #483:
URL: https://github.com/apache/arrow-rs/pull/483


   Automatic cherry-pick of efe86cd
   * Originally appeared in https://github.com/apache/arrow-rs/pull/445: remove unnecessary wraps in sort
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] codecov-commenter commented on pull request #483: Cherry pick remove unnecessary wraps in sort to active_release

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #483:
URL: https://github.com/apache/arrow-rs/pull/483#issuecomment-865886366


   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/483?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#483](https://codecov.io/gh/apache/arrow-rs/pull/483?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (148daa4) into [active_release](https://codecov.io/gh/apache/arrow-rs/commit/b5e50efa6d8d7499e7785b2862eb60e19770ea11?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5e50ef) will **decrease** coverage by `0.01%`.
   > The diff coverage is `52.38%`.
   
   > :exclamation: Current head 148daa4 differs from pull request most recent head b6f7e5e. Consider uploading reports for the commit b6f7e5e to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/483/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@                Coverage Diff                 @@
   ##           active_release     #483      +/-   ##
   ==================================================
   - Coverage           82.72%   82.70%   -0.02%     
   ==================================================
     Files                 163      163              
     Lines               44802    44813      +11     
   ==================================================
   + Hits                37061    37062       +1     
   - Misses               7741     7751      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/483?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [arrow/src/compute/kernels/sort.rs](https://codecov.io/gh/apache/arrow-rs/pull/483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9zb3J0LnJz) | `94.11% <52.38%> (-0.86%)` | :arrow_down: |
   | [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/483/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `95.04% <0.00%> (+0.19%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/483?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/483?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b5e50ef...b6f7e5e](https://codecov.io/gh/apache/arrow-rs/pull/483?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] alamb merged pull request #483: Cherry pick remove unnecessary wraps in sort to active_release

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #483:
URL: https://github.com/apache/arrow-rs/pull/483


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-rs] jhorstmann commented on pull request #483: Cherry pick remove unnecessary wraps in sort to active_release

Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #483:
URL: https://github.com/apache/arrow-rs/pull/483#issuecomment-866694098


   Looks good. The only signature changes are for private functions so should be compatible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org