[GitHub] [pulsar] lovelle commented on a change in pull request #3988: [issue #3975] Bugfix NPE on non durable consumer

[GitBox <gi...@apache.org>]

lovelle commented on a change in pull request #3988: [issue #3975] Bugfix NPE on non durable consumer
URL: https://github.com/apache/pulsar/pull/3988#discussion_r272656686
 
 

 ##########
 File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
 ##########
 @@ -193,6 +193,7 @@
      * @return the new NonDurableCursor
      */
     ManagedCursor newNonDurableCursor(Position startCursorPosition) throws ManagedLedgerException;
+    ManagedCursor newNonDurableCursor(Position startPosition, String subscriptionName) throws ManagedLedgerException;
 
 Review comment:
   I think that the correct action here would be to modify existing `newNonDurableCursor` instead of adding a new one, but I did that way in order to leave this change as easy as possible, please let me know what you think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services