You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/27 02:33:21 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1593: API service adds some test cases
codecov-io edited a comment on issue #1593: API service adds some test cases
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1593#issuecomment-569167960
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593?src=pr&el=h1) Report
> Merging [#1593](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/90730133ac560770683c22d7e73713b43a0f41ea?src=pr&el=desc) will **increase** coverage by `5.96%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1593 +/- ##
=========================================
+ Coverage 9.06% 15.03% +5.96%
=========================================
Files 283 283
Lines 13843 13895 +52
Branches 2204 2220 +16
=========================================
+ Hits 1255 2089 +834
+ Misses 12495 11618 -877
- Partials 93 188 +95
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../apache/dolphinscheduler/api/utils/CheckUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL0NoZWNrVXRpbHMuamF2YQ==) | `45.83% <100%> (+8.33%)` | :arrow_up: |
| [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100% <100%> (ø)` | :arrow_up: |
| [...lphinscheduler/api/service/AccessTokenService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvQWNjZXNzVG9rZW5TZXJ2aWNlLmphdmE=) | `91.07% <100%> (+91.07%)` | :arrow_up: |
| [...e/dolphinscheduler/api/service/UdfFuncService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVWRmRnVuY1NlcnZpY2UuamF2YQ==) | `86.84% <100%> (+86.84%)` | :arrow_up: |
| [...olphinscheduler/api/service/AlertGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvQWxlcnRHcm91cFNlcnZpY2UuamF2YQ==) | `88.76% <100%> (+88.76%)` | :arrow_up: |
| [...lphinscheduler/api/service/WorkerGroupService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvV29ya2VyR3JvdXBTZXJ2aWNlLmphdmE=) | `70.31% <14.28%> (+70.31%)` | :arrow_up: |
| [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `73.57% <56.66%> (+73.57%)` | :arrow_up: |
| [...e/dolphinscheduler/api/service/ProjectService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvamVjdFNlcnZpY2UuamF2YQ==) | `86.36% <71.42%> (+86.36%)` | :arrow_up: |
| [...olphinscheduler/api/controller/BaseController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvQmFzZUNvbnRyb2xsZXIuamF2YQ==) | `3.65% <0%> (+3.65%)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593?src=pr&el=footer). Last update [9073013...440c020](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1593?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services