[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #13077: [Bug] [task retry] Clone retry task Instance missing id field

[GitBox <gi...@apache.org>]

EricGao888 commented on code in PR #13077:
URL: https://github.com/apache/dolphinscheduler/pull/13077#discussion_r1038782946


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/StateWheelExecuteThread.java:
##########
@@ -422,7 +422,6 @@ private void addProcessStopEvent(ProcessInstance processInstance) {
     private void addTaskRetryEvent(TaskInstance taskInstance) {
         TaskStateEvent stateEvent = TaskStateEvent.builder()
                 .processInstanceId(taskInstance.getProcessInstanceId())
-                .taskInstanceId(taskInstance.getId())

Review Comment:
   Just curious, why you choose to avoid using `getId` here instead of generating and setting an id for the retried task instance?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org