[GitHub] [shardingsphere-on-cloud] mlycore commented on a diff in pull request #286: Add ShardingSphereChaos CRD and convert chaos to Chaos Mesh logic in Reconcile function

["mlycore (via GitHub)" <gi...@apache.org>]

mlycore commented on code in PR #286:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/286#discussion_r1152797698


##########
shardingsphere-operator/api/v1alpha1/shardingsphere_chaos_types.go:
##########
@@ -36,12 +40,475 @@ type ShardingSphereChaos struct {
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
 	Spec ShardingSphereChaosSpec `json:"spec,omitempty"`
-	// +optional
+
 	Status ShardingSphereChaosStatus `json:"status,omitempty"`
 }
 
 // ShardingSphereChaosSpec defines the desired state of ShardingSphereChaos
-type ShardingSphereChaosSpec struct{}
+type ShardingSphereChaosSpec struct {
+	InjectReqs batchV1Beta1.JobTemplateSpec `json:"injectReqs,omitempty"`

Review Comment:
   Consider update this name to InjectRequest or InjectJob?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org