You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/12 08:21:13 UTC
Review Request 28985: Updated Resources interface to expose
reservations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28985/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
This makes the reservations very explicit in the interface, and is used in the upcoming allocator changes.
Diffs
-----
include/mesos/resources.hpp 10777a62492e4a3333d764e0f75c064694e054d1
src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e
src/tests/resources_tests.cpp cfad93826f8a1f574c45fe7638d056bd5a275e54
Diff: https://reviews.apache.org/r/28985/diff/
Testing
-------
Added tests.
make check
Thanks,
Ben Mahler
Re: Review Request 28985: Updated Resources interface to expose
reservations.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28985/#review64937
-----------------------------------------------------------
Ship it!
include/mesos/resources.hpp
<https://reviews.apache.org/r/28985/#comment107780>
Please add a note about the case where role equals to star here. What will be returned if role is star here?
src/tests/resources_tests.cpp
<https://reviews.apache.org/r/28985/#comment107782>
New line above this line?
- Jie Yu
On Dec. 12, 2014, 7:21 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28985/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 7:21 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This makes the reservations very explicit in the interface, and is used in the upcoming allocator changes.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 10777a62492e4a3333d764e0f75c064694e054d1
> src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e
> src/tests/resources_tests.cpp cfad93826f8a1f574c45fe7638d056bd5a275e54
>
> Diff: https://reviews.apache.org/r/28985/diff/
>
>
> Testing
> -------
>
> Added tests.
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>