You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/23 09:59:22 UTC
[GitHub] [spark] shardulm94 opened a new pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
shardulm94 opened a new pull request #31623:
URL: https://github.com/apache/spark/pull/31623
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
SPARK-33084 added the ability to use ivy coordinates with `SparkContext.addJar`. PR #29966 claims to mimic Hive behavior although I found a few cases where it doesn't
1) The default value of the transitive parameter is false, both in case of parameter not being specified in coordinate or parameter value being invalid. The Hive behavior is transitive is [true if not specified](https://github.com/apache/hive/blob/cb2ac3dcc6af276c6f64ee00f034f082fe75222b/ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java#L169) in the coordinate and [false for invalid values](https://github.com/apache/hive/blob/cb2ac3dcc6af276c6f64ee00f034f082fe75222b/ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java#L124). Also, regardless of Hive, I think a default of true for the transitive parameter also matches [ivy's own defaults](https://ant.apache.org/ivy/history/2.5.0/ivyfile/dependency.html#_attributes).
2) The parameter value for transitive parameter is regarded as case-sensitive [based on the understanding](https://github.com/apache/spark/pull/29966#discussion_r547752259) that Hive behavior is case-sensitive. However, this is not correct, Hive [treats the parameter value case-insensitively](https://github.com/apache/hive/blob/cb2ac3dcc6af276c6f64ee00f034f082fe75222b/ql/src/java/org/apache/hadoop/hive/ql/util/DependencyResolver.java#L122).
I propose that we be compatible with Hive for these behaviors
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
To make `ADD JAR` with ivy coordinates compatible with Hive's transitive behavior
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
The user-facing changes here are within master as the feature introduced in SPARK-33084 has not been released yet
1. Previously an ivy coordinate without `transitive` parameter specified did not resolve transitive dependency, now it does.
2. Previously an `transitive` parameter value was treated case-sensitively. e.g. `transitive=TRUE` would be treated as false as it did not match exactly `true`. Now it will be treated case-insensitively.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Modified existing unit tests to test new behavior
Add new unit test to cover usage of `exclude` with unspecified `transitive`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784723103
**[Test build #135400 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135400/testReport)** for PR 31623 at commit [`c63b605`](https://github.com/apache/spark/commit/c63b605ac65bd74c6647bf59b261e6412982e1e2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784709351
cc @maropu and @dongjoon-hyun too FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784728713
Oh, I see. Nice catch.
> The Hive behavior is that transitive is true if not specified in the coordinate and false for invalid values.
Just to check; all the released Hive versions having this feature have the same default behaviour?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784751877
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39980/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784085845
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784731279
I left some minor comments though, the proposal itself seems okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784814542
**[Test build #135400 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135400/testReport)** for PR 31623 at commit [`c63b605`](https://github.com/apache/spark/commit/c63b605ac65bd74c6647bf59b261e6412982e1e2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-785408404
**[Test build #135439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135439/testReport)** for PR 31623 at commit [`61db81b`](https://github.com/apache/spark/commit/61db81b54e595819d5c32f59bbdf2a1490b9fb8b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784709114
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on a change in pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
xkrogen commented on a change in pull request #31623:
URL: https://github.com/apache/spark/pull/31623#discussion_r581286378
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -1224,7 +1224,10 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
test("SPARK-33084: Add jar support Ivy URI in SQL") {
val testData = TestHive.getHiveFile("data/files/sample.json").toURI
withTable("t") {
- sql(s"ADD JAR ivy://org.apache.hive.hcatalog:hive-hcatalog-core:$hiveVersion")
+ // exclude org.pentaho:pentaho-aggdesigner-algorithm as this transitive dependency does
+ // not exist on mavencentral and hence cannot be found in the test environment
+ sql(s"ADD JAR ivy://org.apache.hive.hcatalog:hive-hcatalog-core:$hiveVersion" +
+ "?exclude=org.pentaho:pentaho-aggdesigner-algorithm")
Review comment:
Yikes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on a change in pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
xkrogen commented on a change in pull request #31623:
URL: https://github.com/apache/spark/pull/31623#discussion_r581209555
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -1224,7 +1224,10 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
test("SPARK-33084: Add jar support Ivy URI in SQL") {
val testData = TestHive.getHiveFile("data/files/sample.json").toURI
withTable("t") {
- sql(s"ADD JAR ivy://org.apache.hive.hcatalog:hive-hcatalog-core:$hiveVersion")
+ // exclude org.pentaho:pentaho-aggdesigner-algorithm as this transitive dependency does
+ // not exist on mavencentral and hence cannot be found in the test environment
+ sql(s"ADD JAR ivy://org.apache.hive.hcatalog:hive-hcatalog-core:$hiveVersion" +
+ "?exclude=org.pentaho:pentaho-aggdesigner-algorithm")
Review comment:
This is odd. Any idea why `hive-hcatalog-core` has a dependency on a package that doesn't exist?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-786643659
If no one has more comments, I'll merge this in a few days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784794518
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39980/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784821269
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135400/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784085845
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784794538
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39980/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-787573815
Thanks @maropu for taking care of this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 edited a comment on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
shardulm94 edited a comment on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-785385284
> Just to check; all the released Hive versions having this feature have the same default behaviour?
@maropu Yes, the behaviour has been this way since it was added in [HIVE-9664](https://issues.apache.org/jira/browse/HIVE-9664).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-785460667
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40019/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-785484304
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135439/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-785385284
> Just to check; all the released Hive versions having this feature have the same default behaviour?
Yes, the behaviour has been this way since it was added in [HIVE-9664](https://issues.apache.org/jira/browse/HIVE-9664).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784723103
**[Test build #135400 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135400/testReport)** for PR 31623 at commit [`c63b605`](https://github.com/apache/spark/commit/c63b605ac65bd74c6647bf59b261e6412982e1e2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-787577830
Thank you, @shardulm94 and all. Like @xkrogen said, it's really nice to fix this at the early stage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on a change in pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on a change in pull request #31623:
URL: https://github.com/apache/spark/pull/31623#discussion_r581285561
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -1224,7 +1224,10 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
test("SPARK-33084: Add jar support Ivy URI in SQL") {
val testData = TestHive.getHiveFile("data/files/sample.json").toURI
withTable("t") {
- sql(s"ADD JAR ivy://org.apache.hive.hcatalog:hive-hcatalog-core:$hiveVersion")
+ // exclude org.pentaho:pentaho-aggdesigner-algorithm as this transitive dependency does
+ // not exist on mavencentral and hence cannot be found in the test environment
+ sql(s"ADD JAR ivy://org.apache.hive.hcatalog:hive-hcatalog-core:$hiveVersion" +
+ "?exclude=org.pentaho:pentaho-aggdesigner-algorithm")
Review comment:
This is a very infamous dependency brought in by calcite. It does not exist on mavencentral but it does exist on conjars.org. Here is a Stack overflow asking about the same issue. https://stackoverflow.com/questions/32587769/dependency-resolution-issue-in-gradle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784821269
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135400/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-785481683
**[Test build #135439 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135439/testReport)** for PR 31623 at commit [`61db81b`](https://github.com/apache/spark/commit/61db81b54e595819d5c32f59bbdf2a1490b9fb8b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784707913
Thanks for your double check, nice catch, I miss some point when check hive's behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-785484304
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135439/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-787552666
Thanks! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #31623:
URL: https://github.com/apache/spark/pull/31623
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-785460667
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40019/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-785408404
**[Test build #135439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135439/testReport)** for PR 31623 at commit [`61db81b`](https://github.com/apache/spark/commit/61db81b54e595819d5c32f59bbdf2a1490b9fb8b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31623:
URL: https://github.com/apache/spark/pull/31623#discussion_r581596104
##########
File path: core/src/main/scala/org/apache/spark/util/DependencyUtils.scala
##########
@@ -59,8 +59,8 @@ private[spark] object DependencyUtils extends Logging {
* @param uri Ivy URI need to be downloaded.
* @return Tuple value of parameter `transitive` and `exclude` value.
*
- * 1. transitive: whether to download dependency jar of Ivy URI, default value is false
- * and this parameter value is case-sensitive. Invalid value will be treat as false.
+ * 1. transitive: whether to download dependency jar of Ivy URI, default value is true
+ * and this parameter value is case-insensitive. Invalid value will be treat as false.
Review comment:
Could you leave some comments like `this behaviour follows hive one...`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31623:
URL: https://github.com/apache/spark/pull/31623#discussion_r581598157
##########
File path: docs/sql-ref-syntax-aux-resource-mgmt-add-jar.md
##########
@@ -36,7 +36,7 @@ ADD JAR file_name
The name of the JAR file to be added. It could be either on a local file system or a distributed file system or an Ivy URI.
Apache Ivy is a popular dependency manager focusing on flexibility and simplicity. Now we support two parameter in URI query string:
- * transitive: whether to download dependent jars related to your ivy URL. It is case-sensitive and only take last one if multiple transitive parameters are specified.
+ * transitive: whether to download dependent jars related to your ivy URL. The parameter name is case-sensitive, parameter value is case-insensitive and only take last one if multiple transitive parameters are specified.
Review comment:
Could you split the second statement into two parts? e.g.,
```
The parameter name is case-sensitive and the parameter value is case-insensitive. If multiple transitive parameters are specified, the last one wins.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784112913
cc @AngersZhuuuu @wangyum FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31623:
URL: https://github.com/apache/spark/pull/31623#issuecomment-784794538
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39980/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on a change in pull request #31623: [SPARK-34506][CORE] ADD JAR with ivy coordinates should be compatible with Hive transitive behavior
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on a change in pull request #31623:
URL: https://github.com/apache/spark/pull/31623#discussion_r582304805
##########
File path: core/src/main/scala/org/apache/spark/util/DependencyUtils.scala
##########
@@ -59,8 +59,8 @@ private[spark] object DependencyUtils extends Logging {
* @param uri Ivy URI need to be downloaded.
* @return Tuple value of parameter `transitive` and `exclude` value.
*
- * 1. transitive: whether to download dependency jar of Ivy URI, default value is false
- * and this parameter value is case-sensitive. Invalid value will be treat as false.
+ * 1. transitive: whether to download dependency jar of Ivy URI, default value is true
+ * and this parameter value is case-insensitive. Invalid value will be treat as false.
Review comment:
Fixed
##########
File path: core/src/main/scala/org/apache/spark/util/DependencyUtils.scala
##########
@@ -59,8 +59,8 @@ private[spark] object DependencyUtils extends Logging {
* @param uri Ivy URI need to be downloaded.
* @return Tuple value of parameter `transitive` and `exclude` value.
*
- * 1. transitive: whether to download dependency jar of Ivy URI, default value is false
- * and this parameter value is case-sensitive. Invalid value will be treat as false.
+ * 1. transitive: whether to download dependency jar of Ivy URI, default value is true
+ * and this parameter value is case-insensitive. Invalid value will be treat as false.
Review comment:
Done
##########
File path: docs/sql-ref-syntax-aux-resource-mgmt-add-jar.md
##########
@@ -36,7 +36,7 @@ ADD JAR file_name
The name of the JAR file to be added. It could be either on a local file system or a distributed file system or an Ivy URI.
Apache Ivy is a popular dependency manager focusing on flexibility and simplicity. Now we support two parameter in URI query string:
- * transitive: whether to download dependent jars related to your ivy URL. It is case-sensitive and only take last one if multiple transitive parameters are specified.
+ * transitive: whether to download dependent jars related to your ivy URL. The parameter name is case-sensitive, parameter value is case-insensitive and only take last one if multiple transitive parameters are specified.
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org