[GitHub] [james-project] woj-tek commented on a diff in pull request #1618: JAMES-3921: Use lenient parser, which should help parsing invalid datetime fields

["woj-tek (via GitHub)" <gi...@apache.org>]

woj-tek commented on code in PR #1618:
URL: https://github.com/apache/james-project/pull/1618#discussion_r1247199901


##########
mailbox/lucene/src/test/java/org/apache/james/mailbox/lucene/search/LuceneMailboxMessageSearchIndexTest.java:
##########
@@ -227,6 +229,27 @@ void bodySearchShouldNotMatchPhraseOnlyInSubject() throws Exception {
         assertThat(result).isEmpty();
     }
 
+    @Test
+    void dateHeaderParsingShouldNotImpactProcessing() throws Exception {

Review Comment:
   Yes:
   
   ```
   $ mvn test -Dtest=org.apache.james.mailbox.lucene.search.LuceneMailboxMessageSearchIndexTest#dateHeaderParsingShouldNotImpactProcessing
   …
   17:35:13,045 [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.477 s <<< FAILURE! - in org.apache.james.mailbox.lucene.search.LuceneMailboxMessageSearchIndexTest
   17:35:13,046 [ERROR] dateHeaderParsingShouldNotImpactProcessing  Time elapsed: 0.415 s  <<< ERROR!
   org.apache.james.mime4j.field.datetime.parser.TokenMgrError: Lexical error at line 1, column 3.  Encountered: "." (46), after : ""
   	at org.apache.james.mailbox.lucene.search.LuceneMailboxMessageSearchIndexTest.dateHeaderParsingShouldNotImpactProcessing(LuceneMailboxMessageSearchIndexTest.java:246)
   ```
   
   And passes just fine with https://github.com/apache/james-mime4j/pull/88 (though, It's just ignoring the parsing problem).
   
   Btw. what's the general consensus/flow when it comes to fixes in dependent libraries?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org