You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by yao lei <le...@163.com> on 2017/05/23 08:10:22 UTC
Review Request 59485: Edit notifications options are always grey but
can click and open a popup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako.
Bugs: AMBARI-21097
https://issues.apache.org/jira/browse/AMBARI-21097
Repository: ambari
Description
-------
STR:
1.Open Alerts / Actions / Manage Alert Notifications
2.Create an alert notification named test
3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
Diffs
-----
ambari-web/app/mappers/alert_notification_mapper.js 037c418
ambari-web/app/models/alerts/alert_notification.js c2d7570
Diff: https://reviews.apache.org/r/59485/diff/1/
Testing
-------
1.cd ambari-web & mvn test
30383 passing (34s)
157 pending
2.Tested in a cluster
Thanks,
yao lei
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by yao lei <le...@163.com>.
> On 六月 5, 2017, 2:28 p.m., Alexandr Antonenko wrote:
> > Ship It!
Thanks for you review.
- yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review176914
-----------------------------------------------------------
On 六月 5, 2017, 10:28 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> -----------------------------------------------------------
>
> (Updated 六月 5, 2017, 10:28 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two Problems
>
> Steps to reproduce problem one (see notifiction.png):
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
>
> Steps to reproduce problem two(see notification-2.png):
> 1.Open Alerts / Actions / Manage Alert Notifications and delete all notifications if exit
> 2.Firstly click the gear icon and then click Edit(Duplicate) item, some errors will ouput in browser console.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/alert_notification_mapper.js 037c418
> ambari-web/app/models/alerts/alert_notification.js c2d7570
> ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs da8faa8
> ambari-web/app/views/main/alerts/manage_alert_notifications_view.js aa05f86
>
>
> Diff: https://reviews.apache.org/r/59485/diff/2/
>
>
> Testing
> -------
>
> 1.cd ambari-web & mvn test
> 30383 passing (34s)
> 157 pending
>
> 2.Tested in a cluster
>
>
> File Attachments
> ----------------
>
> notification-2.png
> https://reviews.apache.org/media/uploaded/files/2017/06/05/9c1d5973-8ced-4483-bdd3-e3d461c5dee2__notification-2.png
> notification.png
> https://reviews.apache.org/media/uploaded/files/2017/06/05/5ddcf172-e529-40ec-abe0-6c0cee83208f__notification.png
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review176914
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On June 5, 2017, 10:28 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> -----------------------------------------------------------
>
> (Updated June 5, 2017, 10:28 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two Problems
>
> Steps to reproduce problem one (see notifiction.png):
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
>
> Steps to reproduce problem two(see notification-2.png):
> 1.Open Alerts / Actions / Manage Alert Notifications and delete all notifications if exit
> 2.Firstly click the gear icon and then click Edit(Duplicate) item, some errors will ouput in browser console.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/alert_notification_mapper.js 037c418
> ambari-web/app/models/alerts/alert_notification.js c2d7570
> ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs da8faa8
> ambari-web/app/views/main/alerts/manage_alert_notifications_view.js aa05f86
>
>
> Diff: https://reviews.apache.org/r/59485/diff/2/
>
>
> Testing
> -------
>
> 1.cd ambari-web & mvn test
> 30383 passing (34s)
> 157 pending
>
> 2.Tested in a cluster
>
>
> File Attachments
> ----------------
>
> notification-2.png
> https://reviews.apache.org/media/uploaded/files/2017/06/05/9c1d5973-8ced-4483-bdd3-e3d461c5dee2__notification-2.png
> notification.png
> https://reviews.apache.org/media/uploaded/files/2017/06/05/5ddcf172-e529-40ec-abe0-6c0cee83208f__notification.png
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by yao lei <le...@163.com>.
> On 六月 5, 2017, 8:54 p.m., Richard Zang wrote:
> > Ship It!
Thanks for your review
- yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review176949
-----------------------------------------------------------
On 六月 5, 2017, 10:28 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> -----------------------------------------------------------
>
> (Updated 六月 5, 2017, 10:28 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two Problems
>
> Steps to reproduce problem one (see notifiction.png):
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
>
> Steps to reproduce problem two(see notification-2.png):
> 1.Open Alerts / Actions / Manage Alert Notifications and delete all notifications if exit
> 2.Firstly click the gear icon and then click Edit(Duplicate) item, some errors will ouput in browser console.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/alert_notification_mapper.js 037c418
> ambari-web/app/models/alerts/alert_notification.js c2d7570
> ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs da8faa8
> ambari-web/app/views/main/alerts/manage_alert_notifications_view.js aa05f86
>
>
> Diff: https://reviews.apache.org/r/59485/diff/2/
>
>
> Testing
> -------
>
> 1.cd ambari-web & mvn test
> 30383 passing (34s)
> 157 pending
>
> 2.Tested in a cluster
>
>
> File Attachments
> ----------------
>
> notification-2.png
> https://reviews.apache.org/media/uploaded/files/2017/06/05/9c1d5973-8ced-4483-bdd3-e3d461c5dee2__notification-2.png
> notification.png
> https://reviews.apache.org/media/uploaded/files/2017/06/05/5ddcf172-e529-40ec-abe0-6c0cee83208f__notification.png
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review176949
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On June 5, 2017, 10:28 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> -----------------------------------------------------------
>
> (Updated June 5, 2017, 10:28 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two Problems
>
> Steps to reproduce problem one (see notifiction.png):
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
>
> Steps to reproduce problem two(see notification-2.png):
> 1.Open Alerts / Actions / Manage Alert Notifications and delete all notifications if exit
> 2.Firstly click the gear icon and then click Edit(Duplicate) item, some errors will ouput in browser console.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/alert_notification_mapper.js 037c418
> ambari-web/app/models/alerts/alert_notification.js c2d7570
> ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs da8faa8
> ambari-web/app/views/main/alerts/manage_alert_notifications_view.js aa05f86
>
>
> Diff: https://reviews.apache.org/r/59485/diff/2/
>
>
> Testing
> -------
>
> 1.cd ambari-web & mvn test
> 30383 passing (34s)
> 157 pending
>
> 2.Tested in a cluster
>
>
> File Attachments
> ----------------
>
> notification-2.png
> https://reviews.apache.org/media/uploaded/files/2017/06/05/9c1d5973-8ced-4483-bdd3-e3d461c5dee2__notification-2.png
> notification.png
> https://reviews.apache.org/media/uploaded/files/2017/06/05/5ddcf172-e529-40ec-abe0-6c0cee83208f__notification.png
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by yao lei <le...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/
-----------------------------------------------------------
(Updated June 5, 2017, 10:28 a.m.)
Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako.
Bugs: AMBARI-21097
https://issues.apache.org/jira/browse/AMBARI-21097
Repository: ambari
Description (updated)
-------
Two Problems
Steps to reproduce problem one (see notifiction.png):
1.Open Alerts / Actions / Manage Alert Notifications
2.Create an alert notification named test
3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
Steps to reproduce problem two(see notification-2.png):
1.Open Alerts / Actions / Manage Alert Notifications and delete all notifications if exit
2.Firstly click the gear icon and then click Edit(Duplicate) item, some errors will ouput in browser console.
Diffs (updated)
-----
ambari-web/app/mappers/alert_notification_mapper.js 037c418
ambari-web/app/models/alerts/alert_notification.js c2d7570
ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs da8faa8
ambari-web/app/views/main/alerts/manage_alert_notifications_view.js aa05f86
Diff: https://reviews.apache.org/r/59485/diff/2/
Changes: https://reviews.apache.org/r/59485/diff/1-2/
Testing
-------
1.cd ambari-web & mvn test
30383 passing (34s)
157 pending
2.Tested in a cluster
File Attachments (updated)
----------------
notification-2.png
https://reviews.apache.org/media/uploaded/files/2017/06/05/9c1d5973-8ced-4483-bdd3-e3d461c5dee2__notification-2.png
notification.png
https://reviews.apache.org/media/uploaded/files/2017/06/05/5ddcf172-e529-40ec-abe0-6c0cee83208f__notification.png
Thanks,
yao lei
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by yao lei <le...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/
-----------------------------------------------------------
(Updated 五月 25, 2017, 12:29 p.m.)
Review request for Ambari, Alexandr Antonenko, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
Bugs: AMBARI-21097
https://issues.apache.org/jira/browse/AMBARI-21097
Repository: ambari
Description
-------
STR:
1.Open Alerts / Actions / Manage Alert Notifications
2.Create an alert notification named test
3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
Diffs
-----
ambari-web/app/mappers/alert_notification_mapper.js 037c418
ambari-web/app/models/alerts/alert_notification.js c2d7570
Diff: https://reviews.apache.org/r/59485/diff/1/
Testing
-------
1.cd ambari-web & mvn test
30383 passing (34s)
157 pending
2.Tested in a cluster
Thanks,
yao lei
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by Alexandr Antonenko <hi...@gmail.com>.
> On May 23, 2017, 11:41 a.m., Alexandr Antonenko wrote:
> > Ship It!
>
> yao lei wrote:
> Thanks for your review
>
> yao lei wrote:
> Hi Alexandr Antonenko,
> Would you please commit this patch if you are free?
> Thanks.
in trunk this changes are already in their place, after commit Ambari-18281 Expose Disabling of Alert Targets in Web Client (Vivek Ratnavel Subramanian via zhewang)
as for 2.5 branch, 2.5.2 RC is out, so no commits to that branch (only critical blockers)
- Alexandr
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review175785
-----------------------------------------------------------
On May 23, 2017, 8:10 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 8:10 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/alert_notification_mapper.js 037c418
> ambari-web/app/models/alerts/alert_notification.js c2d7570
>
>
> Diff: https://reviews.apache.org/r/59485/diff/1/
>
>
> Testing
> -------
>
> 1.cd ambari-web & mvn test
> 30383 passing (34s)
> 157 pending
>
> 2.Tested in a cluster
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by yao lei <le...@163.com>.
> On 五月 23, 2017, 11:41 a.m., Alexandr Antonenko wrote:
> > Ship It!
>
> yao lei wrote:
> Thanks for your review
Hi Alexandr Antonenko,
Would you please commit this patch if you are free?
Thanks.
- yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review175785
-----------------------------------------------------------
On 五月 23, 2017, 8:10 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> -----------------------------------------------------------
>
> (Updated 五月 23, 2017, 8:10 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/alert_notification_mapper.js 037c418
> ambari-web/app/models/alerts/alert_notification.js c2d7570
>
>
> Diff: https://reviews.apache.org/r/59485/diff/1/
>
>
> Testing
> -------
>
> 1.cd ambari-web & mvn test
> 30383 passing (34s)
> 157 pending
>
> 2.Tested in a cluster
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by Alexandr Antonenko <hi...@gmail.com>.
> On May 23, 2017, 11:41 a.m., Alexandr Antonenko wrote:
> > Ship It!
>
> yao lei wrote:
> Thanks for your review
>
> yao lei wrote:
> Hi Alexandr Antonenko,
> Would you please commit this patch if you are free?
> Thanks.
>
> Alexandr Antonenko wrote:
> in trunk this changes are already in their place, after commit Ambari-18281 Expose Disabling of Alert Targets in Web Client (Vivek Ratnavel Subramanian via zhewang)
>
> as for 2.5 branch, 2.5.2 RC is out, so no commits to that branch (only critical blockers)
>
> yao lei wrote:
> I see.
> Thanks Alexandr.
once 2.5.2 will be out, and we will start working on 2.5.3 (so 2.5 branch will be opened for commits). Let's push it there. If your goal is to fix this for 2.5.3
- Alexandr
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review175785
-----------------------------------------------------------
On May 23, 2017, 8:10 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 8:10 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/alert_notification_mapper.js 037c418
> ambari-web/app/models/alerts/alert_notification.js c2d7570
>
>
> Diff: https://reviews.apache.org/r/59485/diff/1/
>
>
> Testing
> -------
>
> 1.cd ambari-web & mvn test
> 30383 passing (34s)
> 157 pending
>
> 2.Tested in a cluster
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by yao lei <le...@163.com>.
> On 五月 23, 2017, 11:41 a.m., Alexandr Antonenko wrote:
> > Ship It!
Thanks for your review
- yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review175785
-----------------------------------------------------------
On 五月 23, 2017, 8:10 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> -----------------------------------------------------------
>
> (Updated 五月 23, 2017, 8:10 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/alert_notification_mapper.js 037c418
> ambari-web/app/models/alerts/alert_notification.js c2d7570
>
>
> Diff: https://reviews.apache.org/r/59485/diff/1/
>
>
> Testing
> -------
>
> 1.cd ambari-web & mvn test
> 30383 passing (34s)
> 157 pending
>
> 2.Tested in a cluster
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by yao lei <le...@163.com>.
> On 五月 23, 2017, 11:41 a.m., Alexandr Antonenko wrote:
> > Ship It!
>
> yao lei wrote:
> Thanks for your review
>
> yao lei wrote:
> Hi Alexandr Antonenko,
> Would you please commit this patch if you are free?
> Thanks.
>
> Alexandr Antonenko wrote:
> in trunk this changes are already in their place, after commit Ambari-18281 Expose Disabling of Alert Targets in Web Client (Vivek Ratnavel Subramanian via zhewang)
>
> as for 2.5 branch, 2.5.2 RC is out, so no commits to that branch (only critical blockers)
>
> yao lei wrote:
> I see.
> Thanks Alexandr.
>
> Alexandr Antonenko wrote:
> once 2.5.2 will be out, and we will start working on 2.5.3 (so 2.5 branch will be opened for commits). Let's push it there. If your goal is to fix this for 2.5.3
Good. Please commit to 2.5.3
- yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review175785
-----------------------------------------------------------
On 五月 23, 2017, 8:10 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> -----------------------------------------------------------
>
> (Updated 五月 23, 2017, 8:10 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/alert_notification_mapper.js 037c418
> ambari-web/app/models/alerts/alert_notification.js c2d7570
>
>
> Diff: https://reviews.apache.org/r/59485/diff/1/
>
>
> Testing
> -------
>
> 1.cd ambari-web & mvn test
> 30383 passing (34s)
> 157 pending
>
> 2.Tested in a cluster
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by yao lei <le...@163.com>.
> On May 23, 2017, 11:41 a.m., Alexandr Antonenko wrote:
> > Ship It!
>
> yao lei wrote:
> Thanks for your review
>
> yao lei wrote:
> Hi Alexandr Antonenko,
> Would you please commit this patch if you are free?
> Thanks.
>
> Alexandr Antonenko wrote:
> in trunk this changes are already in their place, after commit Ambari-18281 Expose Disabling of Alert Targets in Web Client (Vivek Ratnavel Subramanian via zhewang)
>
> as for 2.5 branch, 2.5.2 RC is out, so no commits to that branch (only critical blockers)
I see.
Thanks Alexandr.
- yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review175785
-----------------------------------------------------------
On May 23, 2017, 8:10 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 8:10 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/alert_notification_mapper.js 037c418
> ambari-web/app/models/alerts/alert_notification.js c2d7570
>
>
> Diff: https://reviews.apache.org/r/59485/diff/1/
>
>
> Testing
> -------
>
> 1.cd ambari-web & mvn test
> 30383 passing (34s)
> 157 pending
>
> 2.Tested in a cluster
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 59485: Edit notifications options are always grey
but can click and open a popup
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review175785
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On May 23, 2017, 8:10 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 8:10 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find Edit/Duplicate items are always grey but you can click and open a popup.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/alert_notification_mapper.js 037c418
> ambari-web/app/models/alerts/alert_notification.js c2d7570
>
>
> Diff: https://reviews.apache.org/r/59485/diff/1/
>
>
> Testing
> -------
>
> 1.cd ambari-web & mvn test
> 30383 passing (34s)
> 157 pending
>
> 2.Tested in a cluster
>
>
> Thanks,
>
> yao lei
>
>