You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:47:16 UTC

[GitHub] [geode] Bill opened a new pull request #5409: GEODE-8337: Redo: Rename Version enum to KnownVersion; VersionOrdinal to Version

Bill opened a new pull request #5409:
URL: https://github.com/apache/geode/pull/5409


   PR for [GEODE-8337](https://issues.apache.org/jira/browse/GEODE-8337) had to be reverted because of some problems with validation tests. Redoing it.
   
   Original PR:
   
   - https://github.com/apache/geode/pull/5353
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill commented on pull request #5409: GEODE-8337: Redo: Rename Version enum to KnownVersion; VersionOrdinal to Version

Posted by GitBox <gi...@apache.org>.
Bill commented on pull request #5409:
URL: https://github.com/apache/geode/pull/5409#issuecomment-667208641


   sorry about the confusion @bschuchardt. Nothing to review here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill edited a comment on pull request #5409: GEODE-8337: Redo: Rename Version enum to KnownVersion; VersionOrdinal to Version

Posted by GitBox <gi...@apache.org>.
Bill edited a comment on pull request #5409:
URL: https://github.com/apache/geode/pull/5409#issuecomment-667208641


   sorry about the confusion @bschuchardt…
   
   I had to revert due to test failures in proprietary code. No changes were needed to this code, as it turns out. But it's taken me a long time to fix that proprietary code. I believe I have it fixed now.
   
   There are no unapproved changes in this PR. It's merely cherry-picking (commits for) two formerly approved PRs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] Bill merged pull request #5409: GEODE-8337: Redo: Rename Version enum to KnownVersion; VersionOrdinal to Version

Posted by GitBox <gi...@apache.org>.
Bill merged pull request #5409:
URL: https://github.com/apache/geode/pull/5409


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org