You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2018/07/27 16:00:34 UTC
Review Request 68084: HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus
Camacho Rodriguez, reviewed by Ashutosh Chauhan)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68084/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan)
Diffs
-----
druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 898f97a2d56b01acbf2fa2e0232f3fe55223dd79
jdbc-handler/pom.xml e892708a90d30f77b2800b97bed356fd4fdce08d
pom.xml bd79ede8708b6360d81ab61daa4bc40041f592c1
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java a09e7f60364e671fc2f7ce6fd609c816b1293bd6
ql/src/test/results/clientpositive/druid/druid_basic2.q.out 444d91db32d3bb81ce97632393f5bbb2775b8acb
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 610558ad49119a260ca644afdf378da89b989d03
ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 116c3266f4ff6d9b23cfb6e5887dd5893f1e254a
ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 1c9e9c671806423d0660e8574971a869702d5b0d
ql/src/test/results/clientpositive/druid/druidmini_test1.q.out f93841f11c2bad747dac6f2d33d8e9920c32fe7f
ql/src/test/results/clientpositive/druid_intervals.q.out fde446cecb87aa1ce24e56df12f4ad5f28cdbbf0
ql/src/test/results/clientpositive/druid_timeseries.q.out 455bdd542146f048f6e16ea892ab9c8065ee4bc3
ql/src/test/results/clientpositive/druid_topn.q.out 7bfd2ae93b3245d32e148733e58025897c19f65e
ql/src/test/results/clientpositive/infer_join_preds.q.out 62b977f5c7b6464dd3a40b12253ebf0da94af760
ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 46c40b4bd77e345ddef532158ab9b5292d99eaa7
ql/src/test/results/clientpositive/llap/explainuser_1.q.out f9018b42736eaa8d9a4cb244f460511e4667bfde
ql/src/test/results/clientpositive/llap/subquery_multi.q.out 89883fd0f8f5338889a079d81965f4f729f868b9
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out dc5461111b0c25541685b7b1ca789600e38ed149
ql/src/test/results/clientpositive/llap/subquery_views.q.out 05c91cdae9adcb87e1b4b9adb4871fb686f9286c
ql/src/test/results/clientpositive/llap/vectorized_case.q.out 7e5fee0422699fdf2953e2691abc79b1eda336f8
ql/src/test/results/clientpositive/pcr.q.out 1d203f739546a9a8d0a583c5229aed73fa5221aa
ql/src/test/results/clientpositive/perf/spark/query11.q.out f0e8732812fa2301a8050685b925649595511637
ql/src/test/results/clientpositive/perf/spark/query4.q.out 0993dc23c2ec5ce6b0fc7f52be0380c4e3e0f2bc
ql/src/test/results/clientpositive/perf/spark/query74.q.out c9083ac4f047c60d574eed39b26f3bb0a5b87548
ql/src/test/results/clientpositive/perf/tez/query11.q.out bf454a0e754827e829165e1397e093f96254c2d7
ql/src/test/results/clientpositive/perf/tez/query4.q.out 75d5423d47aa3a09cb762d715d9048044673d40b
ql/src/test/results/clientpositive/perf/tez/query74.q.out 738e64f799c89fcf6bc335731a6df8b86c99dbf8
ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 750969798879e84de1f74d99a65d289c60e9502c
ql/src/test/results/clientpositive/spark/pcr.q.out 11c7891d413258032f45b2396b6ef4c8f40d6041
ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out b488129cd0f35a6c908cbc6b09080081bf16d063
ql/src/test/results/clientpositive/spark/subquery_multi.q.out 80a48b7852a9ebfeb507dbb5a2153b4c26157877
ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 9105f587c00336c1c433bae85ced45633ec5472b
ql/src/test/results/clientpositive/spark/subquery_views.q.out 67711c234e2c454916a2eba3a47a8630c113c6bf
ql/src/test/results/clientpositive/spark/vectorized_case.q.out 4d322cf1545a9f27f9737a2c09d095781b135c26
ql/src/test/results/clientpositive/stat_estimate_related_col.q.out 78524d671693d1933ee24e1326d4c9d3e6f75907
ql/src/test/results/clientpositive/union_offcbo.q.out ce27bf29324a384e39daf314f84228bf3b711324
Diff: https://reviews.apache.org/r/68084/diff/1/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 68084: HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus
Camacho Rodriguez, reviewed by Ashutosh Chauhan)
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
> On July 27, 2018, 5 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
> > Line 1024 (original), 1025 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064639#file2064639line1025>
> >
> > This one goes back to same value with follow-up patch.
https://issues.apache.org/jira/browse/HIVE-18729
> On July 27, 2018, 5 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
> > Line 1318 (original), 1319 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064639#file2064639line1319>
> >
> > Goes back to same value with follow-up patch.
>
> Ashutosh Chauhan wrote:
> ok. which bug is it?
https://issues.apache.org/jira/browse/HIVE-18729
> On July 27, 2018, 5 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
> > Line 1330 (original), 1331 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064639#file2064639line1331>
> >
> > Fixed with follow-up patch (by Nishant).
>
> Ashutosh Chauhan wrote:
> cool.
https://issues.apache.org/jira/browse/HIVE-20035
- Jesús
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68084/#review206548
-----------------------------------------------------------
On July 27, 2018, 4 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68084/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 4 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-20213
> https://issues.apache.org/jira/browse/HIVE-20213
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan)
>
>
> Diffs
> -----
>
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 898f97a2d56b01acbf2fa2e0232f3fe55223dd79
> jdbc-handler/pom.xml e892708a90d30f77b2800b97bed356fd4fdce08d
> pom.xml bd79ede8708b6360d81ab61daa4bc40041f592c1
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java a09e7f60364e671fc2f7ce6fd609c816b1293bd6
> ql/src/test/results/clientpositive/druid/druid_basic2.q.out 444d91db32d3bb81ce97632393f5bbb2775b8acb
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 610558ad49119a260ca644afdf378da89b989d03
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 116c3266f4ff6d9b23cfb6e5887dd5893f1e254a
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 1c9e9c671806423d0660e8574971a869702d5b0d
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out f93841f11c2bad747dac6f2d33d8e9920c32fe7f
> ql/src/test/results/clientpositive/druid_intervals.q.out fde446cecb87aa1ce24e56df12f4ad5f28cdbbf0
> ql/src/test/results/clientpositive/druid_timeseries.q.out 455bdd542146f048f6e16ea892ab9c8065ee4bc3
> ql/src/test/results/clientpositive/druid_topn.q.out 7bfd2ae93b3245d32e148733e58025897c19f65e
> ql/src/test/results/clientpositive/infer_join_preds.q.out 62b977f5c7b6464dd3a40b12253ebf0da94af760
> ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 46c40b4bd77e345ddef532158ab9b5292d99eaa7
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out f9018b42736eaa8d9a4cb244f460511e4667bfde
> ql/src/test/results/clientpositive/llap/subquery_multi.q.out 89883fd0f8f5338889a079d81965f4f729f868b9
> ql/src/test/results/clientpositive/llap/subquery_scalar.q.out dc5461111b0c25541685b7b1ca789600e38ed149
> ql/src/test/results/clientpositive/llap/subquery_views.q.out 05c91cdae9adcb87e1b4b9adb4871fb686f9286c
> ql/src/test/results/clientpositive/llap/vectorized_case.q.out 7e5fee0422699fdf2953e2691abc79b1eda336f8
> ql/src/test/results/clientpositive/pcr.q.out 1d203f739546a9a8d0a583c5229aed73fa5221aa
> ql/src/test/results/clientpositive/perf/spark/query11.q.out f0e8732812fa2301a8050685b925649595511637
> ql/src/test/results/clientpositive/perf/spark/query4.q.out 0993dc23c2ec5ce6b0fc7f52be0380c4e3e0f2bc
> ql/src/test/results/clientpositive/perf/spark/query74.q.out c9083ac4f047c60d574eed39b26f3bb0a5b87548
> ql/src/test/results/clientpositive/perf/tez/query11.q.out bf454a0e754827e829165e1397e093f96254c2d7
> ql/src/test/results/clientpositive/perf/tez/query4.q.out 75d5423d47aa3a09cb762d715d9048044673d40b
> ql/src/test/results/clientpositive/perf/tez/query74.q.out 738e64f799c89fcf6bc335731a6df8b86c99dbf8
> ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 750969798879e84de1f74d99a65d289c60e9502c
> ql/src/test/results/clientpositive/spark/pcr.q.out 11c7891d413258032f45b2396b6ef4c8f40d6041
> ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out b488129cd0f35a6c908cbc6b09080081bf16d063
> ql/src/test/results/clientpositive/spark/subquery_multi.q.out 80a48b7852a9ebfeb507dbb5a2153b4c26157877
> ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 9105f587c00336c1c433bae85ced45633ec5472b
> ql/src/test/results/clientpositive/spark/subquery_views.q.out 67711c234e2c454916a2eba3a47a8630c113c6bf
> ql/src/test/results/clientpositive/spark/vectorized_case.q.out 4d322cf1545a9f27f9737a2c09d095781b135c26
> ql/src/test/results/clientpositive/stat_estimate_related_col.q.out 78524d671693d1933ee24e1326d4c9d3e6f75907
> ql/src/test/results/clientpositive/union_offcbo.q.out ce27bf29324a384e39daf314f84228bf3b711324
>
>
> Diff: https://reviews.apache.org/r/68084/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 68084: HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus
Camacho Rodriguez, reviewed by Ashutosh Chauhan)
Posted by Ashutosh Chauhan <ha...@apache.org>.
> On July 27, 2018, 5 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
> > Line 1318 (original), 1319 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064639#file2064639line1319>
> >
> > Goes back to same value with follow-up patch.
ok. which bug is it?
> On July 27, 2018, 5 p.m., Jesús Camacho Rodríguez wrote:
> > ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
> > Line 1330 (original), 1331 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064639#file2064639line1331>
> >
> > Fixed with follow-up patch (by Nishant).
cool.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68084/#review206548
-----------------------------------------------------------
On July 27, 2018, 4 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68084/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 4 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-20213
> https://issues.apache.org/jira/browse/HIVE-20213
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan)
>
>
> Diffs
> -----
>
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 898f97a2d56b01acbf2fa2e0232f3fe55223dd79
> jdbc-handler/pom.xml e892708a90d30f77b2800b97bed356fd4fdce08d
> pom.xml bd79ede8708b6360d81ab61daa4bc40041f592c1
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java a09e7f60364e671fc2f7ce6fd609c816b1293bd6
> ql/src/test/results/clientpositive/druid/druid_basic2.q.out 444d91db32d3bb81ce97632393f5bbb2775b8acb
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 610558ad49119a260ca644afdf378da89b989d03
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 116c3266f4ff6d9b23cfb6e5887dd5893f1e254a
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 1c9e9c671806423d0660e8574971a869702d5b0d
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out f93841f11c2bad747dac6f2d33d8e9920c32fe7f
> ql/src/test/results/clientpositive/druid_intervals.q.out fde446cecb87aa1ce24e56df12f4ad5f28cdbbf0
> ql/src/test/results/clientpositive/druid_timeseries.q.out 455bdd542146f048f6e16ea892ab9c8065ee4bc3
> ql/src/test/results/clientpositive/druid_topn.q.out 7bfd2ae93b3245d32e148733e58025897c19f65e
> ql/src/test/results/clientpositive/infer_join_preds.q.out 62b977f5c7b6464dd3a40b12253ebf0da94af760
> ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 46c40b4bd77e345ddef532158ab9b5292d99eaa7
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out f9018b42736eaa8d9a4cb244f460511e4667bfde
> ql/src/test/results/clientpositive/llap/subquery_multi.q.out 89883fd0f8f5338889a079d81965f4f729f868b9
> ql/src/test/results/clientpositive/llap/subquery_scalar.q.out dc5461111b0c25541685b7b1ca789600e38ed149
> ql/src/test/results/clientpositive/llap/subquery_views.q.out 05c91cdae9adcb87e1b4b9adb4871fb686f9286c
> ql/src/test/results/clientpositive/llap/vectorized_case.q.out 7e5fee0422699fdf2953e2691abc79b1eda336f8
> ql/src/test/results/clientpositive/pcr.q.out 1d203f739546a9a8d0a583c5229aed73fa5221aa
> ql/src/test/results/clientpositive/perf/spark/query11.q.out f0e8732812fa2301a8050685b925649595511637
> ql/src/test/results/clientpositive/perf/spark/query4.q.out 0993dc23c2ec5ce6b0fc7f52be0380c4e3e0f2bc
> ql/src/test/results/clientpositive/perf/spark/query74.q.out c9083ac4f047c60d574eed39b26f3bb0a5b87548
> ql/src/test/results/clientpositive/perf/tez/query11.q.out bf454a0e754827e829165e1397e093f96254c2d7
> ql/src/test/results/clientpositive/perf/tez/query4.q.out 75d5423d47aa3a09cb762d715d9048044673d40b
> ql/src/test/results/clientpositive/perf/tez/query74.q.out 738e64f799c89fcf6bc335731a6df8b86c99dbf8
> ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 750969798879e84de1f74d99a65d289c60e9502c
> ql/src/test/results/clientpositive/spark/pcr.q.out 11c7891d413258032f45b2396b6ef4c8f40d6041
> ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out b488129cd0f35a6c908cbc6b09080081bf16d063
> ql/src/test/results/clientpositive/spark/subquery_multi.q.out 80a48b7852a9ebfeb507dbb5a2153b4c26157877
> ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 9105f587c00336c1c433bae85ced45633ec5472b
> ql/src/test/results/clientpositive/spark/subquery_views.q.out 67711c234e2c454916a2eba3a47a8630c113c6bf
> ql/src/test/results/clientpositive/spark/vectorized_case.q.out 4d322cf1545a9f27f9737a2c09d095781b135c26
> ql/src/test/results/clientpositive/stat_estimate_related_col.q.out 78524d671693d1933ee24e1326d4c9d3e6f75907
> ql/src/test/results/clientpositive/union_offcbo.q.out ce27bf29324a384e39daf314f84228bf3b711324
>
>
> Diff: https://reviews.apache.org/r/68084/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 68084: HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus
Camacho Rodriguez, reviewed by Ashutosh Chauhan)
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68084/#review206548
-----------------------------------------------------------
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
Line 1024 (original), 1025 (patched)
<https://reviews.apache.org/r/68084/#comment289509>
This one goes back to same value with follow-up patch.
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
Line 1318 (original), 1319 (patched)
<https://reviews.apache.org/r/68084/#comment289510>
Goes back to same value with follow-up patch.
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
Line 1330 (original), 1331 (patched)
<https://reviews.apache.org/r/68084/#comment289511>
Fixed with follow-up patch (by Nishant).
ql/src/test/results/clientpositive/llap/vectorized_case.q.out
Line 1254 (original), 1254 (patched)
<https://reviews.apache.org/r/68084/#comment289512>
Correct now.
- Jesús Camacho Rodríguez
On July 27, 2018, 4 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68084/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 4 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-20213
> https://issues.apache.org/jira/browse/HIVE-20213
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan)
>
>
> Diffs
> -----
>
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 898f97a2d56b01acbf2fa2e0232f3fe55223dd79
> jdbc-handler/pom.xml e892708a90d30f77b2800b97bed356fd4fdce08d
> pom.xml bd79ede8708b6360d81ab61daa4bc40041f592c1
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java a09e7f60364e671fc2f7ce6fd609c816b1293bd6
> ql/src/test/results/clientpositive/druid/druid_basic2.q.out 444d91db32d3bb81ce97632393f5bbb2775b8acb
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 610558ad49119a260ca644afdf378da89b989d03
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 116c3266f4ff6d9b23cfb6e5887dd5893f1e254a
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 1c9e9c671806423d0660e8574971a869702d5b0d
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out f93841f11c2bad747dac6f2d33d8e9920c32fe7f
> ql/src/test/results/clientpositive/druid_intervals.q.out fde446cecb87aa1ce24e56df12f4ad5f28cdbbf0
> ql/src/test/results/clientpositive/druid_timeseries.q.out 455bdd542146f048f6e16ea892ab9c8065ee4bc3
> ql/src/test/results/clientpositive/druid_topn.q.out 7bfd2ae93b3245d32e148733e58025897c19f65e
> ql/src/test/results/clientpositive/infer_join_preds.q.out 62b977f5c7b6464dd3a40b12253ebf0da94af760
> ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 46c40b4bd77e345ddef532158ab9b5292d99eaa7
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out f9018b42736eaa8d9a4cb244f460511e4667bfde
> ql/src/test/results/clientpositive/llap/subquery_multi.q.out 89883fd0f8f5338889a079d81965f4f729f868b9
> ql/src/test/results/clientpositive/llap/subquery_scalar.q.out dc5461111b0c25541685b7b1ca789600e38ed149
> ql/src/test/results/clientpositive/llap/subquery_views.q.out 05c91cdae9adcb87e1b4b9adb4871fb686f9286c
> ql/src/test/results/clientpositive/llap/vectorized_case.q.out 7e5fee0422699fdf2953e2691abc79b1eda336f8
> ql/src/test/results/clientpositive/pcr.q.out 1d203f739546a9a8d0a583c5229aed73fa5221aa
> ql/src/test/results/clientpositive/perf/spark/query11.q.out f0e8732812fa2301a8050685b925649595511637
> ql/src/test/results/clientpositive/perf/spark/query4.q.out 0993dc23c2ec5ce6b0fc7f52be0380c4e3e0f2bc
> ql/src/test/results/clientpositive/perf/spark/query74.q.out c9083ac4f047c60d574eed39b26f3bb0a5b87548
> ql/src/test/results/clientpositive/perf/tez/query11.q.out bf454a0e754827e829165e1397e093f96254c2d7
> ql/src/test/results/clientpositive/perf/tez/query4.q.out 75d5423d47aa3a09cb762d715d9048044673d40b
> ql/src/test/results/clientpositive/perf/tez/query74.q.out 738e64f799c89fcf6bc335731a6df8b86c99dbf8
> ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 750969798879e84de1f74d99a65d289c60e9502c
> ql/src/test/results/clientpositive/spark/pcr.q.out 11c7891d413258032f45b2396b6ef4c8f40d6041
> ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out b488129cd0f35a6c908cbc6b09080081bf16d063
> ql/src/test/results/clientpositive/spark/subquery_multi.q.out 80a48b7852a9ebfeb507dbb5a2153b4c26157877
> ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 9105f587c00336c1c433bae85ced45633ec5472b
> ql/src/test/results/clientpositive/spark/subquery_views.q.out 67711c234e2c454916a2eba3a47a8630c113c6bf
> ql/src/test/results/clientpositive/spark/vectorized_case.q.out 4d322cf1545a9f27f9737a2c09d095781b135c26
> ql/src/test/results/clientpositive/stat_estimate_related_col.q.out 78524d671693d1933ee24e1326d4c9d3e6f75907
> ql/src/test/results/clientpositive/union_offcbo.q.out ce27bf29324a384e39daf314f84228bf3b711324
>
>
> Diff: https://reviews.apache.org/r/68084/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 68084: HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus
Camacho Rodriguez, reviewed by Ashutosh Chauhan)
Posted by Ashutosh Chauhan <ha...@apache.org>.
> On July 28, 2018, 1:53 a.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
> > Lines 1023-1024 (original), 1024-1025 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064639#file2064639line1024>
> >
> > wrong results earlier or now?
ok..cool
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68084/#review206568
-----------------------------------------------------------
On July 27, 2018, 4 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68084/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 4 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-20213
> https://issues.apache.org/jira/browse/HIVE-20213
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan)
>
>
> Diffs
> -----
>
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 898f97a2d56b01acbf2fa2e0232f3fe55223dd79
> jdbc-handler/pom.xml e892708a90d30f77b2800b97bed356fd4fdce08d
> pom.xml bd79ede8708b6360d81ab61daa4bc40041f592c1
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java a09e7f60364e671fc2f7ce6fd609c816b1293bd6
> ql/src/test/results/clientpositive/druid/druid_basic2.q.out 444d91db32d3bb81ce97632393f5bbb2775b8acb
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 610558ad49119a260ca644afdf378da89b989d03
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 116c3266f4ff6d9b23cfb6e5887dd5893f1e254a
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 1c9e9c671806423d0660e8574971a869702d5b0d
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out f93841f11c2bad747dac6f2d33d8e9920c32fe7f
> ql/src/test/results/clientpositive/druid_intervals.q.out fde446cecb87aa1ce24e56df12f4ad5f28cdbbf0
> ql/src/test/results/clientpositive/druid_timeseries.q.out 455bdd542146f048f6e16ea892ab9c8065ee4bc3
> ql/src/test/results/clientpositive/druid_topn.q.out 7bfd2ae93b3245d32e148733e58025897c19f65e
> ql/src/test/results/clientpositive/infer_join_preds.q.out 62b977f5c7b6464dd3a40b12253ebf0da94af760
> ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 46c40b4bd77e345ddef532158ab9b5292d99eaa7
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out f9018b42736eaa8d9a4cb244f460511e4667bfde
> ql/src/test/results/clientpositive/llap/subquery_multi.q.out 89883fd0f8f5338889a079d81965f4f729f868b9
> ql/src/test/results/clientpositive/llap/subquery_scalar.q.out dc5461111b0c25541685b7b1ca789600e38ed149
> ql/src/test/results/clientpositive/llap/subquery_views.q.out 05c91cdae9adcb87e1b4b9adb4871fb686f9286c
> ql/src/test/results/clientpositive/llap/vectorized_case.q.out 7e5fee0422699fdf2953e2691abc79b1eda336f8
> ql/src/test/results/clientpositive/pcr.q.out 1d203f739546a9a8d0a583c5229aed73fa5221aa
> ql/src/test/results/clientpositive/perf/spark/query11.q.out f0e8732812fa2301a8050685b925649595511637
> ql/src/test/results/clientpositive/perf/spark/query4.q.out 0993dc23c2ec5ce6b0fc7f52be0380c4e3e0f2bc
> ql/src/test/results/clientpositive/perf/spark/query74.q.out c9083ac4f047c60d574eed39b26f3bb0a5b87548
> ql/src/test/results/clientpositive/perf/tez/query11.q.out bf454a0e754827e829165e1397e093f96254c2d7
> ql/src/test/results/clientpositive/perf/tez/query4.q.out 75d5423d47aa3a09cb762d715d9048044673d40b
> ql/src/test/results/clientpositive/perf/tez/query74.q.out 738e64f799c89fcf6bc335731a6df8b86c99dbf8
> ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 750969798879e84de1f74d99a65d289c60e9502c
> ql/src/test/results/clientpositive/spark/pcr.q.out 11c7891d413258032f45b2396b6ef4c8f40d6041
> ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out b488129cd0f35a6c908cbc6b09080081bf16d063
> ql/src/test/results/clientpositive/spark/subquery_multi.q.out 80a48b7852a9ebfeb507dbb5a2153b4c26157877
> ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 9105f587c00336c1c433bae85ced45633ec5472b
> ql/src/test/results/clientpositive/spark/subquery_views.q.out 67711c234e2c454916a2eba3a47a8630c113c6bf
> ql/src/test/results/clientpositive/spark/vectorized_case.q.out 4d322cf1545a9f27f9737a2c09d095781b135c26
> ql/src/test/results/clientpositive/stat_estimate_related_col.q.out 78524d671693d1933ee24e1326d4c9d3e6f75907
> ql/src/test/results/clientpositive/union_offcbo.q.out ce27bf29324a384e39daf314f84228bf3b711324
>
>
> Diff: https://reviews.apache.org/r/68084/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 68084: HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus
Camacho Rodriguez, reviewed by Ashutosh Chauhan)
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
> On July 28, 2018, 1:53 a.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
> > Lines 126 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064639#file2064639line126>
> >
> > we had wrong results earlier?
It seems like that, the query does not have a GBy clause hence we should emit one result row.
> On July 28, 2018, 1:53 a.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
> > Lines 1023-1024 (original), 1024-1025 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064639#file2064639line1024>
> >
> > wrong results earlier or now?
>
> Ashutosh Chauhan wrote:
> ok..cool
https://issues.apache.org/jira/browse/HIVE-18729
> On July 28, 2018, 1:53 a.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
> > Line 1330 (original), 1331 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064639#file2064639line1331>
> >
> > correct results now?
This is also fixed by Nishant's patch to handle booleans properly.
https://issues.apache.org/jira/browse/HIVE-20035
> On July 28, 2018, 1:53 a.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/druid_timeseries.q.out
> > Line 86 (original), 86 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064644#file2064644line86>
> >
> > Is this change skipEmptyBuckets":true expected?
Yes, this has to do with https://issues.apache.org/jira/browse/CALCITE-2262 .
> On July 28, 2018, 1:53 a.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/explainuser_1.q.out
> > Line 503 (original), 503 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064648#file2064648line503>
> >
> > we have weaker predicate now?
This is similar to the one below. Observe that there is a conjunct _c_float > 0_ hence we infer that the condition will true if _c_float is not null_. As in example below, we could fold even further and remove _(c_int > 0) or (c_float >= 0)_.
> On July 28, 2018, 1:53 a.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/pcr.q.out
> > Line 1886 (original), 1886 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064653#file2064653line1886>
> >
> > Is this correct?
Yes, it is. Observe that filter predicate range is (-inf, +inf) hence predicate is true for all values except null.
However, it would be even better to rewrite into _ds IS NOT NULL_.
- Jesús
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68084/#review206568
-----------------------------------------------------------
On July 27, 2018, 4 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68084/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 4 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-20213
> https://issues.apache.org/jira/browse/HIVE-20213
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan)
>
>
> Diffs
> -----
>
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 898f97a2d56b01acbf2fa2e0232f3fe55223dd79
> jdbc-handler/pom.xml e892708a90d30f77b2800b97bed356fd4fdce08d
> pom.xml bd79ede8708b6360d81ab61daa4bc40041f592c1
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java a09e7f60364e671fc2f7ce6fd609c816b1293bd6
> ql/src/test/results/clientpositive/druid/druid_basic2.q.out 444d91db32d3bb81ce97632393f5bbb2775b8acb
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 610558ad49119a260ca644afdf378da89b989d03
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 116c3266f4ff6d9b23cfb6e5887dd5893f1e254a
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 1c9e9c671806423d0660e8574971a869702d5b0d
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out f93841f11c2bad747dac6f2d33d8e9920c32fe7f
> ql/src/test/results/clientpositive/druid_intervals.q.out fde446cecb87aa1ce24e56df12f4ad5f28cdbbf0
> ql/src/test/results/clientpositive/druid_timeseries.q.out 455bdd542146f048f6e16ea892ab9c8065ee4bc3
> ql/src/test/results/clientpositive/druid_topn.q.out 7bfd2ae93b3245d32e148733e58025897c19f65e
> ql/src/test/results/clientpositive/infer_join_preds.q.out 62b977f5c7b6464dd3a40b12253ebf0da94af760
> ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 46c40b4bd77e345ddef532158ab9b5292d99eaa7
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out f9018b42736eaa8d9a4cb244f460511e4667bfde
> ql/src/test/results/clientpositive/llap/subquery_multi.q.out 89883fd0f8f5338889a079d81965f4f729f868b9
> ql/src/test/results/clientpositive/llap/subquery_scalar.q.out dc5461111b0c25541685b7b1ca789600e38ed149
> ql/src/test/results/clientpositive/llap/subquery_views.q.out 05c91cdae9adcb87e1b4b9adb4871fb686f9286c
> ql/src/test/results/clientpositive/llap/vectorized_case.q.out 7e5fee0422699fdf2953e2691abc79b1eda336f8
> ql/src/test/results/clientpositive/pcr.q.out 1d203f739546a9a8d0a583c5229aed73fa5221aa
> ql/src/test/results/clientpositive/perf/spark/query11.q.out f0e8732812fa2301a8050685b925649595511637
> ql/src/test/results/clientpositive/perf/spark/query4.q.out 0993dc23c2ec5ce6b0fc7f52be0380c4e3e0f2bc
> ql/src/test/results/clientpositive/perf/spark/query74.q.out c9083ac4f047c60d574eed39b26f3bb0a5b87548
> ql/src/test/results/clientpositive/perf/tez/query11.q.out bf454a0e754827e829165e1397e093f96254c2d7
> ql/src/test/results/clientpositive/perf/tez/query4.q.out 75d5423d47aa3a09cb762d715d9048044673d40b
> ql/src/test/results/clientpositive/perf/tez/query74.q.out 738e64f799c89fcf6bc335731a6df8b86c99dbf8
> ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 750969798879e84de1f74d99a65d289c60e9502c
> ql/src/test/results/clientpositive/spark/pcr.q.out 11c7891d413258032f45b2396b6ef4c8f40d6041
> ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out b488129cd0f35a6c908cbc6b09080081bf16d063
> ql/src/test/results/clientpositive/spark/subquery_multi.q.out 80a48b7852a9ebfeb507dbb5a2153b4c26157877
> ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 9105f587c00336c1c433bae85ced45633ec5472b
> ql/src/test/results/clientpositive/spark/subquery_views.q.out 67711c234e2c454916a2eba3a47a8630c113c6bf
> ql/src/test/results/clientpositive/spark/vectorized_case.q.out 4d322cf1545a9f27f9737a2c09d095781b135c26
> ql/src/test/results/clientpositive/stat_estimate_related_col.q.out 78524d671693d1933ee24e1326d4c9d3e6f75907
> ql/src/test/results/clientpositive/union_offcbo.q.out ce27bf29324a384e39daf314f84228bf3b711324
>
>
> Diff: https://reviews.apache.org/r/68084/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 68084: HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus
Camacho Rodriguez, reviewed by Ashutosh Chauhan)
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
> On July 28, 2018, 1:53 a.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
> > Lines 1023-1024 (original), 1024-1025 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064639#file2064639line1024>
> >
> > wrong results earlier or now?
>
> Ashutosh Chauhan wrote:
> ok..cool
>
> Jesús Camacho Rodríguez wrote:
> https://issues.apache.org/jira/browse/HIVE-18729
Correct results earlier, changed again by the JIRA above.
- Jesús
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68084/#review206568
-----------------------------------------------------------
On July 27, 2018, 4 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68084/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 4 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-20213
> https://issues.apache.org/jira/browse/HIVE-20213
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan)
>
>
> Diffs
> -----
>
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 898f97a2d56b01acbf2fa2e0232f3fe55223dd79
> jdbc-handler/pom.xml e892708a90d30f77b2800b97bed356fd4fdce08d
> pom.xml bd79ede8708b6360d81ab61daa4bc40041f592c1
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java a09e7f60364e671fc2f7ce6fd609c816b1293bd6
> ql/src/test/results/clientpositive/druid/druid_basic2.q.out 444d91db32d3bb81ce97632393f5bbb2775b8acb
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 610558ad49119a260ca644afdf378da89b989d03
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 116c3266f4ff6d9b23cfb6e5887dd5893f1e254a
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 1c9e9c671806423d0660e8574971a869702d5b0d
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out f93841f11c2bad747dac6f2d33d8e9920c32fe7f
> ql/src/test/results/clientpositive/druid_intervals.q.out fde446cecb87aa1ce24e56df12f4ad5f28cdbbf0
> ql/src/test/results/clientpositive/druid_timeseries.q.out 455bdd542146f048f6e16ea892ab9c8065ee4bc3
> ql/src/test/results/clientpositive/druid_topn.q.out 7bfd2ae93b3245d32e148733e58025897c19f65e
> ql/src/test/results/clientpositive/infer_join_preds.q.out 62b977f5c7b6464dd3a40b12253ebf0da94af760
> ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 46c40b4bd77e345ddef532158ab9b5292d99eaa7
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out f9018b42736eaa8d9a4cb244f460511e4667bfde
> ql/src/test/results/clientpositive/llap/subquery_multi.q.out 89883fd0f8f5338889a079d81965f4f729f868b9
> ql/src/test/results/clientpositive/llap/subquery_scalar.q.out dc5461111b0c25541685b7b1ca789600e38ed149
> ql/src/test/results/clientpositive/llap/subquery_views.q.out 05c91cdae9adcb87e1b4b9adb4871fb686f9286c
> ql/src/test/results/clientpositive/llap/vectorized_case.q.out 7e5fee0422699fdf2953e2691abc79b1eda336f8
> ql/src/test/results/clientpositive/pcr.q.out 1d203f739546a9a8d0a583c5229aed73fa5221aa
> ql/src/test/results/clientpositive/perf/spark/query11.q.out f0e8732812fa2301a8050685b925649595511637
> ql/src/test/results/clientpositive/perf/spark/query4.q.out 0993dc23c2ec5ce6b0fc7f52be0380c4e3e0f2bc
> ql/src/test/results/clientpositive/perf/spark/query74.q.out c9083ac4f047c60d574eed39b26f3bb0a5b87548
> ql/src/test/results/clientpositive/perf/tez/query11.q.out bf454a0e754827e829165e1397e093f96254c2d7
> ql/src/test/results/clientpositive/perf/tez/query4.q.out 75d5423d47aa3a09cb762d715d9048044673d40b
> ql/src/test/results/clientpositive/perf/tez/query74.q.out 738e64f799c89fcf6bc335731a6df8b86c99dbf8
> ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 750969798879e84de1f74d99a65d289c60e9502c
> ql/src/test/results/clientpositive/spark/pcr.q.out 11c7891d413258032f45b2396b6ef4c8f40d6041
> ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out b488129cd0f35a6c908cbc6b09080081bf16d063
> ql/src/test/results/clientpositive/spark/subquery_multi.q.out 80a48b7852a9ebfeb507dbb5a2153b4c26157877
> ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 9105f587c00336c1c433bae85ced45633ec5472b
> ql/src/test/results/clientpositive/spark/subquery_views.q.out 67711c234e2c454916a2eba3a47a8630c113c6bf
> ql/src/test/results/clientpositive/spark/vectorized_case.q.out 4d322cf1545a9f27f9737a2c09d095781b135c26
> ql/src/test/results/clientpositive/stat_estimate_related_col.q.out 78524d671693d1933ee24e1326d4c9d3e6f75907
> ql/src/test/results/clientpositive/union_offcbo.q.out ce27bf29324a384e39daf314f84228bf3b711324
>
>
> Diff: https://reviews.apache.org/r/68084/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 68084: HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus
Camacho Rodriguez, reviewed by Ashutosh Chauhan)
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
> On July 28, 2018, 1:53 a.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/union_offcbo.q.out
> > Line 635 (original), 635 (patched)
> > <https://reviews.apache.org/r/68084/diff/1/?file=2064668#file2064668line635>
> >
> > is this because _col7 is a join key?
Correct, the right key in this case (for the left, we cannot simplify).
- Jesús
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68084/#review206568
-----------------------------------------------------------
On July 27, 2018, 4 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68084/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 4 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-20213
> https://issues.apache.org/jira/browse/HIVE-20213
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan)
>
>
> Diffs
> -----
>
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 898f97a2d56b01acbf2fa2e0232f3fe55223dd79
> jdbc-handler/pom.xml e892708a90d30f77b2800b97bed356fd4fdce08d
> pom.xml bd79ede8708b6360d81ab61daa4bc40041f592c1
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java a09e7f60364e671fc2f7ce6fd609c816b1293bd6
> ql/src/test/results/clientpositive/druid/druid_basic2.q.out 444d91db32d3bb81ce97632393f5bbb2775b8acb
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 610558ad49119a260ca644afdf378da89b989d03
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 116c3266f4ff6d9b23cfb6e5887dd5893f1e254a
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 1c9e9c671806423d0660e8574971a869702d5b0d
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out f93841f11c2bad747dac6f2d33d8e9920c32fe7f
> ql/src/test/results/clientpositive/druid_intervals.q.out fde446cecb87aa1ce24e56df12f4ad5f28cdbbf0
> ql/src/test/results/clientpositive/druid_timeseries.q.out 455bdd542146f048f6e16ea892ab9c8065ee4bc3
> ql/src/test/results/clientpositive/druid_topn.q.out 7bfd2ae93b3245d32e148733e58025897c19f65e
> ql/src/test/results/clientpositive/infer_join_preds.q.out 62b977f5c7b6464dd3a40b12253ebf0da94af760
> ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 46c40b4bd77e345ddef532158ab9b5292d99eaa7
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out f9018b42736eaa8d9a4cb244f460511e4667bfde
> ql/src/test/results/clientpositive/llap/subquery_multi.q.out 89883fd0f8f5338889a079d81965f4f729f868b9
> ql/src/test/results/clientpositive/llap/subquery_scalar.q.out dc5461111b0c25541685b7b1ca789600e38ed149
> ql/src/test/results/clientpositive/llap/subquery_views.q.out 05c91cdae9adcb87e1b4b9adb4871fb686f9286c
> ql/src/test/results/clientpositive/llap/vectorized_case.q.out 7e5fee0422699fdf2953e2691abc79b1eda336f8
> ql/src/test/results/clientpositive/pcr.q.out 1d203f739546a9a8d0a583c5229aed73fa5221aa
> ql/src/test/results/clientpositive/perf/spark/query11.q.out f0e8732812fa2301a8050685b925649595511637
> ql/src/test/results/clientpositive/perf/spark/query4.q.out 0993dc23c2ec5ce6b0fc7f52be0380c4e3e0f2bc
> ql/src/test/results/clientpositive/perf/spark/query74.q.out c9083ac4f047c60d574eed39b26f3bb0a5b87548
> ql/src/test/results/clientpositive/perf/tez/query11.q.out bf454a0e754827e829165e1397e093f96254c2d7
> ql/src/test/results/clientpositive/perf/tez/query4.q.out 75d5423d47aa3a09cb762d715d9048044673d40b
> ql/src/test/results/clientpositive/perf/tez/query74.q.out 738e64f799c89fcf6bc335731a6df8b86c99dbf8
> ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 750969798879e84de1f74d99a65d289c60e9502c
> ql/src/test/results/clientpositive/spark/pcr.q.out 11c7891d413258032f45b2396b6ef4c8f40d6041
> ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out b488129cd0f35a6c908cbc6b09080081bf16d063
> ql/src/test/results/clientpositive/spark/subquery_multi.q.out 80a48b7852a9ebfeb507dbb5a2153b4c26157877
> ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 9105f587c00336c1c433bae85ced45633ec5472b
> ql/src/test/results/clientpositive/spark/subquery_views.q.out 67711c234e2c454916a2eba3a47a8630c113c6bf
> ql/src/test/results/clientpositive/spark/vectorized_case.q.out 4d322cf1545a9f27f9737a2c09d095781b135c26
> ql/src/test/results/clientpositive/stat_estimate_related_col.q.out 78524d671693d1933ee24e1326d4c9d3e6f75907
> ql/src/test/results/clientpositive/union_offcbo.q.out ce27bf29324a384e39daf314f84228bf3b711324
>
>
> Diff: https://reviews.apache.org/r/68084/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 68084: HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus
Camacho Rodriguez, reviewed by Ashutosh Chauhan)
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68084/#review206568
-----------------------------------------------------------
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
Lines 126 (patched)
<https://reviews.apache.org/r/68084/#comment289541>
we had wrong results earlier?
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
Lines 1023-1024 (original), 1024-1025 (patched)
<https://reviews.apache.org/r/68084/#comment289542>
wrong results earlier or now?
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out
Line 1330 (original), 1331 (patched)
<https://reviews.apache.org/r/68084/#comment289543>
correct results now?
ql/src/test/results/clientpositive/druid_timeseries.q.out
Line 86 (original), 86 (patched)
<https://reviews.apache.org/r/68084/#comment289538>
Is this change skipEmptyBuckets":true expected?
ql/src/test/results/clientpositive/llap/explainuser_1.q.out
Line 503 (original), 503 (patched)
<https://reviews.apache.org/r/68084/#comment289544>
we have weaker predicate now?
ql/src/test/results/clientpositive/pcr.q.out
Line 1886 (original), 1886 (patched)
<https://reviews.apache.org/r/68084/#comment289539>
Is this correct?
ql/src/test/results/clientpositive/union_offcbo.q.out
Line 635 (original), 635 (patched)
<https://reviews.apache.org/r/68084/#comment289540>
is this because _col7 is a join key?
- Ashutosh Chauhan
On July 27, 2018, 4 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68084/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 4 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-20213
> https://issues.apache.org/jira/browse/HIVE-20213
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan)
>
>
> Diffs
> -----
>
> druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 898f97a2d56b01acbf2fa2e0232f3fe55223dd79
> jdbc-handler/pom.xml e892708a90d30f77b2800b97bed356fd4fdce08d
> pom.xml bd79ede8708b6360d81ab61daa4bc40041f592c1
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java a09e7f60364e671fc2f7ce6fd609c816b1293bd6
> ql/src/test/results/clientpositive/druid/druid_basic2.q.out 444d91db32d3bb81ce97632393f5bbb2775b8acb
> ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 610558ad49119a260ca644afdf378da89b989d03
> ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 116c3266f4ff6d9b23cfb6e5887dd5893f1e254a
> ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 1c9e9c671806423d0660e8574971a869702d5b0d
> ql/src/test/results/clientpositive/druid/druidmini_test1.q.out f93841f11c2bad747dac6f2d33d8e9920c32fe7f
> ql/src/test/results/clientpositive/druid_intervals.q.out fde446cecb87aa1ce24e56df12f4ad5f28cdbbf0
> ql/src/test/results/clientpositive/druid_timeseries.q.out 455bdd542146f048f6e16ea892ab9c8065ee4bc3
> ql/src/test/results/clientpositive/druid_topn.q.out 7bfd2ae93b3245d32e148733e58025897c19f65e
> ql/src/test/results/clientpositive/infer_join_preds.q.out 62b977f5c7b6464dd3a40b12253ebf0da94af760
> ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 46c40b4bd77e345ddef532158ab9b5292d99eaa7
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out f9018b42736eaa8d9a4cb244f460511e4667bfde
> ql/src/test/results/clientpositive/llap/subquery_multi.q.out 89883fd0f8f5338889a079d81965f4f729f868b9
> ql/src/test/results/clientpositive/llap/subquery_scalar.q.out dc5461111b0c25541685b7b1ca789600e38ed149
> ql/src/test/results/clientpositive/llap/subquery_views.q.out 05c91cdae9adcb87e1b4b9adb4871fb686f9286c
> ql/src/test/results/clientpositive/llap/vectorized_case.q.out 7e5fee0422699fdf2953e2691abc79b1eda336f8
> ql/src/test/results/clientpositive/pcr.q.out 1d203f739546a9a8d0a583c5229aed73fa5221aa
> ql/src/test/results/clientpositive/perf/spark/query11.q.out f0e8732812fa2301a8050685b925649595511637
> ql/src/test/results/clientpositive/perf/spark/query4.q.out 0993dc23c2ec5ce6b0fc7f52be0380c4e3e0f2bc
> ql/src/test/results/clientpositive/perf/spark/query74.q.out c9083ac4f047c60d574eed39b26f3bb0a5b87548
> ql/src/test/results/clientpositive/perf/tez/query11.q.out bf454a0e754827e829165e1397e093f96254c2d7
> ql/src/test/results/clientpositive/perf/tez/query4.q.out 75d5423d47aa3a09cb762d715d9048044673d40b
> ql/src/test/results/clientpositive/perf/tez/query74.q.out 738e64f799c89fcf6bc335731a6df8b86c99dbf8
> ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 750969798879e84de1f74d99a65d289c60e9502c
> ql/src/test/results/clientpositive/spark/pcr.q.out 11c7891d413258032f45b2396b6ef4c8f40d6041
> ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out b488129cd0f35a6c908cbc6b09080081bf16d063
> ql/src/test/results/clientpositive/spark/subquery_multi.q.out 80a48b7852a9ebfeb507dbb5a2153b4c26157877
> ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 9105f587c00336c1c433bae85ced45633ec5472b
> ql/src/test/results/clientpositive/spark/subquery_views.q.out 67711c234e2c454916a2eba3a47a8630c113c6bf
> ql/src/test/results/clientpositive/spark/vectorized_case.q.out 4d322cf1545a9f27f9737a2c09d095781b135c26
> ql/src/test/results/clientpositive/stat_estimate_related_col.q.out 78524d671693d1933ee24e1326d4c9d3e6f75907
> ql/src/test/results/clientpositive/union_offcbo.q.out ce27bf29324a384e39daf314f84228bf3b711324
>
>
> Diff: https://reviews.apache.org/r/68084/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 68084: HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus
Camacho Rodriguez, reviewed by Ashutosh Chauhan)
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68084/
-----------------------------------------------------------
(Updated July 27, 2018, 4 p.m.)
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-20213
https://issues.apache.org/jira/browse/HIVE-20213
Repository: hive-git
Description
-------
HIVE-20213: Upgrade Calcite to 1.17.0 (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan)
Diffs
-----
druid-handler/src/test/org/apache/hadoop/hive/druid/TestHiveDruidQueryBasedInputFormat.java 898f97a2d56b01acbf2fa2e0232f3fe55223dd79
jdbc-handler/pom.xml e892708a90d30f77b2800b97bed356fd4fdce08d
pom.xml bd79ede8708b6360d81ab61daa4bc40041f592c1
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java a09e7f60364e671fc2f7ce6fd609c816b1293bd6
ql/src/test/results/clientpositive/druid/druid_basic2.q.out 444d91db32d3bb81ce97632393f5bbb2775b8acb
ql/src/test/results/clientpositive/druid/druidmini_expressions.q.out 610558ad49119a260ca644afdf378da89b989d03
ql/src/test/results/clientpositive/druid/druidmini_extractTime.q.out 116c3266f4ff6d9b23cfb6e5887dd5893f1e254a
ql/src/test/results/clientpositive/druid/druidmini_floorTime.q.out 1c9e9c671806423d0660e8574971a869702d5b0d
ql/src/test/results/clientpositive/druid/druidmini_test1.q.out f93841f11c2bad747dac6f2d33d8e9920c32fe7f
ql/src/test/results/clientpositive/druid_intervals.q.out fde446cecb87aa1ce24e56df12f4ad5f28cdbbf0
ql/src/test/results/clientpositive/druid_timeseries.q.out 455bdd542146f048f6e16ea892ab9c8065ee4bc3
ql/src/test/results/clientpositive/druid_topn.q.out 7bfd2ae93b3245d32e148733e58025897c19f65e
ql/src/test/results/clientpositive/infer_join_preds.q.out 62b977f5c7b6464dd3a40b12253ebf0da94af760
ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 46c40b4bd77e345ddef532158ab9b5292d99eaa7
ql/src/test/results/clientpositive/llap/explainuser_1.q.out f9018b42736eaa8d9a4cb244f460511e4667bfde
ql/src/test/results/clientpositive/llap/subquery_multi.q.out 89883fd0f8f5338889a079d81965f4f729f868b9
ql/src/test/results/clientpositive/llap/subquery_scalar.q.out dc5461111b0c25541685b7b1ca789600e38ed149
ql/src/test/results/clientpositive/llap/subquery_views.q.out 05c91cdae9adcb87e1b4b9adb4871fb686f9286c
ql/src/test/results/clientpositive/llap/vectorized_case.q.out 7e5fee0422699fdf2953e2691abc79b1eda336f8
ql/src/test/results/clientpositive/pcr.q.out 1d203f739546a9a8d0a583c5229aed73fa5221aa
ql/src/test/results/clientpositive/perf/spark/query11.q.out f0e8732812fa2301a8050685b925649595511637
ql/src/test/results/clientpositive/perf/spark/query4.q.out 0993dc23c2ec5ce6b0fc7f52be0380c4e3e0f2bc
ql/src/test/results/clientpositive/perf/spark/query74.q.out c9083ac4f047c60d574eed39b26f3bb0a5b87548
ql/src/test/results/clientpositive/perf/tez/query11.q.out bf454a0e754827e829165e1397e093f96254c2d7
ql/src/test/results/clientpositive/perf/tez/query4.q.out 75d5423d47aa3a09cb762d715d9048044673d40b
ql/src/test/results/clientpositive/perf/tez/query74.q.out 738e64f799c89fcf6bc335731a6df8b86c99dbf8
ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 750969798879e84de1f74d99a65d289c60e9502c
ql/src/test/results/clientpositive/spark/pcr.q.out 11c7891d413258032f45b2396b6ef4c8f40d6041
ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out b488129cd0f35a6c908cbc6b09080081bf16d063
ql/src/test/results/clientpositive/spark/subquery_multi.q.out 80a48b7852a9ebfeb507dbb5a2153b4c26157877
ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 9105f587c00336c1c433bae85ced45633ec5472b
ql/src/test/results/clientpositive/spark/subquery_views.q.out 67711c234e2c454916a2eba3a47a8630c113c6bf
ql/src/test/results/clientpositive/spark/vectorized_case.q.out 4d322cf1545a9f27f9737a2c09d095781b135c26
ql/src/test/results/clientpositive/stat_estimate_related_col.q.out 78524d671693d1933ee24e1326d4c9d3e6f75907
ql/src/test/results/clientpositive/union_offcbo.q.out ce27bf29324a384e39daf314f84228bf3b711324
Diff: https://reviews.apache.org/r/68084/diff/1/
Testing
-------
Thanks,
Jesús Camacho Rodríguez