You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "San-43 (via GitHub)" <gi...@apache.org> on 2026/06/10 07:16:15 UTC
[PR] FINERACT-1315: archive FD and RD products [fineract]
San-43 opened a new pull request, #5967:
URL: https://github.com/apache/fineract/pull/5967
## Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [X] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [X] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
- [X] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [X] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5967:
URL: https://github.com/apache/fineract/pull/5967#discussion_r3450904602
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositProductReadPlatformServiceImpl.java:
##########
@@ -74,6 +78,9 @@ public Collection<DepositProductData> retrieveAllForLookup(final DepositAccountT
sqlBuilder.append("select ");
sqlBuilder.append(DEPOSIT_PRODUCT_LOOKUP_MAPPER.schema());
sqlBuilder.append(" where sp.deposit_type_enum = ? ");
+ sqlBuilder.append(" and (sp.close_date is null or sp.close_date >= ");
Review Comment:
I dont think we should filter them out...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1315: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-4672286093
@San-43 This PR has nothing to do with: https://issues.apache.org/jira/browse/FINERACT-1315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5967:
URL: https://github.com/apache/fineract/pull/5967#discussion_r3450916385
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/RecurringDepositProduct.java:
##########
@@ -150,6 +155,11 @@ public void validateDomainRules() {
}
private void validateDomainRules(final DataValidatorBuilder baseDataValidator) {
+ if (getStartDate() != null && getCloseDate() != null && DateUtils.isBefore(getCloseDate(), getStartDate())) {
Review Comment:
This should be handled in validator, not in JPA! Please move this logic out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-4809033662
@San-43 Please review my comments and the failing checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5967:
URL: https://github.com/apache/fineract/pull/5967#discussion_r3450875999
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/FixedDepositProductsApiResourceSwagger.java:
##########
@@ -101,6 +107,8 @@ private PostFixedDepositProductsChartSlabs() {}
public Integer maxDepositTerm;
@Schema(example = "3")
public Integer maxDepositTermTypeId;
+ @Schema(example = "10000")
+ public Long depositAmount;
Review Comment:
This should be BigDecimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-5398520891
> Hey @adamsaghy happy to solve this if its okay. @San-43 has already did good work to this.
Sure. Go ahead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-4741781700
@San-43 Please rebase the PR to resolve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-4811190364
@San-43 No worries ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "San-43 (via GitHub)" <gi...@apache.org>.
San-43 commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-4810311607
Hello @adamsaghy sorry for the delay, but I won't be able to work on this PR until this Sunday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-5805290016
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "San-43 (via GitHub)" <gi...@apache.org>.
San-43 commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-5174665603
Hello @adamsaghy, I’m really sorry, but I won’t be able to find time to fix or work on this PR anytime soon. Life is pretty busy right now with my first ever job. Fine by me if someone wants to pick it up from here. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "San-43 (via GitHub)" <gi...@apache.org>.
San-43 commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-4700976412
Fixed the failing tests and rebased onto the latest develop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5967:
URL: https://github.com/apache/fineract/pull/5967#discussion_r3450916385
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/RecurringDepositProduct.java:
##########
@@ -150,6 +155,11 @@ public void validateDomainRules() {
}
private void validateDomainRules(final DataValidatorBuilder baseDataValidator) {
+ if (getStartDate() != null && getCloseDate() != null && DateUtils.isBefore(getCloseDate(), getStartDate())) {
Review Comment:
This should be handled in validator, not in JPA entity. Please move this logic out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy closed pull request #5967: FINERACT-1183: archive FD and RD products
URL: https://github.com/apache/fineract/pull/5967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5967:
URL: https://github.com/apache/fineract/pull/5967#discussion_r3450901843
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/DepositAccountDomainServiceJpa.java:
##########
@@ -271,6 +272,7 @@ public Long handleFDAccountMaturityClosure(final FixedDepositAccount account, fi
}
ExternalId externalId = this.externalIdFactory.create();
+ this.depositAccountAssembler.validateProductApplicationDate(closedDate, account.savingsProduct());
Review Comment:
I believe validations should occur as early as possible. Could we move this validator to be executed as one of the initial steps and only begin processing after it has successfully passed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5967:
URL: https://github.com/apache/fineract/pull/5967#discussion_r3450890667
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/DepositProductDataValidator.java:
##########
@@ -145,7 +145,9 @@ public void validateForFixedDepositUpdate(final String json) {
validateDepositTermDetailForUpdate(element, baseDataValidator);
- validateChartsData(element, baseDataValidator);
+ if (fromApiJsonHelper.parameterExists(chartsParamName, element)) {
Review Comment:
This condition can be moved into `validateChartsData`, so the validator will be unified (none of the other validate methods are wrapped in an if condition).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "AshharAhmadKhan (via GitHub)" <gi...@apache.org>.
AshharAhmadKhan commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-5830603266
Hey @adamsaghy, Should archived products stay hidden from the lookup dropdown entirely, or is it fine to just rely on validateProductApplicationDate() to block creation against them and drop the SQL filter here? Let me know which way and I'll sort it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1315: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-4672291313
@San-43 Can you please explain this PR and update the description + use correct Fineract JIRA ticket (or create new if needed)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "AshharAhmadKhan (via GitHub)" <gi...@apache.org>.
AshharAhmadKhan commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-5398469082
Hey @adamsaghy happy to solve this if its okay. @San-43 has already did good work to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-5831507977
> Hey @adamsaghy, Should archived products stay hidden from the lookup dropdown entirely, or is it fine to just rely on validateProductApplicationDate() to block creation against them and drop the SQL filter here? Let me know which way and I'll sort it.
The latter one. I dont want to hide any of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "San-43 (via GitHub)" <gi...@apache.org>.
San-43 commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-4762686700
@adamsaghy done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "San-43 (via GitHub)" <gi...@apache.org>.
San-43 commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-4672391323
> @San-43 Can you please explain this PR and update the description + use correct Fineract JIRA ticket (or create new if needed)?
Srry @adamsaghy, I referenced the wrong JIRA ticket. This PR addresses [FINERACT-1183](https://issues.apache.org/jira/browse/FINERACT-1183?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=18086795#comment-18086795).
It adds optional validity dates to Fixed Deposit and Recurring Deposit products. Archived products remain visible for administration, but cannot be used for new accounts or reinvestments. Existing accounts remain unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-5164767339
@San-43 Please let us know if you wont be able to work on this..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1183: archive FD and RD products [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5967:
URL: https://github.com/apache/fineract/pull/5967#issuecomment-5059712266
Converted to draft till not fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org