[GitHub] [couchdb-helm] willholley commented on a diff in pull request #73: allow uuid being created and managed by kubernetes

[GitBox <gi...@apache.org>]

willholley commented on code in PR #73:
URL: https://github.com/apache/couchdb-helm/pull/73#discussion_r1064481583


##########
couchdb/templates/secrets.yaml:
##########
@@ -18,4 +18,17 @@ data:
 {{- if  .Values.adminHash  }}
   password.ini: {{ tpl (.Files.Get "password.ini") . | b64enc }}
 {{- end -}}
-{{- end -}}
+{{- end }}
+---
+apiVersion: v1
+kind: Secret
+metadata:
+  name: {{ template "couchdb.fullname" . }}-internal
+  labels:
+    app: {{ template "couchdb.fullname" . }}
+    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    release: "{{ .Release.Name }}"
+    heritage: "{{ .Release.Service }}"
+type: Opaque
+data:
+  uuid: {{- include "couchdb.uuid" . }}

Review Comment:
   I'm not convinced about adding another secret resource here. The secret values `erlangCookie`, `cookieAuthSecret` are similarly internal only. It seems like a good clarification to split internal/external secrets but that could be a separate PR (and likely major version bump).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org