You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/25 08:21:07 UTC
[GitHub] [shardingsphere] ThanoshanMV opened a new pull request, #18581: Add PostgreSQL Create Cast Statement
ThanoshanMV opened a new pull request, #18581:
URL: https://github.com/apache/shardingsphere/pull/18581
For #17844
Changes proposed in this pull request:
- Add PostgreSQL [Create Cast Statement](https://www.postgresql.org/docs/current/sql-createcast.html).
- Add test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #18581: Add PostgreSQL Create Cast Statement
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #18581:
URL: https://github.com/apache/shardingsphere/pull/18581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #18581: Add PostgreSQL Create Cast Statement
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #18581:
URL: https://github.com/apache/shardingsphere/pull/18581#discussion_r906676133
##########
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/statement/impl/PostgreSQLDDLStatementSQLVisitor.java:
##########
@@ -1235,4 +1237,10 @@ public ASTNode visitBackwardAll(final BackwardAllContext ctx) {
result.setDirectionType(DirectionType.BACKWARD_ALL);
return result;
}
+
+ @Override
+ public ASTNode visitCreateCast(final CreateCastContext ctx) {
+ return new PostgreSQLCreateCastStatement();
+ }
+
Review Comment:
Please remove this useless blank line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org