You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "Poul Erik Nielsen (JIRA)" <ji...@apache.org> on 2008/10/01 20:17:46 UTC
[jira] Created: (LUCENENET-156) Contrib Highlighter.net ->
getBestTextFraments error
Contrib Highlighter.net -> getBestTextFraments error
----------------------------------------------------
Key: LUCENENET-156
URL: https://issues.apache.org/jira/browse/LUCENENET-156
Project: Lucene.Net
Issue Type: Bug
Environment: .NET framework
Reporter: Poul Erik Nielsen
In line 274 and 275 is comment out. So far, it's obvious written wrong. It should look like this.
if (lastEndOffset < text.Length)
newText.Append(encoder.EncodeText(text.Substring(lastEndOffset)));
If this code is comment out, it could cut off the end of the field. Example i field ends with </span> the newText would end as </span
Please correct it in the next release.
Poul
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-156) Contrib Highlighter.net ->
getBestTextFraments error
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660015#action_12660015 ]
George Aroush commented on LUCENENET-156:
-----------------------------------------
Good catch, but shouldn't the fix actually be:
if (startOffset > lastEndOffset)
newText.Append(encoder.EncodeText(text.Substring(lastEndOffset, (startOffset) - (lastEndOffset) + 1)));
You have the test logic changed from ">" to "<"; in my case, I added "+ 1"
The Java code, looks like so:
if (startOffset > lastEndOffset)
newText.append(encoder.encodeText(text.substring(lastEndOffset, startOffset)));
Java's substring() is: substring(int beginIndex, int endIndex)
C#'s Substring() is: Substring(int startIndex, int length);
> Contrib Highlighter.net -> getBestTextFraments error
> ----------------------------------------------------
>
> Key: LUCENENET-156
> URL: https://issues.apache.org/jira/browse/LUCENENET-156
> Project: Lucene.Net
> Issue Type: Bug
> Environment: .NET framework
> Reporter: Poul Erik Nielsen
>
> In line 274 and 275 is comment out. So far, it's obvious written wrong. It should look like this.
> if (lastEndOffset < text.Length)
> newText.Append(encoder.EncodeText(text.Substring(lastEndOffset)));
> If this code is comment out, it could cut off the end of the field. Example i field ends with </span> the newText would end as </span
> Please correct it in the next release.
> Poul
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-156) Contrib Highlighter.net ->
getBestTextFraments error
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726233#action_12726233 ]
Digy commented on LUCENENET-156:
--------------------------------
Hi Enrique,
You are right. I restored Highlighter.cs
DIGY
> Contrib Highlighter.net -> getBestTextFraments error
> ----------------------------------------------------
>
> Key: LUCENENET-156
> URL: https://issues.apache.org/jira/browse/LUCENENET-156
> Project: Lucene.Net
> Issue Type: Bug
> Environment: .NET framework
> Reporter: Poul Erik Nielsen
>
> In line 274 and 275 is comment out. So far, it's obvious written wrong. It should look like this.
> if (lastEndOffset < text.Length)
> newText.Append(encoder.EncodeText(text.Substring(lastEndOffset)));
> If this code is comment out, it could cut off the end of the field. Example i field ends with </span> the newText would end as </span
> Please correct it in the next release.
> Poul
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (LUCENENET-156) Contrib Highlighter.net ->
getBestTextFraments error
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy closed LUCENENET-156.
--------------------------
Resolution: Fixed
Line 269:
- newText.Append(encoder.EncodeText(text.Substring(lastEndOffset, (startOffset) - (lastEndOffset))));
+ newText.Append(encoder.EncodeText(text.Substring(lastEndOffset, (startOffset) - (lastEndOffset)+1)));
Fixed.
> Contrib Highlighter.net -> getBestTextFraments error
> ----------------------------------------------------
>
> Key: LUCENENET-156
> URL: https://issues.apache.org/jira/browse/LUCENENET-156
> Project: Lucene.Net
> Issue Type: Bug
> Environment: .NET framework
> Reporter: Poul Erik Nielsen
>
> In line 274 and 275 is comment out. So far, it's obvious written wrong. It should look like this.
> if (lastEndOffset < text.Length)
> newText.Append(encoder.EncodeText(text.Substring(lastEndOffset)));
> If this code is comment out, it could cut off the end of the field. Example i field ends with </span> the newText would end as </span
> Please correct it in the next release.
> Poul
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-156) Contrib Highlighter.net ->
getBestTextFraments error
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724363#action_12724363 ]
George Aroush commented on LUCENENET-156:
-----------------------------------------
Hi DIGY,
I have not done much with the Highlighter code or any of the contrib code in a while. My comment to Poul was based on comparing this line to what's in the Java version. I believe the fix need to be based on my comment and not Poul's.
-- George
> Contrib Highlighter.net -> getBestTextFraments error
> ----------------------------------------------------
>
> Key: LUCENENET-156
> URL: https://issues.apache.org/jira/browse/LUCENENET-156
> Project: Lucene.Net
> Issue Type: Bug
> Environment: .NET framework
> Reporter: Poul Erik Nielsen
>
> In line 274 and 275 is comment out. So far, it's obvious written wrong. It should look like this.
> if (lastEndOffset < text.Length)
> newText.Append(encoder.EncodeText(text.Substring(lastEndOffset)));
> If this code is comment out, it could cut off the end of the field. Example i field ends with </span> the newText would end as </span
> Please correct it in the next release.
> Poul
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-156) Contrib Highlighter.net ->
getBestTextFraments error
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723677#action_12723677 ]
Digy commented on LUCENENET-156:
--------------------------------
Hi George,
I see changes made to Highlighter.cs at 31/Dec/2008. What is the state of it, fixed or not?.
DIGY
> Contrib Highlighter.net -> getBestTextFraments error
> ----------------------------------------------------
>
> Key: LUCENENET-156
> URL: https://issues.apache.org/jira/browse/LUCENENET-156
> Project: Lucene.Net
> Issue Type: Bug
> Environment: .NET framework
> Reporter: Poul Erik Nielsen
>
> In line 274 and 275 is comment out. So far, it's obvious written wrong. It should look like this.
> if (lastEndOffset < text.Length)
> newText.Append(encoder.EncodeText(text.Substring(lastEndOffset)));
> If this code is comment out, it could cut off the end of the field. Example i field ends with </span> the newText would end as </span
> Please correct it in the next release.
> Poul
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-156) Contrib Highlighter.net ->
getBestTextFraments error
Posted by "Enrique Martínez Zúñiga (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726216#action_12726216 ]
Enrique Martínez Zúñiga commented on LUCENENET-156:
---------------------------------------------------
After applying the patch with the example code does the following marking:
Searching for "novela":
Una en otra: <span class=""highlight"">novela</span> de ccostumbres
Instead of:
Una en otra: <span class=""highlight"">novela</span> de costumbres
And:
<span class=""highlight"">Novela</span> CCostumbrista
Instead of:
<span class=""highlight"">Novela</span> Costumbrista
Sample Code
...
Dim idxSF As SimpleHTMLFormatter = New SimpleHTMLFormatter("<span class=""highlight"">", "</span>")
Dim qs As QueryScorer = New QueryScorer(qry.Rewrite(idxReader))
Dim highlighter As Highlighter = New Highlighter(idxSF, qs)
Dim ts As TokenStream = idxAnalyzer.TokenStream(strFieldName, New StringReader(strValue))
Dim strText As String = hi.GetBestFragments(ts, strValue, 80, "...")
ts.Close()
...
> Contrib Highlighter.net -> getBestTextFraments error
> ----------------------------------------------------
>
> Key: LUCENENET-156
> URL: https://issues.apache.org/jira/browse/LUCENENET-156
> Project: Lucene.Net
> Issue Type: Bug
> Environment: .NET framework
> Reporter: Poul Erik Nielsen
>
> In line 274 and 275 is comment out. So far, it's obvious written wrong. It should look like this.
> if (lastEndOffset < text.Length)
> newText.Append(encoder.EncodeText(text.Substring(lastEndOffset)));
> If this code is comment out, it could cut off the end of the field. Example i field ends with </span> the newText would end as </span
> Please correct it in the next release.
> Poul
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.