You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/05/18 04:50:08 UTC

[GitHub] [pulsar] codecov-commenter commented on pull request #20346: [improve][admin] Return BAD_REQUEST on cluster data is null for createCluster

codecov-commenter commented on PR #20346:
URL: https://github.com/apache/pulsar/pull/20346#issuecomment-1552394401

   ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#20346](https://app.codecov.io/gh/apache/pulsar/pull/20346?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f69aca2) into [master](https://app.codecov.io/gh/apache/pulsar/commit/1a66b640c3cd86bfca75dc9ab37bfdb37427a13f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1a66b64) will **increase** coverage by `38.35%`.
   > The diff coverage is `85.71%`.
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/20346/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/20346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #20346       +/-   ##
   =============================================
   + Coverage     34.55%   72.91%   +38.35%     
   - Complexity    12631    31852    +19221     
   =============================================
     Files          1614     1864      +250     
     Lines        126234   138283    +12049     
     Branches      13779    15174     +1395     
   =============================================
   + Hits          43622   100830    +57208     
   + Misses        76999    29445    -47554     
   - Partials       5613     8008     +2395     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | inttests | `24.18% <14.28%> (+0.05%)` | :arrow_up: |
   | systests | `24.96% <14.28%> (?)` | |
   | unittests | `72.19% <85.71%> (+38.89%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...hentication/oidc/AuthenticationProviderOpenID.java](https://app.codecov.io/gh/apache/pulsar/pull/20346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1hdXRoLW9pZGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvYXV0aGVudGljYXRpb24vb2lkYy9BdXRoZW50aWNhdGlvblByb3ZpZGVyT3BlbklELmphdmE=) | `75.86% <ø> (+75.86%)` | :arrow_up: |
   | [...org/apache/pulsar/broker/ServiceConfiguration.java](https://app.codecov.io/gh/apache/pulsar/pull/20346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvU2VydmljZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `99.37% <ø> (+1.45%)` | :arrow_up: |
   | [.../apache/pulsar/broker/admin/impl/ClustersBase.java](https://app.codecov.io/gh/apache/pulsar/pull/20346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL0NsdXN0ZXJzQmFzZS5qYXZh) | `81.20% <0.00%> (+70.48%)` | :arrow_up: |
   | [...e/pulsar/broker/authentication/oidc/JwksCache.java](https://app.codecov.io/gh/apache/pulsar/pull/20346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1hdXRoLW9pZGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvYXV0aGVudGljYXRpb24vb2lkYy9Kd2tzQ2FjaGUuamF2YQ==) | `66.66% <93.75%> (+66.66%)` | :arrow_up: |
   | [...ker/service/persistent/PersistentSubscription.java](https://app.codecov.io/gh/apache/pulsar/pull/20346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudFN1YnNjcmlwdGlvbi5qYXZh) | `75.91% <100.00%> (+25.83%)` | :arrow_up: |
   
   ... and [1505 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20346/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org