You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by paptimusx scirocco <pa...@gmail.com> on 2007/09/18 10:42:24 UTC

svnadmin has bug

Hello, everyone.

I found svnadmin has bug.
please see the following:

svnadmin.exe malfunctions in case of [miscellany]/use-commit-times
option is 'yes', like this:
 [miscellany]
 use-commit-times = yes

if these options were found, svn.exe put last-commited
timestamps on file touched. its all right. I like it.

# but, the option makes svnadmin.exe wrong.

(1) wrong case
[miscellany]
use-commit-times = yes
% cat dumpfile | svn admin  ... & svn co ...
% svn diff -r{2007-09-07}:{2007-09-13} xxxxx1.cpp | wc -l
 (no difference)

(2) default configuration
[miscellany]
##use-commit-times = yes     (as default.  it means 'no' probably)

% cat dumpfile | svn admin ... & svn co ...  (uses same dumpfile)
% svn diff -r{2007-09-07}:{2007-09-13} xxxxx1.cpp | wc -l
      24

---
% svnadmin --version
svnadmin, version 1.4.5 (r25188)
   compiled Aug 22 2007, 20:49:04
% ver
Microsoft Windows XP [Version 5.1.2600]

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: svnadmin has bug

Posted by Andy Levy <an...@gmail.com>.
On 9/18/07, paptimusx scirocco <pa...@gmail.com> wrote:
> I also thought so. svnadmin.exe isn't affected by 'use-commit-times'.
> however, It is possible to reproduce, and try, please.

I think the onus is on you to explain *why* this option makes svnadmin
"wrong", including a *complete* reproduction recipe (which you didn't
provide as far as I can tell) so that people can confirm it.

If your original post said "this option makes svnadmin wrong" and now
you're agreeing with Erik that svnadmin isn't affected by this
option...what's left?

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: svnadmin has bug

Posted by paptimusx scirocco <pa...@gmail.com>.
I also thought so. svnadmin.exe isn't affected by 'use-commit-times'.
however, It is possible to reproduce, and try, please.

for the time being, I will avoid this trap. there is no problem on
practical use.

bye.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: svnadmin has bug

Posted by Erik Huelsmann <eh...@gmail.com>.
On 9/18/07, paptimusx scirocco <pa...@gmail.com> wrote:
> Hello, everyone.
>
> I found svnadmin has bug.
> please see the following:
>
> svnadmin.exe malfunctions in case of [miscellany]/use-commit-times
> option is 'yes', like this:
>  [miscellany]
>  use-commit-times = yes
>
> if these options were found, svn.exe put last-commited
> timestamps on file touched. its all right. I like it.
>
> # but, the option makes svnadmin.exe wrong.

I'm sorry, I have *no* idea what's going on, but svnadmin.exe isn't
affected by use-commit-times, that's something I know for *really*
sure.

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: svnadmin has bug

Posted by Karl Fogel <kf...@red-bean.com>.
These mails are not helping.  Please give us a full reproduction
recipe, if/when you have one.  We can't do much without that.  Have
you read http://subversion.tigris.org/bugs.html#how ?

You need to take the time to write out a complete, clear description
of the bug.  This might require hours.  But if you don't take the time
to be clear & complete, we won't spend time on the problem.

-Karl

"paptimusx scirocco" <pa...@gmail.com> writes:
> (Continuation)
>
> cvs2svn.py & svnadmin load .. & svn co .. & svn diff -r {DATE}
>
> It ends only because recent diff comes off when it is subversion 1.4.4
>
> Is it as such?
>
> =====
> Subversion 1.4.4 : Recent 'diff -r {DATE} '  comes off.
> Subversion 1.4.5 : ALL    'diff -r {DATE} '  comes off.
>
> (Its ok that svn diff -r<number>:<number>)
>
>
> ===== DIFF (1.4.4)
> % svn diff -r{"2007-07-01"} ccccc.cpp | wc -l       ????????
>        0
>
> % svn diff -r{"2007-05-08"} ccccc.cpp | wc -l       ????????
>        0
>
> % svn diff -r{"2007-05-07"} ccccc.cpp | wc -l       ok
>       78
>
> % svn diff -r{"2007-05-01"} ccccc.cpp | wc -l       ok
>       78
>
> % svn diff -r{"2007-01-01"} ccccc.cpp | wc -l       ok
>      148
>
> ===== LOG
> % svn log ccccc.cpp
> ------------------------------------------------------------------------
> r9048 | myname | 2007-08-21 11:00:36 +0900 (Tue, 21 8 2007) | 6 lines
>
> ;
> ;
> ;
> ;
> ;
>
> ------------------------------------------------------------------------
> r9032 | myname | 2007-07-20 11:39:23 +0900 (Fri, 20 7 2007) | 2 lines
>
> ;
>
> ------------------------------------------------------------------------
> r8996 | myname | 2007-07-06 17:05:13 +0900 (Fri, 06 7 2007) | 2 lines
>
> ;
>
> ------------------------------------------------------------------------
> r8929 | myname | 2007-06-27 11:49:37 +0900 (Wed, 27 6 2007) | 2 lines
>
> ;
>
> ------------------------------------------------------------------------
> r8913 | myname | 2007-06-07 11:38:39 +0900 (Thu, 07 6 2007) | 2 lines
>
> ;
>
> ------------------------------------------------------------------------
> r8635 | myname | 2007-01-25 17:03:45 +0900 (Thu, 25 1 2007) | 2 lines
>
> ;
>
> ------------------------------------------------------------------------
> r8616 | myname | 2007-01-22 16:38:07 +0900 (Mon, 22 1 2007) | 2 lines
>
> ;
>
> ------------------------------------------------------------------------
> r8542 | myname | 2006-11-02 23:41:59 +0900 (Thu, 02 11 2006) | 2 lines
>
> ;
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: users-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: svnadmin has bug

Posted by paptimusx scirocco <pa...@gmail.com>.
(Continuation)

cvs2svn.py & svnadmin load .. & svn co .. & svn diff -r {DATE}

It ends only because recent diff comes off when it is subversion 1.4.4

Is it as such?

=====
Subversion 1.4.4 : Recent 'diff -r {DATE} '  comes off.
Subversion 1.4.5 : ALL    'diff -r {DATE} '  comes off.

(Its ok that svn diff -r<number>:<number>)


===== DIFF (1.4.4)
% svn diff -r{"2007-07-01"} ccccc.cpp | wc -l       ????????
       0

% svn diff -r{"2007-05-08"} ccccc.cpp | wc -l       ????????
       0

% svn diff -r{"2007-05-07"} ccccc.cpp | wc -l       ok
      78

% svn diff -r{"2007-05-01"} ccccc.cpp | wc -l       ok
      78

% svn diff -r{"2007-01-01"} ccccc.cpp | wc -l       ok
     148

===== LOG
% svn log ccccc.cpp
------------------------------------------------------------------------
r9048 | myname | 2007-08-21 11:00:36 +0900 (Tue, 21 8 2007) | 6 lines

;
;
;
;
;

------------------------------------------------------------------------
r9032 | myname | 2007-07-20 11:39:23 +0900 (Fri, 20 7 2007) | 2 lines

;

------------------------------------------------------------------------
r8996 | myname | 2007-07-06 17:05:13 +0900 (Fri, 06 7 2007) | 2 lines

;

------------------------------------------------------------------------
r8929 | myname | 2007-06-27 11:49:37 +0900 (Wed, 27 6 2007) | 2 lines

;

------------------------------------------------------------------------
r8913 | myname | 2007-06-07 11:38:39 +0900 (Thu, 07 6 2007) | 2 lines

;

------------------------------------------------------------------------
r8635 | myname | 2007-01-25 17:03:45 +0900 (Thu, 25 1 2007) | 2 lines

;

------------------------------------------------------------------------
r8616 | myname | 2007-01-22 16:38:07 +0900 (Mon, 22 1 2007) | 2 lines

;

------------------------------------------------------------------------
r8542 | myname | 2006-11-02 23:41:59 +0900 (Thu, 02 11 2006) | 2 lines

;

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: svnadmin has bug

Posted by paptimusx scirocco <pa...@gmail.com>.
I tried.
(to make sure, my dumpfile is the one having converted it from cvs
 to svn in using cvs2svn2.0.0.)

Subversion 1.4.5
 I tried a small test-dumpfile making it.
 It was one subdirectory was pulled out, did not reproduce it.
 It reproduces it in all directories.

Subversion 1.4.4
 It did not reproduce it in all. It's seems to be all right.

In my understanding, 1.4.5 is a security patch release, and there
is no essential change in 1.4.5. but, there seem to be differences
 in 1.4.4 and 1.4.5.
Is there something difference in 'User-NOT-visible changes' ?

thanx.

--
I do not understand a detailed content:

Subversion 1.4.5
User-visible changes:
 * fixed: file placement vulnerability (Win32 clients only)
          See CVE-2007-3846, and descriptive advisory at
          http://subversion.tigris.org/security/CVE-2007-3864-advisory.txt

Subversion 1.4.4
                 :
 * fixed: 'svnadmin load' invents svn:date if none exists (issue #2729)
                 :

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: svnadmin has bug

Posted by Karl Fogel <kf...@red-bean.com>.
"paptimusx scirocco" <pa...@gmail.com> writes:
> Because the size of a genuine repository is huge, and cannot
> disclose the content, I think that it tries to make a small
> sample, somehow or other.

That would be great, thanks.

> Is appending the file allowed in this ML?  or, is sending to the
> bug tracking system somewhere appropriate?

If it's small, yes.  If large, put it up at a URL, and point us to the
URL.

> 'svn admin ...' is a mistake of 'svnadmin load ...'.

Understood.

Thank you,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: svnadmin has bug

Posted by paptimusx scirocco <pa...@gmail.com>.
Thank your for your answer.

I have become not confident...  I examine it a little more.

Because the size of a genuine repository is huge, and cannot
disclose the content, I think that it tries to make a small
sample, somehow or other.

Is appending the file allowed in this ML?  or, is sending to the
bug tracking system somewhere appropriate?


'svn admin ...' is a mistake of 'svnadmin load ...'.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: svnadmin has bug

Posted by Karl Fogel <kf...@red-bean.com>.
"paptimusx scirocco" <pa...@gmail.com> writes:
> # but, the option makes svnadmin.exe wrong.
>
> (1) wrong case
> [miscellany]
> use-commit-times = yes
> % cat dumpfile | svn admin  ... & svn co ...
> % svn diff -r{2007-09-07}:{2007-09-13} xxxxx1.cpp | wc -l
>  (no difference)
>
> (2) default configuration
> [miscellany]
> ##use-commit-times = yes     (as default.  it means 'no' probably)
>
> % cat dumpfile | svn admin ... & svn co ...  (uses same dumpfile)
> % svn diff -r{2007-09-07}:{2007-09-13} xxxxx1.cpp | wc -l
>       24

These transcripts *cannot* be accurate, because they say "svn admin"
not "svnadmin".  There is no "admin" subcommand to "svn".  When
reporting a bug, please give a full, accurate transcript, leaving out
as little as possible.  The best transcript is a shell script or batch
script that reproduces the problem reliably.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org