[jira] [Updated] (HDDS-8555) [Snapshot] When snapshot feature is disabled, block OM startup if there are still snapshots in the system

["Siyao Meng (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDDS-8555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siyao Meng updated HDDS-8555:
-----------------------------
    Status: Patch Available  (was: Open)

> [Snapshot] When snapshot feature is disabled, block OM startup if there are still snapshots in the system
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HDDS-8555
>                 URL: https://issues.apache.org/jira/browse/HDDS-8555
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: OM
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>              Labels: pull-request-available
>
> This is another follow-up to HDDS-8166.
> Even though theoretically HDDS-8166's approach should work just fine even when snapshots are taken *before* snapshot feature is set to disabled (Note: those key blocks will be forever stuck in the cluster because KeyDeletingTask still checks against existing snapshots and won't reclaim key blocks that are still referenced. Only when snapshot feature is enabled again and snapshots deleted, those blocks can be cleaned up.), as a precaution, we want to add a check during OM startup to *make sure there are zero snapshots on the cluster when snapshot feature is disabled*. This can be achieved by checking snapshotInfoTable emptiness.
> The snapshot feature flag is not meant to be constantly toggled on and off. The supported use case is that for a fresh OM cluster that doesn't want to Ozone snapshot feature to be used, it would be explicitly set to false at the beginning.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org