You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "John Plevyak (JIRA)" <ji...@apache.org> on 2009/11/14 18:52:39 UTC
[jira] Created: (TS-38) ubuntu 8.04 x86_64 w/ gcc 4.2.4
ubuntu 8.04 x86_64 w/ gcc 4.2.4
--------------------------------
Key: TS-38
URL: https://issues.apache.org/jira/browse/TS-38
Project: Traffic Server
Issue Type: Bug
Components: Portability
Environment: ubuntu 8.04 x86_64 w/ gcc 4.2.4
Reporter: John Plevyak
Priority: Minor
Warnings prevent compilation on this platform. Some casts need to be cleaned up.
c1plus: warnings being treated as errors
../../libinktomi++/ink_queue.cc: In function 'void ink_freelist_init(InkFreeList*, const char*, unsigned int, unsigned int, unsigned int, unsigned int)':
../../libinktomi++/ink_queue.cc:136: warning: NULL used in arithmetic
../../libinktomi++/ink_queue.cc: In function 'void ink_atomiclist_init(InkAtomicList*, const char*, unsigned int)':
../../libinktomi++/ink_queue.cc:531: warning: NULL used in arithmetic
../../libinktomi++/ink_queue.cc: In function 'void* ink_atomiclist_popall(InkAtomicList*)':
../../libinktomi++/ink_queue.cc:582: warning: NULL used in arithmetic
make[1]: *** [ink_queue.o] Error 1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-38) ubuntu 8.04 x86_64 w/ gcc 4.2.4
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Call resolved TS-38.
--------------------------
Resolution: Fixed
Fix Version/s: 2.0a
Assignee: Bryan Call
Applies the patch from John after reviewing the code and testing it.
> ubuntu 8.04 x86_64 w/ gcc 4.2.4
> --------------------------------
>
> Key: TS-38
> URL: https://issues.apache.org/jira/browse/TS-38
> Project: Traffic Server
> Issue Type: Bug
> Components: Portability
> Environment: ubuntu 8.04 x86_64 w/ gcc 4.2.4
> Reporter: John Plevyak
> Assignee: Bryan Call
> Priority: Minor
> Fix For: 2.0a
>
> Attachments: ts-64-bit-warning.patch
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> Warnings prevent compilation on this platform. Some casts need to be cleaned up.
> c1plus: warnings being treated as errors
> ../../libinktomi++/ink_queue.cc: In function 'void ink_freelist_init(InkFreeList*, const char*, unsigned int, unsigned int, unsigned int, unsigned int)':
> ../../libinktomi++/ink_queue.cc:136: warning: NULL used in arithmetic
> ../../libinktomi++/ink_queue.cc: In function 'void ink_atomiclist_init(InkAtomicList*, const char*, unsigned int)':
> ../../libinktomi++/ink_queue.cc:531: warning: NULL used in arithmetic
> ../../libinktomi++/ink_queue.cc: In function 'void* ink_atomiclist_popall(InkAtomicList*)':
> ../../libinktomi++/ink_queue.cc:582: warning: NULL used in arithmetic
> make[1]: *** [ink_queue.o] Error 1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: Cache failing to cache after 2 weeks??
Posted by John Plevyak <jp...@acm.org>.
I ask the folks over at AOL and as of 2006 at least they haven't seen this issue.
It might be worth while to find the first reports and dig into the history.
john
John Plevyak wrote:
> Then maybe we should create a jira issue and give everyone a place
> do dump all their info... perhaps the combined data will give us
> traction.
>
> john
>
>
> Belmon, Stephane wrote:
>> This is probably some older-than-dirt problem, we see it in *our* tree, so...
>>
>> It might very well be plugin related, not sure.
>>
>> -----Original Message-----
>> From: John Plevyak [mailto:jplevyak@acm.org]
>> Sent: Saturday, November 14, 2009 2:00 PM
>> To: trafficserver-dev@incubator.apache.org
>> Subject: Cache failing to cache after 2 weeks??
>>
>> This seems like a pretty bad bug and one that I would like to see fixed
>> if it is true.
>>
>> Who all has seen it? and if there is reason to believe it might be part
>> of this codebase
>> (i.e. not attributable to some plugin or special environment) should we
>> start something
>> in jira for it?
>>
>> john
>>
>>
>> Protected by Websense Hosted Email Security -- www.websense.com
Re: Cache failing to cache after 2 weeks??
Posted by Leif Hedstrom <zw...@apache.org>.
On 11/15/2009 10:05 PM, John Plevyak wrote:
> Then maybe we should create a jira issue and give everyone a place
> do dump all their info... perhaps the combined data will give us
> traction.
>
Please do! :)
-- leif
Re: Cache failing to cache after 2 weeks??
Posted by John Plevyak <jp...@acm.org>.
Then maybe we should create a jira issue and give everyone a place
do dump all their info... perhaps the combined data will give us
traction.
john
Belmon, Stephane wrote:
> This is probably some older-than-dirt problem, we see it in *our* tree, so...
>
> It might very well be plugin related, not sure.
>
> -----Original Message-----
> From: John Plevyak [mailto:jplevyak@acm.org]
> Sent: Saturday, November 14, 2009 2:00 PM
> To: trafficserver-dev@incubator.apache.org
> Subject: Cache failing to cache after 2 weeks??
>
> This seems like a pretty bad bug and one that I would like to see fixed
> if it is true.
>
> Who all has seen it? and if there is reason to believe it might be part
> of this codebase
> (i.e. not attributable to some plugin or special environment) should we
> start something
> in jira for it?
>
> john
>
>
> Protected by Websense Hosted Email Security -- www.websense.com
RE: Cache failing to cache after 2 weeks??
Posted by "Belmon, Stephane" <sb...@websense.com>.
This is probably some older-than-dirt problem, we see it in *our* tree, so...
It might very well be plugin related, not sure.
-----Original Message-----
From: John Plevyak [mailto:jplevyak@acm.org]
Sent: Saturday, November 14, 2009 2:00 PM
To: trafficserver-dev@incubator.apache.org
Subject: Cache failing to cache after 2 weeks??
This seems like a pretty bad bug and one that I would like to see fixed
if it is true.
Who all has seen it? and if there is reason to believe it might be part
of this codebase
(i.e. not attributable to some plugin or special environment) should we
start something
in jira for it?
john
Protected by Websense Hosted Email Security -- www.websense.com
Cache failing to cache after 2 weeks??
Posted by John Plevyak <jp...@acm.org>.
This seems like a pretty bad bug and one that I would like to see fixed
if it is true.
Who all has seen it? and if there is reason to believe it might be part
of this codebase
(i.e. not attributable to some plugin or special environment) should we
start something
in jira for it?
john
[jira] Updated: (TS-38) ubuntu 8.04 x86_64 w/ gcc 4.2.4
Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Plevyak updated TS-38:
---------------------------
Attachment: ts-64-bit-warning.patch
This patch fixes the bug and also cleans up some bare "unsigned" types. Because this code is does bit manipulation on pointers and because the 64-bit port required differentiating between those things
which could contain pointers from those that could not and because prior to x86_64 the codebase
assumed that the native size int was the same size as pointers (which was true for the Alpha,
HPUX and AIX) and so used "unsigned" or "unsigned int" instead of uintptr_t I think it more prudent
to use inkXXX types in this code to mark those variables which are not used to hold pointer size things.
I chose inku32 under the assumption that we wouldn't have more than 4G of any one type of object
which might not hold true forever, but it does mean that the generated code is the same as now which
makes the patch safer.
> ubuntu 8.04 x86_64 w/ gcc 4.2.4
> --------------------------------
>
> Key: TS-38
> URL: https://issues.apache.org/jira/browse/TS-38
> Project: Traffic Server
> Issue Type: Bug
> Components: Portability
> Environment: ubuntu 8.04 x86_64 w/ gcc 4.2.4
> Reporter: John Plevyak
> Priority: Minor
> Attachments: ts-64-bit-warning.patch
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> Warnings prevent compilation on this platform. Some casts need to be cleaned up.
> c1plus: warnings being treated as errors
> ../../libinktomi++/ink_queue.cc: In function 'void ink_freelist_init(InkFreeList*, const char*, unsigned int, unsigned int, unsigned int, unsigned int)':
> ../../libinktomi++/ink_queue.cc:136: warning: NULL used in arithmetic
> ../../libinktomi++/ink_queue.cc: In function 'void ink_atomiclist_init(InkAtomicList*, const char*, unsigned int)':
> ../../libinktomi++/ink_queue.cc:531: warning: NULL used in arithmetic
> ../../libinktomi++/ink_queue.cc: In function 'void* ink_atomiclist_popall(InkAtomicList*)':
> ../../libinktomi++/ink_queue.cc:582: warning: NULL used in arithmetic
> make[1]: *** [ink_queue.o] Error 1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-38) ubuntu 8.04 x86_64 w/ gcc 4.2.4
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779559#action_12779559 ]
Bryan Call commented on TS-38:
------------------------------
Looked over the code and I incorporated it into TS-42. I have been using this code in my fc11 64bit and rhel4 64bit builds and testing.
> ubuntu 8.04 x86_64 w/ gcc 4.2.4
> --------------------------------
>
> Key: TS-38
> URL: https://issues.apache.org/jira/browse/TS-38
> Project: Traffic Server
> Issue Type: Bug
> Components: Portability
> Environment: ubuntu 8.04 x86_64 w/ gcc 4.2.4
> Reporter: John Plevyak
> Priority: Minor
> Attachments: ts-64-bit-warning.patch
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> Warnings prevent compilation on this platform. Some casts need to be cleaned up.
> c1plus: warnings being treated as errors
> ../../libinktomi++/ink_queue.cc: In function 'void ink_freelist_init(InkFreeList*, const char*, unsigned int, unsigned int, unsigned int, unsigned int)':
> ../../libinktomi++/ink_queue.cc:136: warning: NULL used in arithmetic
> ../../libinktomi++/ink_queue.cc: In function 'void ink_atomiclist_init(InkAtomicList*, const char*, unsigned int)':
> ../../libinktomi++/ink_queue.cc:531: warning: NULL used in arithmetic
> ../../libinktomi++/ink_queue.cc: In function 'void* ink_atomiclist_popall(InkAtomicList*)':
> ../../libinktomi++/ink_queue.cc:582: warning: NULL used in arithmetic
> make[1]: *** [ink_queue.o] Error 1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.