[GitHub] [superset] ktmud edited a comment on issue #9722: Edit the default "No Results" message

[GitBox <gi...@apache.org>]

ktmud edited a comment on issue #9722:
URL: https://github.com/apache/superset/issues/9722#issuecomment-779713755


   As Max noted, currently this text is hard-coded in a superset-ui component, which, like all superset-ui changes, is not every easy to update.
   
   I'm hesitant to add another config value just for this message, but we can maybe either
   
   1. Move SuperChart or the no-results file out of superset-ui to make it easier to override
   2. Handle no results like regular frontend errors, so we can reuse the [error message registry](https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/setup/setupErrorMessages.ts) introduced by @etr2460 , or
   3. Wait for monorepo migration (https://github.com/apache/superset/issues/13013)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org