You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by mike-tutkowski <gi...@git.apache.org> on 2015/08/10 23:59:18 UTC

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

GitHub user mike-tutkowski opened a pull request:

    https://github.com/apache/cloudstack/pull/674

    getUsedBytes should query the SolidFire cluster to acquire the size o…

    …f the given volume if there is no volume_details info for that volume (and then create a volume_details row for this volume so we don't have to make that cluster call for this purpose again)
    
    ********************
    
    This only impacts the SolidFire storage plug-in.
    
    In supporting back-end snapshots, I re-wrote how the getUsedBytes method works (which is called by the capacity manager).
    
    The implementation now depends on a new row in the volume_details table for the volume in question that says how large the backend volume that supports your virtual disk is (the virtual disk's size is kept track of in the volumes table).
    
    Since this addition to the volume_details table is new in 4.6 and these kinds of volumes have been created before 4.6, we need to make sure if no applicable volume_details row exits for the volume in question that we go retrieve the necessary info from the applicable SolidFire cluster and create a row in the volume_details table for future reference.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-tutkowski/cloudstack sf-related

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/674.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #674
    
----
commit 0f2f6f3b7e82f8a24f3fc76e0b52cb94feb0e794
Author: Mike Tutkowski <mi...@solidfire.com>
Date:   2015-08-06T17:59:30Z

    getUsedBytes should query the SolidFire cluster to acquire the size of the given volume if there is no volume_details info for that volume (and then create a volume_details row for this volume so we don't have to make that cluster call for this purpose again)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-130091528
  
    Code lgtm. can you publish the tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-130536522
  
    No, what you said made perfect sense. :) I just read it incorrectly at
    first.
    
    On Wed, Aug 12, 2015 at 11:02 PM, Rajani Karuturi <no...@github.com>
    wrote:
    
    > I think I confused you :). Since what is required is primitive long,
    > findbugs wants you to use parseLong instead of valueOf(which returns Long
    > object)
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/674#issuecomment-130536383>.
    >
    
    
    
    -- 
    *Mike Tutkowski*
    *Senior CloudStack Developer, SolidFire Inc.*
    e: mike.tutkowski@solidfire.com
    o: 303.746.7302
    Advancing the way the world uses the cloud
    <http://solidfire.com/solution/overview/?video=play>*™*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-130523246
  
    @mike-tutkowski master slow build failed as this commit introduced a new findbugs issues. Can you please take a look? http://jenkins.buildacloud.org/job/build-master-slowbuild/2045/findbugsResult/new/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-130100258
  
    I'd eventually like to. I'm in the process of setting up our test
    infrastructure so these kinds of tests can run automatically. Right now
    it's a combination of manually kicking off tests and manually running some
    tests via the GUI.
    
    On Tuesday, August 11, 2015, Daan Hoogland <no...@github.com> wrote:
    
    > Code lgtm. can you publish the tests?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/674#issuecomment-130091528>.
    >
    
    
    -- 
    *Mike Tutkowski*
    *Senior CloudStack Developer, SolidFire Inc.*
    e: mike.tutkowski@solidfire.com
    o: 303.746.7302
    Advancing the way the world uses the cloud
    <http://solidfire.com/solution/overview/?video=play>*™*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-129902187
  
    I see now unit tests for getUsedBytes() and creatAsync(), the methods you changed only a generic package org.apache.cloudstack.storage.test. Can you expand on how this code is tested, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-130536585
  
    No, what you said made perfect sense. :) I just read it incorrectly at first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by Mike Tutkowski <mi...@solidfire.com>.
I'm not sure what the protocol is on this, so I just went ahead and checked
in the code to fix the FindBugs issue and noted the PR (674) it is related
to.

Here is the commit:

8fcc76e

On Wed, Aug 12, 2015 at 10:55 PM, Mike Tutkowski <
mike.tutkowski@solidfire.com> wrote:

> Oh, I read what you wrote wrong. OK - thanks.
>
> On Wed, Aug 12, 2015 at 10:54 PM, mike-tutkowski <gi...@git.apache.org>
> wrote:
>
>> Github user mike-tutkowski commented on the pull request:
>>
>>     https://github.com/apache/cloudstack/pull/674#issuecomment-130535316
>>
>>     OK, but - ultimately - I do want to convert it to a primitive long.
>>
>>     On Wed, Aug 12, 2015 at 10:50 PM, Rajani Karuturi <
>> notifications@github.com>
>>     wrote:
>>
>>     > valueOf returns a new Long() where as parseLong returns primitive
>> long.
>>     > valueOf causes unboxing as what is required is a primitive long.
>> Using
>>     > parseLong will satisfy findbugs I think.
>>     >
>>     > —
>>     > Reply to this email directly or view it on GitHub
>>     > <
>> https://github.com/apache/cloudstack/pull/674#issuecomment-130535022>.
>>     >
>>
>>
>>
>>     --
>>     *Mike Tutkowski*
>>     *Senior CloudStack Developer, SolidFire Inc.*
>>     e: mike.tutkowski@solidfire.com
>>     o: 303.746.7302
>>     Advancing the way the world uses the cloud
>>     <http://solidfire.com/solution/overview/?video=play>*™*
>>
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> <http://solidfire.com/solution/overview/?video=play>*™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-130535316
  
    OK, but - ultimately - I do want to convert it to a primitive long.
    
    On Wed, Aug 12, 2015 at 10:50 PM, Rajani Karuturi <no...@github.com>
    wrote:
    
    > valueOf returns a new Long() where as parseLong returns primitive long.
    > valueOf causes unboxing as what is required is a primitive long. Using
    > parseLong will satisfy findbugs I think.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/674#issuecomment-130535022>.
    >
    
    
    
    -- 
    *Mike Tutkowski*
    *Senior CloudStack Developer, SolidFire Inc.*
    e: mike.tutkowski@solidfire.com
    o: 303.746.7302
    Advancing the way the world uses the cloud
    <http://solidfire.com/solution/overview/?video=play>*™*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-129974204
  
    I have internal functional tests that make use of a SolidFire system.
    
    On Tuesday, August 11, 2015, Daan Hoogland <no...@github.com> wrote:
    
    > I see now unit tests for getUsedBytes() and creatAsync(), the methods you
    > changed only a generic package org.apache.cloudstack.storage.test. Can you
    > expand on how this code is tested, please?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/674#issuecomment-129902187>.
    >
    
    
    -- 
    *Mike Tutkowski*
    *Senior CloudStack Developer, SolidFire Inc.*
    e: mike.tutkowski@solidfire.com
    o: 303.746.7302
    Advancing the way the world uses the cloud
    <http://solidfire.com/solution/overview/?video=play>*™*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/674


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-130186688
  
    code lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-130535022
  
    valueOf returns a new Long() where as parseLong returns primitive long. valueOf causes unboxing as what is required is a primitive long. Using parseLong will satisfy findbugs I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-130536383
  
    I think I confused you :). Since what is required is primitive long, findbugs wants you to use parseLong instead of valueOf(which returns Long object)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-130536491
  
    BTW, I just noticed, this PR is missing jira issue. It would be good to have one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...

Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/674#issuecomment-130526955
  
    It doesn't like this line:
    
    long lVolumeId = Long.valueOf(volume.getFolder());
    
    The folder column is a string, but it's storing a long for me (the ID of a
    SolidFire volume).
    
    Is there another way I should convert the value so the slow build will be
    OK with this?
    
    Thanks!
    
    On Wed, Aug 12, 2015 at 9:58 PM, Rajani Karuturi <no...@github.com>
    wrote:
    
    > @mike-tutkowski <https://github.com/mike-tutkowski> master slow build
    > failed as this commit introduced a new findbugs issues. Can you please take
    > a look?
    > http://jenkins.buildacloud.org/job/build-master-slowbuild/2045/findbugsResult/new/
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/674#issuecomment-130523246>.
    >
    
    
    
    -- 
    *Mike Tutkowski*
    *Senior CloudStack Developer, SolidFire Inc.*
    e: mike.tutkowski@solidfire.com
    o: 303.746.7302
    Advancing the way the world uses the cloud
    <http://solidfire.com/solution/overview/?video=play>*™*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---