You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/03/12 02:23:00 UTC
Review Request 31966: Add client support for including messages when
changing update state.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1077
https://issues.apache.org/jira/browse/AURORA-1077
Repository: aurora
Description
-------
More plumbing.
Diffs
-----
src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
Diff: https://reviews.apache.org/r/31966/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76331
-----------------------------------------------------------
Master (ee1a13a) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.api ..... SUCCESS
src.test.python.apache.aurora.client.cli.client ..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
src.test.python.apache.aurora.client.cli.config ..... SUCCESS
src.test.python.apache.aurora.client.cli.context ..... SUCCESS
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... FAILURE
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.thermos.cli.commands.commands ..... SUCCESS
src.test.python.apache.thermos.cli.common ..... SUCCESS
src.test.python.apache.thermos.cli.main ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 13, 2015, 1:58 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 1:58 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More plumbing.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
> src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
> src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
> src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
> src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
> src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
>
> Diff: https://reviews.apache.org/r/31966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76333
-----------------------------------------------------------
Ship it!
Master (ee1a13a) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 13, 2015, 2:12 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
>
> (Updated March 13, 2015, 2:12 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More plumbing.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
> src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
> src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
> src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
> src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
> src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
>
> Diff: https://reviews.apache.org/r/31966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/
-----------------------------------------------------------
(Updated March 13, 2015, 2:12 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Changes
-------
Neglected to commit hooked_api.py change.
Bugs: AURORA-1077
https://issues.apache.org/jira/browse/AURORA-1077
Repository: aurora
Description
-------
More plumbing.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
Diff: https://reviews.apache.org/r/31966/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/
-----------------------------------------------------------
(Updated March 13, 2015, 1:58 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1077
https://issues.apache.org/jira/browse/AURORA-1077
Repository: aurora
Description
-------
More plumbing.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
Diff: https://reviews.apache.org/r/31966/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76257
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 11, 2015, 6:27 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
>
> (Updated March 11, 2015, 6:27 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More plumbing.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
> src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
> src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
> src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
> src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
> src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
>
> Diff: https://reviews.apache.org/r/31966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76193
-----------------------------------------------------------
@ReviewBot retry
- Bill Farner
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 1:27 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More plumbing.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
> src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
> src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
> src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
> src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
> src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
>
> Diff: https://reviews.apache.org/r/31966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Bill Farner <wf...@apache.org>.
> On March 12, 2015, 1:38 a.m., Aurora ReviewBot wrote:
> > Master (f62e0f1) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > 01:37:22 00:00 [deferred-sources]
> > 01:37:22 00:00 [deferred-sources]
> > 01:37:22 00:00 [gen]
> > 01:37:22 00:00 [thrift][32m
> > Invalidated 4 targets containing 4 payload files.[0m[32m
> > Generating thrift for api/src/main/thrift/org/apache/aurora/gen/test.thrift
> > [0m[32m
> > Generating thrift for api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> > [0m[32m
> > Generating thrift for api/src/main/thrift/org/apache/thermos/thermos_internal.thrift
> > [0m[32m
> > Generating thrift for api/src/main/thrift/org/apache/aurora/gen/storage.thrift
> > [0m
> > 01:37:22 00:00 [scrooge]
> > 01:37:22 00:00 [protoc]
> > 01:37:22 00:00 [antlr]
> > 01:37:22 00:00 [ragel]
> > 01:37:22 00:00 [jaxb]
> > 01:37:23 00:01 [wire]
> > 01:37:23 00:01 [aapt]
> > 01:37:23 00:01 [resolve]
> > 01:37:23 00:01 [ivy]
> > 01:37:23 00:01 [bootstrap-nailgun-server]
> > 01:37:23 00:01 [compile]
> > 01:37:23 00:01 [compile]
> > 01:37:23 00:01 [jvm]
> > 01:37:23 00:01 [jvm-compilers]
> > 01:37:23 00:01 [resources]
> > 01:37:23 00:01 [prepare][32m
> > Invalidated 1 target containing 1 payload file.[0m
> > 01:37:23 00:01 [test]
> > 01:37:23 00:01 [run_prep_command]
> > 01:37:23 00:01 [test]
> > 01:37:23 00:01 [pytest]
> > 01:37:25 00:03 [run]
> > [31m
> > FAILURE[0m
> > Exception message: Cannot satisfy requirements: [Requirement.parse('py>=1.4.25')]
> >
> >
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
fun
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76191
-----------------------------------------------------------
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 1:27 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More plumbing.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
> src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
> src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
> src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
> src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
> src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
>
> Diff: https://reviews.apache.org/r/31966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76191
-----------------------------------------------------------
Master (f62e0f1) is red with this patch.
./build-support/jenkins/build.sh
01:37:22 00:00 [deferred-sources]
01:37:22 00:00 [deferred-sources]
01:37:22 00:00 [gen]
01:37:22 00:00 [thrift][32m
Invalidated 4 targets containing 4 payload files.[0m[32m
Generating thrift for api/src/main/thrift/org/apache/aurora/gen/test.thrift
[0m[32m
Generating thrift for api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
[0m[32m
Generating thrift for api/src/main/thrift/org/apache/thermos/thermos_internal.thrift
[0m[32m
Generating thrift for api/src/main/thrift/org/apache/aurora/gen/storage.thrift
[0m
01:37:22 00:00 [scrooge]
01:37:22 00:00 [protoc]
01:37:22 00:00 [antlr]
01:37:22 00:00 [ragel]
01:37:22 00:00 [jaxb]
01:37:23 00:01 [wire]
01:37:23 00:01 [aapt]
01:37:23 00:01 [resolve]
01:37:23 00:01 [ivy]
01:37:23 00:01 [bootstrap-nailgun-server]
01:37:23 00:01 [compile]
01:37:23 00:01 [compile]
01:37:23 00:01 [jvm]
01:37:23 00:01 [jvm-compilers]
01:37:23 00:01 [resources]
01:37:23 00:01 [prepare][32m
Invalidated 1 target containing 1 payload file.[0m
01:37:23 00:01 [test]
01:37:23 00:01 [run_prep_command]
01:37:23 00:01 [test]
01:37:23 00:01 [pytest]
01:37:25 00:03 [run]
[31m
FAILURE[0m
Exception message: Cannot satisfy requirements: [Requirement.parse('py>=1.4.25')]
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 1:27 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More plumbing.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
> src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
> src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
> src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
> src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
> src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
>
> Diff: https://reviews.apache.org/r/31966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76194
-----------------------------------------------------------
Master (f62e0f1) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.api ..... SUCCESS
src.test.python.apache.aurora.client.cli.client ..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
src.test.python.apache.aurora.client.cli.config ..... SUCCESS
src.test.python.apache.aurora.client.cli.context ..... SUCCESS
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... FAILURE
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.thermos.cli.commands.commands ..... SUCCESS
src.test.python.apache.thermos.cli.common ..... SUCCESS
src.test.python.apache.thermos.cli.main ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 1:27 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More plumbing.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
> src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
> src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
> src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
> src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
> src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
>
> Diff: https://reviews.apache.org/r/31966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Bill Farner <wf...@apache.org>.
> On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/api/__init__.py, line 157
> > <https://reviews.apache.org/r/31966/diff/2/?file=891871#file891871line157>
> >
> > Spacing seems off here and below.
Fixed.
> On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 104
> > <https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line104>
> >
> > I'd also include a short '-m' name to make typing less tedious.
Done.
> On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 107
> > <https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line107>
> >
> > While not entirely consistent, the majority of our CommandOption help strings start with a capital.
Changed.
> On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, lines 123-127
> > <https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line123>
> >
> > Mind sorting them alphabetically?
Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76243
-----------------------------------------------------------
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 1:27 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More plumbing.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
> src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
> src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
> src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
> src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
> src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
>
> Diff: https://reviews.apache.org/r/31966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Bill Farner <wf...@apache.org>.
> On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, lines 123-127
> > <https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line123>
> >
> > Mind sorting them alphabetically?
>
> Bill Farner wrote:
> Done.
Spoke too soon here - ordering is important with these, and this pointed out that my new field should have been named `MESSAGE_OPTION` (as it's an option rather than an argument). I've sorted the options, which are order-agnostic.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76243
-----------------------------------------------------------
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 1:27 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More plumbing.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
> src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
> src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
> src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
> src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
> src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
>
> Diff: https://reviews.apache.org/r/31966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76243
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/api/__init__.py
<https://reviews.apache.org/r/31966/#comment123752>
Spacing seems off here and below.
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/31966/#comment123755>
I'd also include a short '-m' name to make typing less tedious.
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/31966/#comment123753>
While not entirely consistent, the majority of our CommandOption help strings start with a capital.
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/31966/#comment123754>
Mind sorting them alphabetically?
- Maxim Khutornenko
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 1:27 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1077
> https://issues.apache.org/jira/browse/AURORA-1077
>
>
> Repository: aurora
>
>
> Description
> -------
>
> More plumbing.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
> src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
> src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
> src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
> src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
> src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
>
> Diff: https://reviews.apache.org/r/31966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31966: Add client support for including messages
when changing update state.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/
-----------------------------------------------------------
(Updated March 12, 2015, 1:27 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1077
https://issues.apache.org/jira/browse/AURORA-1077
Repository: aurora
Description
-------
More plumbing.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd
src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae
src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635
src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb
src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c
src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61
Diff: https://reviews.apache.org/r/31966/diff/
Testing
-------
Thanks,
Bill Farner