You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/10/13 20:02:47 UTC

[GitHub] [cordova-plugin-device] raphinesse opened a new pull request #109: Log error to console, not to dialog box

raphinesse opened a new pull request #109: Log error to console, not to dialog box
URL: https://github.com/apache/cordova-plugin-device/pull/109
 
 
   ### Platforms affected
   All
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Presenting an error to a user in an alert box is bad UX. And it's annoying as a developer too.
   Plus, I'd like to deprecate `cordova/utils.alert` and this is the only occurrence in a core plugin.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   - log error to console instead of using alert
   - clarify origin of error message
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   None
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org