You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/13 01:42:58 UTC

[GitHub] [shardingsphere] happybyr opened a new pull request #6812: Some parser grammer about PostgreSQL DAL&DCL

happybyr opened a new pull request #6812:
URL: https://github.com/apache/shardingsphere/pull/6812


   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #6812: Some parser grammer about PostgreSQL DAL&DCL&DDL

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #6812:
URL: https://github.com/apache/shardingsphere/pull/6812#issuecomment-675207471


   ## Pull Request Test Coverage Report for [Build 13756](https://coveralls.io/builds/32750029)
   
   * **0** of **5**   **(0.0%)**  changed or added relevant lines in **3** files are covered.
   * **165** unchanged lines in **6** files lost coverage.
   * Overall coverage increased (+**0.5%**) to **57.75%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDALVisitor.java](https://coveralls.io/builds/32750029/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDALVisitor.java#L92) | 0 | 1 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDDLVisitor.java](https://coveralls.io/builds/32750029/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDDLVisitor.java#L290) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/32750029/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L665) | 0 | 2 | 0.0%
   <!-- | **Total:** | **0** | **5** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/context/CreateDataSourcesStatementContext.java](https://coveralls.io/builds/32750029/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Fcontext%2FCreateDataSourcesStatementContext.java#L47) | 1 | 0% |
   | [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/context/CreateShardingRuleStatementContext.java](https://coveralls.io/builds/32750029/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Fcontext%2FCreateShardingRuleStatementContext.java#L43) | 1 | 0% |
   | [shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/java/org/apache/shardingsphere/cluster/heartbeat/detect/HeartbeatHandler.java](https://coveralls.io/builds/32750029/source?filename=shardingsphere-control-panel%2Fshardingsphere-cluster%2Fshardingsphere-cluster-heartbeat%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcluster%2Fheartbeat%2Fdetect%2FHeartbeatHandler.java#L105) | 2 | 87.1% |
   | [shardingsphere-rdl-parser/shardingsphere-rdl-parser-sql/src/main/java/org/apache/shardingsphere/rdl/parser/sql/visitor/ShardingSphereVisitor.java](https://coveralls.io/builds/32750029/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-sql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fsql%2Fvisitor%2FShardingSphereVisitor.java#L99) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDDLVisitor.java](https://coveralls.io/builds/32750029/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDDLVisitor.java#L77) | 45 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/32750029/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L126) | 114 | 0% |
   <!-- | **Total:** | **165** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32750029/badge)](https://coveralls.io/builds/32750029) |
   | :-- | --: |
   | Change from base [Build 13724](https://coveralls.io/builds/32712514): |  0.5% |
   | Covered Lines: | 13055 |
   | Relevant Lines: | 22606 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #6812: Some parser grammer about PostgreSQL DAL&DCL&DDL

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #6812:
URL: https://github.com/apache/shardingsphere/pull/6812#discussion_r470395992



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDDLVisitor.java
##########
@@ -280,4 +286,19 @@ public ASTNode visitTableNamesClause(final TableNamesClauseContext ctx) {
         result.getValue().addAll(tableSegments);
         return result;
     }
+    
+    @Override
+    public ASTNode visitAlterFunction(final AlterFunctionContext ctx) {
+        return new AlterFunctionStatement();
+    }
+    
+    @Override
+    public ASTNode visitAlterProcedure(final AlterProcedureContext ctx) {
+        return new AlterProcedureStatement();
+    }
+    
+    @Override
+    public ASTNode visitCreateFunction(final PostgreSQLStatementParser.CreateFunctionContext ctx) {
+        return new CreateFunctionStatement();
+    }

Review comment:
       change to
   ```
    @Override
       public ASTNode visitCreateFunction(final CreateFunctionContext ctx) {
           return new CreateFunctionStatement();
       }
   ```
   apply to others.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #6812: Some parser grammer about PostgreSQL DAL&DCL&DDL

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #6812:
URL: https://github.com/apache/shardingsphere/pull/6812#issuecomment-675207471


   ## Pull Request Test Coverage Report for [Build 13726](https://coveralls.io/builds/32721417)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **224** unchanged lines in **3** files lost coverage.
   * Overall coverage remained the same at **57.267%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDALVisitor.java](https://coveralls.io/builds/32721417/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDALVisitor.java#L39) | 10 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDDLVisitor.java](https://coveralls.io/builds/32721417/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDDLVisitor.java#L73) | 60 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/32721417/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L124) | 154 | 0% |
   <!-- | **Total:** | **224** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32721417/badge)](https://coveralls.io/builds/32721417) |
   | :-- | --: |
   | Change from base [Build 13724](https://coveralls.io/builds/32712514): |  0.0% |
   | Covered Lines: | 12940 |
   | Relevant Lines: | 22596 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #6812: Some parser grammer about PostgreSQL DAL&DCL&DDL

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #6812:
URL: https://github.com/apache/shardingsphere/pull/6812#issuecomment-675207471


   ## Pull Request Test Coverage Report for [Build 13760](https://coveralls.io/builds/32750525)
   
   * **0** of **6**   **(0.0%)**  changed or added relevant lines in **3** files are covered.
   * **120** unchanged lines in **5** files lost coverage.
   * Overall coverage increased (+**0.5%**) to **57.748%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDALVisitor.java](https://coveralls.io/builds/32750525/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDALVisitor.java#L92) | 0 | 1 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/32750525/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L665) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDDLVisitor.java](https://coveralls.io/builds/32750525/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDDLVisitor.java#L292) | 0 | 3 | 0.0%
   <!-- | **Total:** | **0** | **6** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/context/CreateDataSourcesStatementContext.java](https://coveralls.io/builds/32750525/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Fcontext%2FCreateDataSourcesStatementContext.java#L47) | 1 | 0% |
   | [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/context/CreateShardingRuleStatementContext.java](https://coveralls.io/builds/32750525/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Fcontext%2FCreateShardingRuleStatementContext.java#L43) | 1 | 0% |
   | [shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/java/org/apache/shardingsphere/cluster/heartbeat/detect/HeartbeatHandler.java](https://coveralls.io/builds/32750525/source?filename=shardingsphere-control-panel%2Fshardingsphere-cluster%2Fshardingsphere-cluster-heartbeat%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcluster%2Fheartbeat%2Fdetect%2FHeartbeatHandler.java#L105) | 2 | 87.1% |
   | [shardingsphere-rdl-parser/shardingsphere-rdl-parser-sql/src/main/java/org/apache/shardingsphere/rdl/parser/sql/visitor/ShardingSphereVisitor.java](https://coveralls.io/builds/32750525/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-sql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fsql%2Fvisitor%2FShardingSphereVisitor.java#L99) | 2 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/32750525/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L126) | 114 | 0% |
   <!-- | **Total:** | **120** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32750525/badge)](https://coveralls.io/builds/32750525) |
   | :-- | --: |
   | Change from base [Build 13724](https://coveralls.io/builds/32712514): |  0.5% |
   | Covered Lines: | 13055 |
   | Relevant Lines: | 22607 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #6812: Some parser grammer about PostgreSQL DAL&DCL&DDL

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #6812:
URL: https://github.com/apache/shardingsphere/pull/6812#issuecomment-675207471


   ## Pull Request Test Coverage Report for [Build 13763](https://coveralls.io/builds/32751464)
   
   * **0** of **6**   **(0.0%)**  changed or added relevant lines in **3** files are covered.
   * **6** unchanged lines in **4** files lost coverage.
   * Overall coverage increased (+**0.5%**) to **57.805%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDALVisitor.java](https://coveralls.io/builds/32751464/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDALVisitor.java#L92) | 0 | 1 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/32751464/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L667) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDDLVisitor.java](https://coveralls.io/builds/32751464/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDDLVisitor.java#L292) | 0 | 3 | 0.0%
   <!-- | **Total:** | **0** | **6** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/context/CreateDataSourcesStatementContext.java](https://coveralls.io/builds/32751464/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Fcontext%2FCreateDataSourcesStatementContext.java#L47) | 1 | 0% |
   | [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/context/CreateShardingRuleStatementContext.java](https://coveralls.io/builds/32751464/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Fcontext%2FCreateShardingRuleStatementContext.java#L43) | 1 | 0% |
   | [shardingsphere-control-panel/shardingsphere-cluster/shardingsphere-cluster-heartbeat/src/main/java/org/apache/shardingsphere/cluster/heartbeat/detect/HeartbeatHandler.java](https://coveralls.io/builds/32751464/source?filename=shardingsphere-control-panel%2Fshardingsphere-cluster%2Fshardingsphere-cluster-heartbeat%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcluster%2Fheartbeat%2Fdetect%2FHeartbeatHandler.java#L105) | 2 | 87.1% |
   | [shardingsphere-rdl-parser/shardingsphere-rdl-parser-sql/src/main/java/org/apache/shardingsphere/rdl/parser/sql/visitor/ShardingSphereVisitor.java](https://coveralls.io/builds/32751464/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-sql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fsql%2Fvisitor%2FShardingSphereVisitor.java#L99) | 2 | 0% |
   <!-- | **Total:** | **6** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32751464/badge)](https://coveralls.io/builds/32751464) |
   | :-- | --: |
   | Change from base [Build 13724](https://coveralls.io/builds/32712514): |  0.5% |
   | Covered Lines: | 13068 |
   | Relevant Lines: | 22607 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu merged pull request #6812: Some parser grammer about PostgreSQL DAL&DCL&DDL

Posted by GitBox <gi...@apache.org>.
jingshanglu merged pull request #6812:
URL: https://github.com/apache/shardingsphere/pull/6812


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #6812: Some parser grammer about PostgreSQL DAL&DCL

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #6812:
URL: https://github.com/apache/shardingsphere/pull/6812#discussion_r470367367



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/DDLStatement.g4
##########
@@ -130,8 +130,8 @@ dropDatabase
     : DROP DATABASE (IF EXISTS)? name
     ;
 
-createDatabaseSpecification_
-    :  createdbOptName (EQ_)? (signedIconst | optBooleanOrString | DEFAULT)
+ createDatabaseSpecification_

Review comment:
       keep original format.

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -1639,3 +1639,114 @@ argClass
 funcArgsList
     : funcArg (COMMA_ funcArg)*
     ;
+
+nonReservedWordOrSconst
+    : nonReservedWord
+    | STRING_
+    ;
+
+fileName
+    : STRING_
+    ;
+
+roleList
+    : roleSpec (COMMA_ roleSpec)*
+    ;
+
+setResetClause
+    : SET setRest
+    | variableResetStmt
+    ;
+
+setRest
+    : TRANSACTION transactionModeList
+    | SESSION CHARACTERISTICS AS TRANSACTION transactionModeList
+    | setRestMore
+    ;
+
+transactionModeList
+    : transactionModeItem ((COMMA_)? transactionModeItem)*
+    ;
+
+transactionModeItem
+    : ISOLATION LEVEL isoLevel
+    | READ ONLY
+    | READ WRITE
+    | DEFERRABLE
+    | NOT DEFERRABLE
+    ;
+
+setRestMore
+    : genericSet
+    | varName FROM CURRENT
+    | TIME ZONE zoneValue
+    | CATALOG STRING_
+    | SCHEMA STRING_
+    | NAMES encoding?
+    | ROLE nonReservedWord | STRING_
+    | SESSION AUTHORIZATION nonReservedWord | STRING_
+    | SESSION AUTHORIZATION DEFAULT
+    | XML OPTION documentOrContent
+    | TRANSACTION SNAPSHOT STRING_
+    ;
+
+encoding
+    : STRING_
+    | DEFAULT
+    ;
+
+genericSet
+    : varName (EQ_|TO) (varList | DEFAULT)
+    ;
+
+variableResetStmt
+    : RESET resetRest
+    ;
+
+resetRest
+    : genericReset
+    | TIME ZONE
+    | TRANSACTION ISOLATION LEVEL
+    | SESSION AUTHORIZATION
+    ;
+
+genericReset
+    : varName
+    | ALL
+    ;
+
+relationExprList
+    : relationExpr (COMMA_ relationExpr)*
+    ;
+
+relationExpr
+    : qualifiedName
+    | qualifiedName ASTERISK_
+    | ONLY qualifiedName
+    | ONLY LP_ qualifiedName RP_
+    ;
+
+commonFuncOptItem
+    : CALLED ON NULL INPUT
+    | RETURNS NULL ON NULL INPUT
+    | STRICT
+    | IMMUTABLE
+    | STABLE
+    | VOLATILE
+    | EXTERNAL SECURITY DEFINER
+    | EXTERNAL SECURITY INVOKER
+    | SECURITY DEFINER
+    | SECURITY INVOKER
+    | LEAKPROOF
+    | NOT LEAKPROOF
+    | COST numericOnly
+    | ROWS numericOnly
+    | SUPPORT anyName
+    | functionSetResetClause
+    | PARALLEL colId
+    ;
+
+functionSetResetClause
+    : SET setRestMore
+    | variableResetStmt
+    ;

Review comment:
       Add a new line at end of file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org