You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by jlahoda <gi...@git.apache.org> on 2017/10/08 15:44:23 UTC
[GitHub] incubator-netbeans pull request #99: [NETBEANS-54] Module Review applemenu
GitHub user jlahoda opened a pull request:
https://github.com/apache/incubator-netbeans/pull/99
[NETBEANS-54] Module Review applemenu
-using an external library instead of inline com/apple/eawt classes
-saner handling of "external" java.awt classes (not unpacking them into the source directory)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jlahoda/incubator-netbeans applemenu-review
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit 898a030c44e6002a4861ea409e32fc63d6d5a4a6
Author: Jan Lahoda <jl...@netbeans.org>
Date: 2017-10-08T15:36:00Z
[NETBEANS-54] Module Review applemenu
-using an external library instead of inline com/apple/eawt classes
-saner handling of "external" java.awt classes (not unpacking them into the source directory)
----
---
[GitHub] incubator-netbeans issue #99: [NETBEANS-54] Module Review applemenu
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/99
I agree - this looks good. I don't own a mac, so it would be good if someone with a mac could give it a spin.
---
[GitHub] incubator-netbeans issue #99: [NETBEANS-54] Module Review applemenu
Posted by geertjanw <gi...@git.apache.org>.
Github user geertjanw commented on the issue:
https://github.com/apache/incubator-netbeans/pull/99
Wow, excellent, thanks, that helps a lot.
---
[GitHub] incubator-netbeans issue #99: [NETBEANS-54] Module Review applemenu
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/99
@mcdonnell-john thank you for having a look - this was what I wanted to have ensured. Call it quick-test or smoke test, just to make sure the functions work in general. For me this is good to go in.
---
[GitHub] incubator-netbeans pull request #99: [NETBEANS-54] Module Review applemenu
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/99
---
[GitHub] incubator-netbeans issue #99: [NETBEANS-54] Module Review applemenu
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/99
Merged:
https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans.git;a=commit;h=56c952886e51619183a234ffcd7738910de5f31f
Thanks for the comments/testing.
---
[GitHub] incubator-netbeans issue #99: [NETBEANS-54] Module Review applemenu
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/99
I've originally forgot to cleanup the build.xml. I've updated the pull request with the cleanup now.
---
[GitHub] incubator-netbeans issue #99: [NETBEANS-54] Module Review applemenu
Posted by mcdonnell-john <gi...@git.apache.org>.
Github user mcdonnell-john commented on the issue:
https://github.com/apache/incubator-netbeans/pull/99
@matthiasblaesing I've checked out the PR and it builds fine on my machine.
After running it I've not seen any issues with the menu. Been able to open projects. Look at the about dialog, etc. and in general, all menus seem to be working the same as they do on 8.2.
Any specific checks you want me to perform?
---