[GitHub] incubator-rocketmq pull request #34: [ROCKETMQ-39] avoid duplicated codes.

[WillemJiang <gi...@git.apache.org>]

Github user WillemJiang commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97189548
  
    --- Diff: filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java ---
    @@ -139,7 +139,7 @@ public static FiltersrvController createController(String[] args) {
     
                 Runtime.getRuntime().addShutdownHook(new ShutdownHookThread(log, new Callable() {
                     @Override
    -                public Object call() throws Exception {
    +                public Void call() throws Exception {
                         controller.shutdown();
                         return null;
    --- End diff --
    
    When use the Void as the return signature, you don't need to use return in the function.  
    Please remove the line of 144.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---