You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/18 19:02:37 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #19689: add redis runAsUser option (#19681)

potiuk commented on a change in pull request #19689:
URL: https://github.com/apache/airflow/pull/19689#discussion_r752542302



##########
File path: chart/values.schema.json
##########
@@ -2856,6 +2856,11 @@
                     "type": "array",
                     "default": []
                 },
+                "uid": {

Review comment:
       I believe this should come as part of .Values.redis.uid parameter ? 
   
   For compatibiity with previous version also I tihnk this should have `None` default and the whole `security-context` section should be conditional based on the uid set, I think because someone upgrading the chart will already have a root-owned db in /data abwhen persistence is enabled and it might get non-accessible if "runAsUser" is used. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org