You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/10/21 15:05:15 UTC
[GitHub] [fineract] vorburger opened a new pull request #1458: Disable frequently failing SchedulerJobsTest.testFlippingSchedulerStatus (FINERACT-1167)
vorburger opened a new pull request #1458:
URL: https://github.com/apache/fineract/pull/1458
see FINERACT-1167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1458: Disable frequently failing SchedulerJobsTest.testFlippingSchedulerStatus (FINERACT-1167)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1458:
URL: https://github.com/apache/fineract/pull/1458#issuecomment-715131911
Hi @vorburger - do we know why this fails? When I looked at this at one point it was actually due to a timeout - i.e. some of the scheduled jobs took too long to complete. If that's the case then fix would be easy by just increasing the timeout. Maybe to understand why this fails we need to first fix the logging for integration tests...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1458: Disable frequently failing SchedulerJobsTest.testFlippingSchedulerStatus (FINERACT-1167)
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1458:
URL: https://github.com/apache/fineract/pull/1458#issuecomment-718052221
I just feel increasing timeouts won't cut it. Doesn't sound like a real solution. Unfortunately, I don't understand much about schedular jobs to have a proper say in this but I think we have some performance issues. Need to figure out how to deal with that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1458: Disable frequently failing SchedulerJobsTest.testFlippingSchedulerStatus (FINERACT-1167)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1458:
URL: https://github.com/apache/fineract/pull/1458#issuecomment-719233004
@xurror fully agree that if the problem is timeouts, we should fix the performance issue and not increase the timeout. But I wasn't sure whether that's actually the cause in this case: that's one reason why I've seen this test fail, but that has mainly been when you run it on a test database that has a lot of data in it. I have never seen a timeout failure on an empty database (as in our integration tests), so we should first establish why this fails - unless someone already knows?
But this may then be linked to improving logging on integration test failures which could be achieved by using Spring Boot to run them directly without Cargo... so maybe we should first focus on those in order to have the data to debug this with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org