[GitHub] [arrow] jorisvandenbossche commented on pull request #10598: ARROW-13054: [C++] Add TemporalOptions

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868441918


   > I was wondering about locale as well. Would it be a good idea to be able to set an arbitrary locale in some cases? [Pandas appears not to offer this option](https://pandas.pydata.org/docs/reference/api/pandas.Series.dt.dayofweek.html). It would be useful for strftime but could cause misinterpretations for say day_of_week.
   
   Pandas actually has a different method (the one you link is an attribute that has been there for a long time, so but pandas added an additional method so it could have arguments) that takes a locale arguments: https://pandas.pydata.org/docs/reference/api/pandas.Series.dt.day_name.html
   
   Personally, I would (at least for now) leave all locale-specific handling to the bindings / downstream applications (except for `strftime`). As Nic says, if we only return integers (and not `labels`) for now, we shouldn't need locale handling (I wouldn't let the number depend on the locale, that seems very easy to miss).
   
   ----
   
   About the actual options in this PR: that seems like a good start, but I don't think all those options would be needed in a single Options struct? For example, the ambiguous/non-existent handling, those can be put in a specific options struct for the kernel that needs it?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org