You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/05/28 16:26:19 UTC

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4243: Add support for passing headers in pinot client

npawar commented on a change in pull request #4243: Add support for passing headers in pinot client
URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288192721
 
 

 ##########
 File path: pinot-api/src/test/java/org/apache/pinot/client/PreparedStatementTest.java
 ##########
 @@ -69,9 +70,10 @@ public String getLastQuery() {
 
   class DummyPinotClientTransportFactory implements PinotClientTransportFactory {
     @Override
-    public PinotClientTransport buildTransport() {
+    public PinotClientTransport buildTransport(Map<String, String> headers) {
       return _dummyPinotClientTransport;
     }
+
 
 Review comment:
   nit: remove newline

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org