You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/01 05:04:29 UTC

[GitHub] [incubator-dolphinscheduler] simon824 opened a new pull request #2858: Using Jackson instead of Fastjson

simon824 opened a new pull request #2858:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2858


   I replaced all fastjson except fastjson configuration related to SerializerFeature.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2858: Using Jackson instead of Fastjson

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2858:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2858#issuecomment-636683009


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=h1) Report
   > Merging [#2858](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8f8ddae03098b60f0c4f1637c1e3b5670df18b70&el=desc) will **decrease** coverage by `0.42%`.
   > The diff coverage is `12.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #2858      +/-   ##
   ============================================
   - Coverage     37.21%   36.79%   -0.43%     
   + Complexity     2560     2541      -19     
   ============================================
     Files           435      434       -1     
     Lines         20020    20049      +29     
     Branches       2426     2433       +7     
   ============================================
   - Hits           7451     7377      -74     
   - Misses        11904    12013     +109     
   + Partials        665      659       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `61.70% <0.00%> (+1.28%)` | `13.00 <0.00> (ø)` | |
   | [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `78.94% <ø> (ø)` | `8.00 <0.00> (ø)` | |
   | [...scheduler/api/dto/resources/ResourceComponent.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9yZXNvdXJjZXMvUmVzb3VyY2VDb21wb25lbnQuamF2YQ==) | `72.72% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | [...olphinscheduler/api/service/DataSourceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YVNvdXJjZVNlcnZpY2UuamF2YQ==) | `2.22% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `60.86% <0.00%> (ø)` | `75.00 <0.00> (ø)` | |
   | [...apache/dolphinscheduler/common/model/TaskNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Rhc2tOb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `34.17% <0.00%> (-0.51%)` | `21.00 <0.00> (ø)` | |
   | [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `40.00% <ø> (ø)` | `13.00 <0.00> (ø)` | |
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `51.07% <ø> (-2.88%)` | `9.00 <0.00> (-2.00)` | |
   | [...e/dolphinscheduler/remote/NettyRemotingServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdTZXJ2ZXIuamF2YQ==) | `76.19% <ø> (ø)` | `7.00 <0.00> (ø)` | |
   | ... and [72 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=footer). Last update [8f8ddae...058b898](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2858: Using Jackson instead of Fastjson

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2858:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2858#issuecomment-636683009


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=h1) Report
   > Merging [#2858](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8f8ddae03098b60f0c4f1637c1e3b5670df18b70&el=desc) will **decrease** coverage by `0.25%`.
   > The diff coverage is `14.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #2858      +/-   ##
   ============================================
   - Coverage     37.21%   36.96%   -0.26%     
   + Complexity     2560     2552       -8     
   ============================================
     Files           435      434       -1     
     Lines         20020    20049      +29     
     Branches       2426     2433       +7     
   ============================================
   - Hits           7451     7411      -40     
   - Misses        11904    11979      +75     
   + Partials        665      659       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `61.70% <0.00%> (+1.28%)` | `13.00 <0.00> (ø)` | |
   | [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `78.94% <ø> (ø)` | `8.00 <0.00> (ø)` | |
   | [...scheduler/api/dto/resources/ResourceComponent.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9yZXNvdXJjZXMvUmVzb3VyY2VDb21wb25lbnQuamF2YQ==) | `72.72% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | [...olphinscheduler/api/service/DataSourceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YVNvdXJjZVNlcnZpY2UuamF2YQ==) | `2.22% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `60.86% <0.00%> (ø)` | `75.00 <0.00> (ø)` | |
   | [...apache/dolphinscheduler/common/model/TaskNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Rhc2tOb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `34.17% <0.00%> (-0.51%)` | `21.00 <0.00> (ø)` | |
   | [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `40.00% <ø> (ø)` | `13.00 <0.00> (ø)` | |
   | [...cheduler/remote/command/TaskExecuteAckCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvVGFza0V4ZWN1dGVBY2tDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...uler/remote/command/TaskExecuteRequestCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvVGFza0V4ZWN1dGVSZXF1ZXN0Q29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [46 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=footer). Last update [8f8ddae...f2344b2](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-commenter commented on pull request #2858: Using Jackson instead of Fastjson

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2858:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2858#issuecomment-636683009


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=h1) Report
   > Merging [#2858](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8f8ddae03098b60f0c4f1637c1e3b5670df18b70&el=desc) will **decrease** coverage by `0.44%`.
   > The diff coverage is `8.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #2858      +/-   ##
   ============================================
   - Coverage     37.21%   36.77%   -0.45%     
   + Complexity     2560     2538      -22     
   ============================================
     Files           435      434       -1     
     Lines         20020    20029       +9     
     Branches       2426     2433       +7     
   ============================================
   - Hits           7451     7366      -85     
   - Misses        11904    12007     +103     
   + Partials        665      656       -9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `61.70% <0.00%> (+1.28%)` | `13.00 <0.00> (ø)` | |
   | [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `78.94% <ø> (ø)` | `8.00 <0.00> (ø)` | |
   | [...olphinscheduler/api/service/DataSourceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YVNvdXJjZVNlcnZpY2UuamF2YQ==) | `2.22% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `60.86% <0.00%> (ø)` | `75.00 <0.00> (ø)` | |
   | [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `57.06% <ø> (ø)` | `67.00 <0.00> (ø)` | |
   | [...apache/dolphinscheduler/common/model/TaskNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Rhc2tOb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `34.17% <0.00%> (-0.51%)` | `21.00 <0.00> (ø)` | |
   | [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `40.00% <ø> (ø)` | `13.00 <0.00> (ø)` | |
   | [...cheduler/remote/command/TaskExecuteAckCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvVGFza0V4ZWN1dGVBY2tDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...uler/remote/command/TaskExecuteRequestCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvVGFza0V4ZWN1dGVSZXF1ZXN0Q29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [48 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=footer). Last update [8f8ddae...d9e6b31](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2858: Using Jackson instead of Fastjson

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2858:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2858#issuecomment-636683009


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=h1) Report
   > Merging [#2858](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8f8ddae03098b60f0c4f1637c1e3b5670df18b70&el=desc) will **decrease** coverage by `0.26%`.
   > The diff coverage is `13.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #2858      +/-   ##
   ============================================
   - Coverage     37.21%   36.95%   -0.27%     
   + Complexity     2560     2552       -8     
   ============================================
     Files           435      434       -1     
     Lines         20020    20049      +29     
     Branches       2426     2433       +7     
   ============================================
   - Hits           7451     7409      -42     
   - Misses        11904    11981      +77     
   + Partials        665      659       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `61.70% <0.00%> (+1.28%)` | `13.00 <0.00> (ø)` | |
   | [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `78.94% <ø> (ø)` | `8.00 <0.00> (ø)` | |
   | [...scheduler/api/dto/resources/ResourceComponent.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9yZXNvdXJjZXMvUmVzb3VyY2VDb21wb25lbnQuamF2YQ==) | `72.72% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | [...olphinscheduler/api/service/DataSourceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YVNvdXJjZVNlcnZpY2UuamF2YQ==) | `2.22% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `60.86% <0.00%> (ø)` | `75.00 <0.00> (ø)` | |
   | [...apache/dolphinscheduler/common/model/TaskNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Rhc2tOb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `34.17% <0.00%> (-0.51%)` | `21.00 <0.00> (ø)` | |
   | [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `40.00% <ø> (ø)` | `13.00 <0.00> (ø)` | |
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `53.95% <ø> (ø)` | `11.00 <0.00> (ø)` | |
   | [...e/dolphinscheduler/remote/NettyRemotingServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdTZXJ2ZXIuamF2YQ==) | `76.19% <ø> (ø)` | `7.00 <0.00> (ø)` | |
   | ... and [71 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=footer). Last update [8f8ddae...1628803](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2858: Using Jackson instead of Fastjson

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2858:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2858#issuecomment-636683009


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=h1) Report
   > Merging [#2858](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8f8ddae03098b60f0c4f1637c1e3b5670df18b70&el=desc) will **decrease** coverage by `0.26%`.
   > The diff coverage is `13.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #2858      +/-   ##
   ============================================
   - Coverage     37.21%   36.95%   -0.27%     
   + Complexity     2560     2551       -9     
   ============================================
     Files           435      434       -1     
     Lines         20020    20049      +29     
     Branches       2426     2433       +7     
   ============================================
   - Hits           7451     7409      -42     
   - Misses        11904    11981      +77     
   + Partials        665      659       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `61.70% <0.00%> (+1.28%)` | `13.00 <0.00> (ø)` | |
   | [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `78.94% <ø> (ø)` | `8.00 <0.00> (ø)` | |
   | [...scheduler/api/dto/resources/ResourceComponent.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9yZXNvdXJjZXMvUmVzb3VyY2VDb21wb25lbnQuamF2YQ==) | `72.72% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | [...olphinscheduler/api/service/DataSourceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YVNvdXJjZVNlcnZpY2UuamF2YQ==) | `2.22% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `60.86% <0.00%> (ø)` | `75.00 <0.00> (ø)` | |
   | [...apache/dolphinscheduler/common/model/TaskNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Rhc2tOb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `34.17% <0.00%> (-0.51%)` | `21.00 <0.00> (ø)` | |
   | [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `40.00% <ø> (ø)` | `13.00 <0.00> (ø)` | |
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `51.07% <ø> (-2.88%)` | `9.00 <0.00> (-2.00)` | |
   | [...e/dolphinscheduler/remote/NettyRemotingServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdTZXJ2ZXIuamF2YQ==) | `76.19% <ø> (ø)` | `7.00 <0.00> (ø)` | |
   | ... and [72 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=footer). Last update [8f8ddae...95966d7](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] simon824 closed pull request #2858: Using Jackson instead of Fastjson

Posted by GitBox <gi...@apache.org>.
simon824 closed pull request #2858:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2858


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2858: Using Jackson instead of Fastjson

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2858:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2858#issuecomment-636683009


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=h1) Report
   > Merging [#2858](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8f8ddae03098b60f0c4f1637c1e3b5670df18b70&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `14.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #2858      +/-   ##
   ============================================
   - Coverage     37.21%   36.93%   -0.29%     
   + Complexity     2560     2550      -10     
   ============================================
     Files           435      434       -1     
     Lines         20020    20049      +29     
     Branches       2426     2433       +7     
   ============================================
   - Hits           7451     7405      -46     
   - Misses        11904    11983      +79     
   + Partials        665      661       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `61.70% <0.00%> (+1.28%)` | `13.00 <0.00> (ø)` | |
   | [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `78.94% <ø> (ø)` | `8.00 <0.00> (ø)` | |
   | [...scheduler/api/dto/resources/ResourceComponent.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9yZXNvdXJjZXMvUmVzb3VyY2VDb21wb25lbnQuamF2YQ==) | `72.72% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | [...olphinscheduler/api/service/DataSourceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YVNvdXJjZVNlcnZpY2UuamF2YQ==) | `2.22% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `60.86% <0.00%> (ø)` | `75.00 <0.00> (ø)` | |
   | [...apache/dolphinscheduler/common/model/TaskNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Rhc2tOb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `34.17% <0.00%> (-0.51%)` | `21.00 <0.00> (ø)` | |
   | [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `40.00% <ø> (ø)` | `13.00 <0.00> (ø)` | |
   | [...cheduler/remote/command/TaskExecuteAckCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvVGFza0V4ZWN1dGVBY2tDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...uler/remote/command/TaskExecuteRequestCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvVGFza0V4ZWN1dGVSZXF1ZXN0Q29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [47 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=footer). Last update [8f8ddae...8039328](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2858: Using Jackson instead of Fastjson

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2858:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2858#issuecomment-636683009


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=h1) Report
   > Merging [#2858](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8f8ddae03098b60f0c4f1637c1e3b5670df18b70&el=desc) will **decrease** coverage by `0.26%`.
   > The diff coverage is `13.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #2858      +/-   ##
   ============================================
   - Coverage     37.21%   36.95%   -0.27%     
   + Complexity     2560     2552       -8     
   ============================================
     Files           435      434       -1     
     Lines         20020    20035      +15     
     Branches       2426     2433       +7     
   ============================================
   - Hits           7451     7404      -47     
   - Misses        11904    11970      +66     
   + Partials        665      661       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `61.70% <0.00%> (+1.28%)` | `13.00 <0.00> (ø)` | |
   | [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `78.94% <ø> (ø)` | `8.00 <0.00> (ø)` | |
   | [...scheduler/api/dto/resources/ResourceComponent.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9yZXNvdXJjZXMvUmVzb3VyY2VDb21wb25lbnQuamF2YQ==) | `72.72% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | [...olphinscheduler/api/service/DataSourceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YVNvdXJjZVNlcnZpY2UuamF2YQ==) | `2.22% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `60.86% <0.00%> (ø)` | `75.00 <0.00> (ø)` | |
   | [...apache/dolphinscheduler/common/model/TaskNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Rhc2tOb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `34.17% <0.00%> (-0.51%)` | `21.00 <0.00> (ø)` | |
   | [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `40.00% <ø> (ø)` | `13.00 <0.00> (ø)` | |
   | [...cheduler/remote/command/TaskExecuteAckCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvVGFza0V4ZWN1dGVBY2tDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...uler/remote/command/TaskExecuteRequestCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvVGFza0V4ZWN1dGVSZXF1ZXN0Q29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [47 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=footer). Last update [8f8ddae...8df6e54](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2858: Using Jackson instead of Fastjson

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2858:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2858#issuecomment-636683009


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=h1) Report
   > Merging [#2858](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8f8ddae03098b60f0c4f1637c1e3b5670df18b70&el=desc) will **decrease** coverage by `0.44%`.
   > The diff coverage is `13.21%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #2858      +/-   ##
   ============================================
   - Coverage     37.21%   36.77%   -0.45%     
   + Complexity     2560     2540      -20     
   ============================================
     Files           435      434       -1     
     Lines         20020    20049      +29     
     Branches       2426     2433       +7     
   ============================================
   - Hits           7451     7373      -78     
   - Misses        11904    12016     +112     
   + Partials        665      660       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `61.70% <0.00%> (+1.28%)` | `13.00 <0.00> (ø)` | |
   | [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `78.94% <ø> (ø)` | `8.00 <0.00> (ø)` | |
   | [...scheduler/api/dto/resources/ResourceComponent.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9yZXNvdXJjZXMvUmVzb3VyY2VDb21wb25lbnQuamF2YQ==) | `72.72% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | [...olphinscheduler/api/service/DataSourceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRGF0YVNvdXJjZVNlcnZpY2UuamF2YQ==) | `2.22% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `60.86% <0.00%> (ø)` | `75.00 <0.00> (ø)` | |
   | [...apache/dolphinscheduler/common/model/TaskNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Rhc2tOb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `34.17% <0.00%> (-0.51%)` | `21.00 <0.00> (ø)` | |
   | [.../dolphinscheduler/common/utils/ParameterUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1BhcmFtZXRlclV0aWxzLmphdmE=) | `40.00% <ø> (ø)` | `13.00 <0.00> (ø)` | |
   | [...cheduler/remote/command/TaskExecuteAckCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvVGFza0V4ZWN1dGVBY2tDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...uler/remote/command/TaskExecuteRequestCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvVGFza0V4ZWN1dGVSZXF1ZXN0Q29tbWFuZC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [47 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=footer). Last update [8f8ddae...cf8803d](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org