You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/11/27 19:38:03 UTC
Review Request 64091: Log Feeder: handle multiple '=' (split char) in
key/value filter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64091/
-----------------------------------------------------------
Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.
Bugs: AMBARI-22526
https://issues.apache.org/jira/browse/AMBARI-22526
Repository: ambari
Description
-------
Logfeeder key/value filter cannot handle multiple occurence of split char -> in order to solve that we can limit the number of splits
Diffs
-----
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java b04a439
Diff: https://reviews.apache.org/r/64091/diff/1/
Testing
-------
done
Thanks,
Oliver Szabo
Re: Review Request 64091: Log Feeder: handle multiple '=' (split
char) in key/value filter
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64091/#review191929
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Nov. 27, 2017, 7:38 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64091/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2017, 7:38 p.m.)
>
>
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.
>
>
> Bugs: AMBARI-22526
> https://issues.apache.org/jira/browse/AMBARI-22526
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Logfeeder key/value filter cannot handle multiple occurence of split char -> in order to solve that we can limit the number of splits
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java b04a439
>
>
> Diff: https://reviews.apache.org/r/64091/diff/1/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 64091: Log Feeder: handle multiple '=' (split
char) in key/value filter
Posted by Krisztian Kasa <kk...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64091/#review191997
-----------------------------------------------------------
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
Line 140 (original), 140 (patched)
<https://reviews.apache.org/r/64091/#comment269993>
Why do we truncate the logmessage? Information can be lost.
- Krisztian Kasa
On Nov. 27, 2017, 8:54 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64091/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2017, 8:54 p.m.)
>
>
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.
>
>
> Bugs: AMBARI-22526
> https://issues.apache.org/jira/browse/AMBARI-22526
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Logfeeder key/value filter cannot handle multiple occurence of split char -> in order to solve that we can limit the number of splits
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java b04a439
>
>
> Diff: https://reviews.apache.org/r/64091/diff/2/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 64091: Log Feeder: handle multiple '=' (split
char) in key/value filter
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64091/#review191999
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On Nov. 27, 2017, 8:54 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64091/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2017, 8:54 p.m.)
>
>
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.
>
>
> Bugs: AMBARI-22526
> https://issues.apache.org/jira/browse/AMBARI-22526
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Logfeeder key/value filter cannot handle multiple occurence of split char -> in order to solve that we can limit the number of splits
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java b04a439
>
>
> Diff: https://reviews.apache.org/r/64091/diff/2/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 64091: Log Feeder: handle multiple '=' (split
char) in key/value filter
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64091/
-----------------------------------------------------------
(Updated Nov. 27, 2017, 8:54 p.m.)
Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.
Changes
-------
split the right values
Bugs: AMBARI-22526
https://issues.apache.org/jira/browse/AMBARI-22526
Repository: ambari
Description
-------
Logfeeder key/value filter cannot handle multiple occurence of split char -> in order to solve that we can limit the number of splits
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java b04a439
Diff: https://reviews.apache.org/r/64091/diff/2/
Changes: https://reviews.apache.org/r/64091/diff/1-2/
Testing
-------
done
Thanks,
Oliver Szabo