[GitHub] [ozone] sumitagrawl commented on a diff in pull request #4112: HDDS-7473. Ratis integration for support of remove registeration

[GitBox <gi...@apache.org>]

sumitagrawl commented on code in PR #4112:
URL: https://github.com/apache/ozone/pull/4112#discussion_r1053474526


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -114,6 +117,8 @@ public class HddsDatanodeService extends GenericCli implements ServicePlugin {
       new DNMXBeanImpl(HddsVersionInfo.HDDS_VERSION_INFO) { };
   private ObjectName dnInfoBeanName;
   private DatanodeCRLStore dnCRLStore;
+  private List<Pair<Consumer<RatisMetricRegistry>,
+      Consumer<RatisMetricRegistry>>> ratisRegistryList = null;

Review Comment:
   Updated...



##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/RatisDropwizardExports.java:
##########
@@ -43,21 +47,34 @@ public RatisDropwizardExports(MetricRegistry registry) {
     super(registry, new RatisNameRewriteSampleBuilder());
   }
 
-  public static void registerRatisMetricReporters(
+  public static List<Pair<Consumer<RatisMetricRegistry>,
+      Consumer<RatisMetricRegistry>>> registerRatisMetricReporters(

Review Comment:
   Updated...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org