You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/23 17:17:21 UTC
[GitHub] [solr] joshsouza opened a new pull request, #1042: Add the `sts` module to the gradle build
joshsouza opened a new pull request, #1042:
URL: https://github.com/apache/solr/pull/1042
https://issues.apache.org/jira/browse/SOLR-16429
# Description
This PR adds `software.amazon.awssdk:sts` to the dependencies for the `s3-repository` module so that IRSA/Web Identity Tokens work
# Solution
Build with this dependency
# Tests
I've tested that adding the `jar` for `sts` to a Solr container fixes the errors seen in https://github.com/apache/solr-operator/issues/475.
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [X] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1042: Add the `sts` module to the gradle build
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #1042:
URL: https://github.com/apache/solr/pull/1042#issuecomment-1256473436
Hey josh, I took your 8.11 code and got started in #1041. I think it should be good to go, if you have some time to look it over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman closed pull request #1042: Add the `sts` module to the gradle build
Posted by GitBox <gi...@apache.org>.
HoustonPutman closed pull request #1042: Add the `sts` module to the gradle build
URL: https://github.com/apache/solr/pull/1042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org