[GitHub] [arrow] mapleFU commented on a diff in pull request #34355: GH-34351: [C++][Parquet] Statistic: tiny optimization

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #34355:
URL: https://github.com/apache/arrow/pull/34355#discussion_r1150011023


##########
cpp/src/parquet/statistics.cc:
##########
@@ -495,9 +495,12 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
                       bool has_null_count, bool has_distinct_count, MemoryPool* pool)
       : TypedStatisticsImpl(descr, pool) {
     TypedStatisticsImpl::IncrementNumValues(num_values);
+    // Currently, `has_null_count` argument is not used.
+    // Internal has_null_count_ would always be true.

Review Comment:
   After a weird patch, this class is used in reader, but ndv is not used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org